Protect quotes in show-ssh output

Some ssh option are quoted because their arguments may contain
spaces. These quotes must be passed to ssh and not removed by
the shell, so this command can work:

  sh -c $(limactl show-ssh $INSTANCE)

Example output:

  ssh -o 'IdentityFile="/Users/jan/Library/Application Support/rancher-desktop/lima/_config/user"' ...

Without the extra single quotes, the `sh -c` command above fails with:

  command-line line 0: garbage at end of line; "Support/rancher-desktop/lima/_config/user".

Signed-off-by: Jan Dubois <[email protected]>

Author: jandubois

cmd/limactl/show_ssh.go

@@ -96,21 +96,29 @@ func showSSHAction(cmd *cobra.Command, args []string) error {
 	return formatSSH(w, instName, format, opts)
 }
 
+func quoteOption(o string) string {
+	// make sure the shell doesn't swallow quotes in option values
+	if strings.ContainsRune(o, '"') {
+		o = "'" + o + "'"
+	}
+	return o
+}
+
 func formatSSH(w io.Writer, instName, format string, opts []string) error {
 	fakeHostname := "lima-" + instName // corresponds to the default guest hostname
 	switch format {
 	case showSSHFormatCmd:
 		args := []string{"ssh"}
 		for _, o := range opts {
-			args = append(args, "-o", o)
+			args = append(args, "-o", quoteOption(o))
 		}
 		args = append(args, fakeHostname)
 		// the args are similar to `limactl shell` but not exactly same. (e.g., lacks -t)
 		fmt.Fprintln(w, strings.Join(args, " ")) // no need to use shellescape.QuoteCommand
 	case showSSHFormatArgs:
 		var args []string
 		for _, o := range opts {
-			args = append(args, "-o", o)
+			args = append(args, "-o", quoteOption(o))
 		}
 		fmt.Fprintln(w, strings.Join(args, " ")) // no need to use shellescape.QuoteCommand
 	case showSSHFormatOptions: