Don't show the vnc display password in the log

afbjorklund · afbjorklund · commit bb4fe8a1aca0 · 2023-02-11T16:58:45.000+01:00
Signed-off-by: Anders F Björklund &lt;anders.f.bjorklund@gmail.com&gt;
diff --git a/pkg/hostagent/hostagent.go b/pkg/hostagent/hostagent.go
@@ -329,10 +329,10 @@ func (a *HostAgent) Run(ctx context.Context) error {
 		if err := os.WriteFile(vncfile, []byte(vncdisplay), 0600); err != nil {
 			return err
 		}
-		vncurl := "vnc://:" + vncpasswd + "@" + net.JoinHostPort(vnchost, vncport)
-		logrus.Infof("VNC server running at <%s>", vncurl)
-		logrus.Infof("VNC Display: \"%s\" `%s`", vncdisplay, vncfile)
-		logrus.Infof("VNC Password: \"%s\" `%s`", vncpasswd, vncpwdfile)
+		vncurl := "vnc://" + net.JoinHostPort(vnchost, vncport)
+		logrus.Infof("VNC server running at %s <%s>", vncdisplay, vncurl)
+		logrus.Infof("VNC Display: `%s`", vncfile)
+		logrus.Infof("VNC Password: `%s`", vncpwdfile)
 	}
 
 	stBase := events.Status{

Original file line number	Diff line number	Diff line change
`@@ -329,10 +329,10 @@ func (a *HostAgent) Run(ctx context.Context) error {`
`329`	`329`	`if err := os.WriteFile(vncfile, []byte(vncdisplay), 0600); err != nil {`
`330`	`330`	`return err`
`331`	`331`	`}`
`332`		`- vncurl := "vnc://:" + vncpasswd + "@" + net.JoinHostPort(vnchost, vncport)`
`333`		`- logrus.Infof("VNC server running at <%s>", vncurl)`
`334`		- logrus.Infof("VNC Display: \"%s\" `%s`", vncdisplay, vncfile)
`335`		- logrus.Infof("VNC Password: \"%s\" `%s`", vncpasswd, vncpwdfile)
	`332`	`+ vncurl := "vnc://" + net.JoinHostPort(vnchost, vncport)`
	`333`	`+ logrus.Infof("VNC server running at %s <%s>", vncdisplay, vncurl)`
	`334`	+ logrus.Infof("VNC Display: `%s`", vncfile)
	`335`	+ logrus.Infof("VNC Password: `%s`", vncpwdfile)
`336`	`336`	`}`
`337`	`337`
`338`	`338`	`stBase := events.Status{`