.golangci.yml: enable staticcheck

```
pkg/editutil/editutil.go:55:17: unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
func OpenEditor(name string, content []byte, hdr string) ([]byte, error) {
                ^
pkg/downloader/downloader.go:480:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
        if err := os.Rename(localPathTmp, localPath); err != nil {
                return err
        }
pkg/guestagent/api/server/server.go:19:50: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
func (b *Backend) onError(w http.ResponseWriter, r *http.Request, err error, ec int) {
                                                 ^
pkg/cidata/cidata_test.go:16:19: unused-parameter: parameter 'host' seems to be unused, consider removing or renaming it as _ (revive)
func fakeLookupIP(host string) []net.IP {
                  ^
pkg/driver/driver.go:82:63: unused-parameter: parameter 'password' seems to be unused, consider removing or renaming it as _ (revive)
func (d *BaseDriver) ChangeDisplayPassword(_ context.Context, password string) error {
                                                              ^
pkg/networks/usernet/recoincile.go:86:4: if-return: redundant if ...; err != nil check, just return error instead. (revive)
                        if err := cmd.Start(); err != nil {
                                return err
                        }
pkg/networks/reconcile/reconcile.go:152:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
        if err := cmd.Start(); err != nil {
                return err
        }
pkg/qemu/qemu_driver.go:144:44: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (l *LimaQemuDriver) changeVNCPassword(ctx context.Context, password string) error {
                                           ^
pkg/qemu/qemu_driver.go:166:44: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (l *LimaQemuDriver) getVNCDisplayPort(ctx context.Context) (string, error) {
                                           ^
pkg/qemu/qemu_driver.go:269:41: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (l *LimaQemuDriver) DeleteSnapshot(ctx context.Context, tag string) error {
                                        ^
pkg/hostagent/api/server/server.go:17:50: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
func (b *Backend) onError(w http.ResponseWriter, r *http.Request, err error, ec int) {
                                                 ^
cmd/limactl/completion.go:8:32: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
func bashCompleteInstanceNames(cmd *cobra.Command) ([]string, cobra.ShellCompDirective) {
                               ^
cmd/limactl/edit.go:141:43: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
func editBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
                                          ^
cmd/limactl/debug.go:64:6: empty-block: this block is empty, you can remove it (revive)
        for {
        }
cmd/limactl/snapshot.go:187:47: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
func snapshotBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
                                              ^
cmd/limactl/factory-reset.go:25:25: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
func factoryResetAction(cmd *cobra.Command, args []string) error {
                        ^
cmd/limactl/validate.go:23:21: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
func validateAction(cmd *cobra.Command, args []string) error {
                    ^
cmd/limactl/factory-reset.go:59:51: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
func factoryResetBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
                                                  ^
pkg/iso9660util/iso9660util.go:5:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
        "io/ioutil"
        ^
pkg/downloader/downloader_test.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
        "io/ioutil"
        ^
pkg/vz/vz_driver_darwin.go:174:11: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (staticcheck)
                tick := time.Tick(500 * time.Millisecond)
                        ^
pkg/networks/usernet/client.go:33:10: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (staticcheck)
        tick := time.Tick(500 * time.Millisecond)
                ^
pkg/vz/vm_darwin.go:88:6: SA5003: defers in this infinite loop will never run (staticcheck)
                                        defer os.RemoveAll(pidFile)
                                        ^
```

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

.golangci.yml

@@ -69,7 +69,7 @@ linters:
   # - rowserrcheck
   # - scopelint
   # - sqlclosecheck
-  # - staticcheck
+  - staticcheck
   # - stylecheck
   # - testpackage
   # - tparallel

cmd/lima-guestagent/daemon_linux.go

@@ -24,7 +24,7 @@ func newDaemonCommand() *cobra.Command {
 	return daemonCommand
 }
 
-func daemonAction(cmd *cobra.Command, args []string) error {
+func daemonAction(cmd *cobra.Command, _ []string) error {
 	socket := "/run/lima-guestagent.sock"
 	tick, err := cmd.Flags().GetDuration("tick")
 	if err != nil {

cmd/lima-guestagent/install_systemd_linux.go

@@ -22,7 +22,7 @@ func newInstallSystemdCommand() *cobra.Command {
 	return installSystemdCommand
 }
 
-func installSystemdAction(cmd *cobra.Command, args []string) error {
+func installSystemdAction(_ *cobra.Command, _ []string) error {
 	unit, err := generateSystemdUnit()
 	if err != nil {
 		return err

cmd/limactl/completion.go

@@ -5,7 +5,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func bashCompleteInstanceNames(cmd *cobra.Command) ([]string, cobra.ShellCompDirective) {
+func bashCompleteInstanceNames(_ *cobra.Command) ([]string, cobra.ShellCompDirective) {
 	instances, err := store.Instances()
 	if err != nil {
 		return nil, cobra.ShellCompDirectiveDefault

cmd/limactl/debug.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"strconv"
+	"time"
 
 	"github.com/lima-vm/lima/pkg/hostagent/dns"
 	"github.com/sirupsen/logrus"
@@ -62,5 +63,6 @@ func debugDNSAction(cmd *cobra.Command, args []string) error {
 	}
 	logrus.Infof("Started srv %+v (UDP %d, TCP %d)", srv, udpLocalPort, tcpLocalPort)
 	for {
+		time.Sleep(time.Hour)
 	}
 }

cmd/limactl/delete.go

@@ -59,6 +59,6 @@ func deleteInstance(inst *store.Instance, force bool) error {
 	return nil
 }
 
-func deleteBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+func deleteBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
 	return bashCompleteInstanceNames(cmd)
 }

cmd/limactl/disk.go

@@ -97,7 +97,7 @@ func diskCreateAction(cmd *cobra.Command, args []string) error {
 	}
 
 	if err := qemu.CreateDataDisk(diskDir, format, int(diskSize)); err != nil {
-		return err
+		return fmt.Errorf("Failed to create %s disk in %q", format, diskDir)
 	}
 
 	return nil
@@ -297,7 +297,7 @@ $ limactl disk unlock DISK1 DISK2 ...
 	return diskUnlockCommand
 }
 
-func diskUnlockAction(cmd *cobra.Command, args []string) error {
+func diskUnlockAction(_ *cobra.Command, args []string) error {
 	for _, diskName := range args {
 		disk, err := store.InspectDisk(diskName)
 		if err != nil {

cmd/limactl/edit.go

@@ -77,7 +77,7 @@ func editAction(cmd *cobra.Command, args []string) error {
 		hdr += "# and an empty file will abort the edit.\n"
 		hdr += "\n"
 		hdr += editutil.GenerateEditorWarningHeader()
-		yBytes, err = editutil.OpenEditor(instName, yContent, hdr)
+		yBytes, err = editutil.OpenEditor(yContent, hdr)
 		if err != nil {
 			return err
 		}
@@ -138,6 +138,6 @@ func askWhetherToStart() (bool, error) {
 	return ans, nil
 }
 
-func editBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+func editBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
 	return bashCompleteInstanceNames(cmd)
 }

cmd/limactl/factory-reset.go

@@ -22,7 +22,7 @@ func newFactoryResetCommand() *cobra.Command {
 	return resetCommand
 }
 
-func factoryResetAction(cmd *cobra.Command, args []string) error {
+func factoryResetAction(_ *cobra.Command, args []string) error {
 	instName := DefaultInstanceName
 	if len(args) > 0 {
 		instName = args[0]
@@ -56,6 +56,6 @@ func factoryResetAction(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
-func factoryResetBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+func factoryResetBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
 	return bashCompleteInstanceNames(cmd)
 }

cmd/limactl/info.go

@@ -18,7 +18,7 @@ func newInfoCommand() *cobra.Command {
 	return infoCommand
 }
 
-func infoAction(cmd *cobra.Command, args []string) error {
+func infoAction(cmd *cobra.Command, _ []string) error {
 	info, err := infoutil.GetInfo()
 	if err != nil {
 		return err