Merge pull request #1545 from balajiv113/vz-version-check

AkihiroSuda · web-flow · commit d990cec3961a · 2023-05-18T03:50:19.000+09:00
vz: validate required version before hostagent start
diff --git a/pkg/vz/vz_driver_darwin.go b/pkg/vz/vz_driver_darwin.go
@@ -36,6 +36,11 @@ func New(driver *driver.BaseDriver) *LimaVzDriver {
 }
 
 func (l *LimaVzDriver) Validate() error {
+	//Calling NewEFIBootLoader to do required version check for latest APIs
+	_, err := vz.NewEFIBootLoader()
+	if errors.Is(err, vz.ErrUnsupportedOSVersion) {
+		return fmt.Errorf("VZ driver requires macOS 13 or higher to run")
+	}
 	if *l.Yaml.MountType == limayaml.NINEP {
 		return fmt.Errorf("field `mountType` must be %q or %q for VZ driver , got %q", limayaml.REVSSHFS, limayaml.VIRTIOFS, *l.Yaml.MountType)
 	}

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,11 @@ func New(driver driver.BaseDriver) LimaVzDriver {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`func (l *LimaVzDriver) Validate() error {`
	`39`	`+ //Calling NewEFIBootLoader to do required version check for latest APIs`
	`40`	`+ _, err := vz.NewEFIBootLoader()`
	`41`	`+ if errors.Is(err, vz.ErrUnsupportedOSVersion) {`
	`42`	`+ return fmt.Errorf("VZ driver requires macOS 13 or higher to run")`
	`43`	`+ }`
`39`	`44`	`if *l.Yaml.MountType == limayaml.NINEP {`
`40`	`45`	return fmt.Errorf("field `mountType` must be %q or %q for VZ driver , got %q", limayaml.REVSSHFS, limayaml.VIRTIOFS, *l.Yaml.MountType)
`41`	`46`	`}`