Code review

Signed-off-by: Jan Dubois <[email protected]>

Author: jandubois

cmd/limactl/sudoers.go

@@ -42,13 +42,16 @@ func sudoersAction(cmd *cobra.Command, args []string) error {
 }
 
 func verifySudoAccess(args []string) error {
+	config, err := networks.Config()
+	if err != nil {
+		return err
+	}
+	if err := config.Validate(); err != nil {
+		return err
+	}
 	var file string
 	switch len(args) {
 	case 0:
-		config, err := networks.Config()
-		if err != nil {
-			return err
-		}
 		file = config.Paths.Sudoers
 		if file == "" {
 			configFile, _ := networks.ConfigFile()
@@ -59,13 +62,6 @@ func verifySudoAccess(args []string) error {
 	default:
 		return errors.New("can check only a single sudoers file")
 	}
-	config, err := networks.Config()
-	if err != nil {
-		return err
-	}
-	if err := config.Validate(); err != nil {
-		return err
-	}
 	if err := config.VerifySudoAccess(file); err != nil {
 		return err
 	}

pkg/networks/config.go

@@ -45,7 +45,7 @@ func loadCache() {
 				return
 			}
 			configDir := filepath.Dir(configFile)
-			cache.err = os.MkdirAll(configDir, 0700)
+			cache.err = os.MkdirAll(configDir, 0755)
 			if cache.err != nil {
 				cache.err = fmt.Errorf("could not create %q directory: %w", configDir, cache.err)
 				return

pkg/qemu/qemu.go

@@ -260,13 +260,7 @@ func Cmdline(cfg Config) (string, []string, error) {
 	args = append(args, "-netdev", fmt.Sprintf("user,id=net0,net=%s,dhcpstart=%s,hostfwd=tcp:127.0.0.1:%d-:22",
 		qemu.SlirpNetwork, qemu.SlirpIPAddress, y.SSH.LocalPort))
 	args = append(args, "-device", "virtio-net-pci,netdev=net0,mac="+limayaml.MACAddress(cfg.InstanceDir))
-	usingVDE := false
-	for _, nw := range y.Networks {
-		if nw.VNL != "" {
-			usingVDE = true
-		}
-	}
-	if usingVDE && !strings.Contains(string(features.NetdevHelp), "vde") {
+	if len(y.Networks) > 0 && !strings.Contains(string(features.NetdevHelp), "vde") {
 		return "", nil, fmt.Errorf("netdev \"vde\" is not supported by %s ( Hint: recompile QEMU with `configure --enable-vde` )", exe)
 	}
 	for i, nw := range y.Networks {