Merge pull request #279 from AkihiroSuda/followup-276

Follow-up to `Implement starting instances from a HTTP URL ` (#276)

Author: AkihiroSuda

cmd/limactl/start.go

@@ -16,7 +16,7 @@ import (
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/containerd/containerd/identifiers"
 	"github.com/lima-vm/lima/pkg/limayaml"
-	"github.com/lima-vm/lima/pkg/networks/reconcile"
+	networks "github.com/lima-vm/lima/pkg/networks/reconcile"
 	"github.com/lima-vm/lima/pkg/osutil"
 	"github.com/lima-vm/lima/pkg/start"
 	"github.com/lima-vm/lima/pkg/store"
@@ -53,8 +53,10 @@ func loadOrCreateInstance(cmd *cobra.Command, args []string) (*store.Instance, e
 		err      error
 	)
 
+	const yBytesLimit = 4 * 1024 * 1024 // 4MiB
+
 	if argSeemsHTTPURL(arg) {
-		instName, err = instNameFromHTTPURL(arg)
+		instName, err = instNameFromURL(arg)
 		if err != nil {
 			return nil, err
 		}
@@ -64,7 +66,22 @@ func loadOrCreateInstance(cmd *cobra.Command, args []string) (*store.Instance, e
 			return nil, err
 		}
 		defer resp.Body.Close()
-		yBytes, err = io.ReadAll(resp.Body)
+		yBytes, err = readAtMaximum(resp.Body, yBytesLimit)
+		if err != nil {
+			return nil, err
+		}
+	} else if argSeemsFileURL(arg) {
+		instName, err = instNameFromURL(arg)
+		if err != nil {
+			return nil, err
+		}
+		logrus.Debugf("interpreting argument %q as a file url for instance %q", arg, instName)
+		r, err := os.Open(strings.TrimPrefix(arg, "file://"))
+		if err != nil {
+			return nil, err
+		}
+		defer r.Close()
+		yBytes, err = readAtMaximum(r, yBytesLimit)
 		if err != nil {
 			return nil, err
 		}
@@ -74,7 +91,12 @@ func loadOrCreateInstance(cmd *cobra.Command, args []string) (*store.Instance, e
 			return nil, err
 		}
 		logrus.Debugf("interpreting argument %q as a file path for instance %q", arg, instName)
-		yBytes, err = os.ReadFile(arg)
+		r, err := os.Open(arg)
+		if err != nil {
+			return nil, err
+		}
+		defer r.Close()
+		yBytes, err = readAtMaximum(r, yBytesLimit)
 		if err != nil {
 			return nil, err
 		}
@@ -269,6 +291,14 @@ func argSeemsHTTPURL(arg string) bool {
 	return true
 }
 
+func argSeemsFileURL(arg string) bool {
+	u, err := url.Parse(arg)
+	if err != nil {
+		return false
+	}
+	return u.Scheme == "file"
+}
+
 func argSeemsYAMLPath(arg string) bool {
 	if strings.Contains(arg, "/") {
 		return true
@@ -277,8 +307,8 @@ func argSeemsYAMLPath(arg string) bool {
 	return strings.HasSuffix(lower, ".yml") || strings.HasSuffix(lower, ".yaml")
 }
 
-func instNameFromHTTPURL(httpURL string) (string, error) {
-	u, err := url.Parse(httpURL)
+func instNameFromURL(urlStr string) (string, error) {
+	u, err := url.Parse(urlStr)
 	if err != nil {
 		return "", err
 	}
@@ -299,3 +329,17 @@ func startBashComplete(cmd *cobra.Command, args []string, toComplete string) ([]
 	instances, _ := bashCompleteInstanceNames(cmd)
 	return instances, cobra.ShellCompDirectiveDefault
 }
+
+func readAtMaximum(r io.Reader, n int64) ([]byte, error) {
+	lr := &io.LimitedReader{
+		R: r,
+		N: n,
+	}
+	b, err := io.ReadAll(lr)
+	if err != nil {
+		if errors.Is(err, io.EOF) && lr.N <= 0 {
+			err = fmt.Errorf("exceeded the limit (%d bytes): %w", n, err)
+		}
+	}
+	return b, err
+}