driver(internal): fix CI checks and lint errors

Signed-off-by: Ansuman Sahoo <[email protected]>

Author: unsuman

pkg/builtins/drivers.go

@@ -4,6 +4,7 @@
 package builtins
 
 import (
+	// Import all built-in drivers to register them in the registry.
 	_ "github.com/lima-vm/lima/pkg/qemu"
 	_ "github.com/lima-vm/lima/pkg/vz"
 	_ "github.com/lima-vm/lima/pkg/wsl2"

pkg/driver/driver.go

@@ -10,7 +10,7 @@ import (
 	"github.com/lima-vm/lima/pkg/store"
 )
 
-// Basic lifecycle operations
+// Lifecycle defines basic lifecycle operations.
 type Lifecycle interface {
 	// Validate returns error if the current driver isn't support for given config
 	Validate() error
@@ -36,7 +36,7 @@ type Lifecycle interface {
 	Stop(_ context.Context) error
 }
 
-// GUI-related operations
+// GUI defines GUI-related operations.
 type GUI interface {
 	// CanRunGUI returns bool to indicate if the hostagent need to run GUI synchronously
 	CanRunGUI() bool
@@ -49,21 +49,21 @@ type GUI interface {
 	GetDisplayConnection(ctx context.Context) (string, error)
 }
 
-// Snapshot operations
+// Snapshot defines operations for managing snapshots.
 type Snapshot interface {
 	CreateSnapshot(ctx context.Context, tag string) error
 	ApplySnapshot(ctx context.Context, tag string) error
 	DeleteSnapshot(ctx context.Context, tag string) error
 	ListSnapshots(ctx context.Context) (string, error)
 }
 
-// Registration operations
+// Registration defines operations for registering and unregistering the driver instance.
 type Registration interface {
 	Register(ctx context.Context) error
 	Unregister(ctx context.Context) error
 }
 
-// Guest agent operations
+// GuestAgent defines operations for the guest agent.
 type GuestAgent interface {
 	// ForwardGuestAgent returns if the guest agent sock needs forwarding by host agent.
 	ForwardGuestAgent() bool
@@ -76,7 +76,7 @@ type Plugin interface {
 	// Name returns the name of the driver
 	Name() string
 
-	// NewDriver returns a new driver instance. Only to be used to embed internal drivers
+	// SetConfig sets the configuration for the instance.
 	SetConfig(inst *store.Instance, sshLocalPort int)
 }
 

pkg/driverutil/driverutil.go

@@ -11,7 +11,7 @@ import (
 	"github.com/lima-vm/lima/pkg/store"
 )
 
-// CreateTargetDriverInstance creates the appropriate driver for an instance
+// CreateTargetDriverInstance creates the appropriate driver for an instance.
 func CreateTargetDriverInstance(inst *store.Instance, sshLocalPort int) (driver.Driver, error) {
 	limaDriver := inst.Config.VMType
 	driver, exists := registry.DefaultRegistry.Get(string(*limaDriver))

pkg/driverutil/instance.go

@@ -9,8 +9,8 @@ import (
 
 	"github.com/sirupsen/logrus"
 
-	"github.com/lima-vm/lima/pkg/driverutil"
 	"github.com/lima-vm/lima/pkg/limayaml"
+	"github.com/lima-vm/lima/pkg/registry"
 	"github.com/lima-vm/lima/pkg/store/dirnames"
 	"github.com/lima-vm/lima/pkg/templatestore"
 	"github.com/lima-vm/lima/pkg/usrlocalsharelima"
@@ -45,7 +45,7 @@ func New() (*LimaInfo, error) {
 	info := &LimaInfo{
 		Version:         version.Version,
 		DefaultTemplate: y,
-		VMTypes:         driverutil.AvailableDrivers(),
+		VMTypes:         registry.DefaultRegistry.List(),
 		GuestAgents:     make(map[limayaml.Arch]GuestAgent),
 	}
 	info.Templates, err = templatestore.Templates()