Fix SSH command escaping (addresses #632)

Signed-off-by: Ryan Lester <[email protected]>

Author: buu700

cmd/limactl/shell.go

@@ -110,7 +110,10 @@ func shellAction(cmd *cobra.Command, args []string) error {
 
 	script := fmt.Sprintf("%s ; exec bash --login", changeDirCmd)
 	if len(args) > 1 {
-		script += fmt.Sprintf(" -c %q", shellescape.QuoteCommand(args[1:]))
+		script += fmt.Sprintf(
+			" -c %s",
+			shellescape.Quote(shellescape.QuoteCommand(args[1:])),
+		)
 	}
 
 	arg0, err := exec.LookPath("ssh")

hack/test-example.sh

@@ -132,6 +132,12 @@ if [ "$got" != "$expected" ]; then
 	exit 1
 fi
 
+INFO "Testing limactl command with escaped characters"
+limactl shell "$NAME" bash -c "$(echo -e '\n\techo foo\n\techo bar')"
+
+INFO "Testing limactl command with quotes"
+limactl shell "$NAME" bash -c "echo 'foo \"bar\"'"
+
 if [[ -n ${CHECKS["systemd"]} ]]; then
 	set -x
 	if ! limactl shell "$NAME" systemctl is-system-running --wait; then