From fadc39bcf763f8cd7bfedd21dbf34e3e748212f5 Mon Sep 17 00:00:00 2001 From: Nir Soffer Date: Sun, 6 Jul 2025 15:10:09 +0300 Subject: [PATCH] guestagent: Fix isEmptyEvent check The intention seems to be checking if an event is equal to empty event, ignoring the event time, by copying the event and setting its time to nil. However instead of copying the event, we use the same object and set the event time to nil. I don't know if this caused a user visible problem, but it likely log wrong event time if we log the event. Signed-off-by: Nir Soffer --- pkg/guestagent/guestagent_linux.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/guestagent/guestagent_linux.go b/pkg/guestagent/guestagent_linux.go index 40881adb860..0bcd49efa49 100644 --- a/pkg/guestagent/guestagent_linux.go +++ b/pkg/guestagent/guestagent_linux.go @@ -191,9 +191,8 @@ func (a *agent) collectEvent(ctx context.Context, st eventState) (*api.Event, ev func isEventEmpty(ev *api.Event) bool { empty := &api.Event{} - copied := ev - copied.Time = nil - return reflect.DeepEqual(empty, copied) + empty.Time = ev.Time + return reflect.DeepEqual(empty, ev) } func (a *agent) Events(ctx context.Context, ch chan *api.Event) {