Skip to content

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Jul 16, 2025

This PR enables protolint for checking .proto files and fixes appeared lint issues. The linter's config is default except the MAX_LINE_LENGTH = 100 (default 80).

To install locally:

go install github.com/yoheimuta/protolint/cmd/protolint@latest

or

brew tap yoheimuta/protolint
brew install protolint

Example of the lint violation:

image

@alexandear alexandear force-pushed the chore/enable-protolint branch from 1579a11 to 3452401 Compare July 16, 2025 14:13
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 16, 2025
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Jul 16, 2025
@alexandear alexandear force-pushed the chore/enable-protolint branch from 3452401 to a8c0c86 Compare July 16, 2025 15:41
@alexandear alexandear changed the title CI: enable protolint to check proto files Fix proto style issues; enable protolint Jul 16, 2025
@alexandear alexandear requested a review from AkihiroSuda July 16, 2025 15:45
@AkihiroSuda
Copy link
Member

Needs rebase

@alexandear alexandear force-pushed the chore/enable-protolint branch from a8c0c86 to 938b42b Compare July 16, 2025 16:30
@alexandear alexandear force-pushed the chore/enable-protolint branch from 938b42b to e47c240 Compare July 16, 2025 16:31
@alexandear
Copy link
Member Author

Needs rebase

Done

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 05f99f6 into lima-vm:master Jul 17, 2025
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants