Skip to content

Commit 9fbceb3

Browse files
committed
Don't check for NULL before free
free() is documented to do noting if the pointer is NULL, no need to complicated the code. Signed-off-by: Nir Soffer <[email protected]>
1 parent e34bfd5 commit 9fbceb3

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

cli.c

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -241,21 +241,13 @@ struct cli_options *cli_options_parse(int argc, char *argv[]) {
241241
void cli_options_destroy(struct cli_options *x) {
242242
if (x == NULL)
243243
return;
244-
if (x->socket_group != NULL)
245-
free(x->socket_group);
246-
if (x->socket_path != NULL)
247-
free(x->socket_path);
248-
if (x->vmnet_interface != NULL)
249-
free(x->vmnet_interface);
250-
if (x->vmnet_gateway != NULL)
251-
free(x->vmnet_gateway);
252-
if (x->vmnet_dhcp_end != NULL)
253-
free(x->vmnet_dhcp_end);
254-
if (x->vmnet_mask != NULL)
255-
free(x->vmnet_mask);
256-
if (x->vmnet_nat66_prefix != NULL)
257-
free(x->vmnet_nat66_prefix);
258-
if (x->pidfile != NULL)
259-
free(x->pidfile);
244+
free(x->socket_group);
245+
free(x->socket_path);
246+
free(x->vmnet_interface);
247+
free(x->vmnet_gateway);
248+
free(x->vmnet_dhcp_end);
249+
free(x->vmnet_mask);
250+
free(x->vmnet_nat66_prefix);
251+
free(x->pidfile);
260252
free(x);
261253
}

0 commit comments

Comments
 (0)