Add strconv.ParseInt error handling

dieselburner · limdingwen · commit 73f4e3f4c94b · 2025-08-07T13:49:07.000+08:00
diff --git a/src/settings.go b/src/settings.go
@@ -60,7 +60,10 @@ func (settings *Settings) int64FlagEnv(p *int64, name string, env string, value
 	flag.Int64Var(p, name, value, usage+" (env "+env+")")
 	val := os.Getenv(env)
 	if val != "" {
-		i, _ := strconv.ParseInt(val, 10, 0)
+		i, err := strconv.ParseInt(val, 10, 0)
+		if err != nil {
+			log.Fatal(err)
+		}
 		*p = i
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,10 @@ func (settings Settings) int64FlagEnv(p int64, name string, env string, value`
`60`	`60`	`flag.Int64Var(p, name, value, usage+" (env "+env+")")`
`61`	`61`	`val := os.Getenv(env)`
`62`	`62`	`if val != "" {`
`63`		`- i, _ := strconv.ParseInt(val, 10, 0)`
	`63`	`+ i, err := strconv.ParseInt(val, 10, 0)`
	`64`	`+ if err != nil {`
	`65`	`+ log.Fatal(err)`
	`66`	`+ }`
`64`	`67`	`*p = i`
`65`	`68`	`}`
`66`	`69`	`}`