fix(lvp): skip validation for null and empty values

Author: jcabannes

lvp/README.md

@@ -68,11 +68,12 @@ This will validate that the value is one of: `ACTIVE`, `INACTIVE`, `SUSPENDED` o
 * The plugin retrieves the value to validate from the context (as defined by the hosting engine).
 * It checks whether the value is present in the configured `allowedValues` list.
 * The comparison is **case-sensitive**.
-* If the value is `null` or not found in the list, a validation error is returned.
+* If the value is not in the list, a validation error is returned.
+* If the value is null or an empty string no error is returned, this checks should be done by the `RequiredValidationPlugin` if needed.
 
 ## 🧷 Notes
 
 * All values in the `allowedValues` array are treated as strings.
 * The validation is **case-sensitive** (e.g., `"ACTIVE"` ≠ `"active"`).
 * If the `allowedValues` option is missing or invalid, a configuration error will be raised at startup.
-* `null` values and empty strings are rejected by the validation.
+* `null` values and empty strings are accepted by the validation.

lvp/src/main/java/io/github/linagora/linid/im/lvp/ListValidationPlugin.java

@@ -66,6 +66,10 @@ public Optional<I18nMessage> validate(
 
     Map<String, Object> options = configuration.getOptions();
 
+    if (value == null || value.toString().isEmpty()) {
+      return Optional.empty();
+    }
+
     if (!options.containsKey(ALLOWED_VALUES)) {
       throw new ApiException(
           500,
@@ -84,7 +88,7 @@ public Optional<I18nMessage> validate(
             )
         ));
 
-    if (value == null || !allowedValues.contains(value.toString())) {
+    if (!allowedValues.contains(value.toString())) {
       return Optional.of(I18nMessage.of("error.plugin.listValidation.invalid.value"));
     }
 

lvp/src/test/java/io/github/linagora/linid/im/lvp/ListValidationPluginTest.java

@@ -56,7 +56,7 @@ void testValidateMissingAllowedValuesOption() {
     var configuration = new ValidationConfiguration();
 
     ApiException exception =
-        assertThrows(ApiException.class, () -> plugin.validate(configuration, ""));
+        assertThrows(ApiException.class, () -> plugin.validate(configuration, "test"));
 
     assertEquals(500, exception.getStatusCode());
     assertEquals("error.plugin.default.missing.option", exception.getError().key());
@@ -70,39 +70,35 @@ void testValidateInvalidAllowedValuesOption() {
     var configuration = new ValidationConfiguration();
     configuration.addOption("allowedValues", "invalid");
     ApiException exception =
-        assertThrows(ApiException.class, () -> plugin.validate(configuration, ""));
+        assertThrows(ApiException.class, () -> plugin.validate(configuration, "test"));
 
     assertEquals(500, exception.getStatusCode());
     assertEquals("error.plugin.default.invalid.option", exception.getError().key());
     assertEquals(Map.of("option", "allowedValues"), exception.getError().context());
   }
 
   @Test
-  @DisplayName("test validate: should return message on null value")
+  @DisplayName("test validate: should accept null value")
   void testValidateNullValue() {
     var plugin = new ListValidationPlugin();
     var configuration = new ValidationConfiguration();
-    configuration.addOption("allowedValues", new String[] {"TEST"});
 
     var error = plugin.validate(configuration, null);
 
     assertNotNull(error);
-    assertTrue(error.isPresent());
-    assertEquals("error.plugin.listValidation.invalid.value", error.get().key());
+    assertTrue(error.isEmpty());
   }
 
   @Test
-  @DisplayName("test validate: should return message on empty string value")
+  @DisplayName("test validate: should accept empty string value")
   void testValidateEmptyStringValue() {
     var plugin = new ListValidationPlugin();
     var configuration = new ValidationConfiguration();
-    configuration.addOption("allowedValues", new String[] {"TEST"});
 
     var error = plugin.validate(configuration, "");
 
     assertNotNull(error);
-    assertTrue(error.isPresent());
-    assertEquals("error.plugin.listValidation.invalid.value", error.get().key());
+    assertTrue(error.isEmpty());
   }
 
   @Test