fix: return 404 on non-existence i18n file

Author: Zorin95670

src/main/java/io/github/linagora/linid/im/i18n/service/I18nServiceImpl.java

@@ -26,6 +26,7 @@
 
 package io.github.linagora.linid.im.i18n.service;
 
+import io.github.linagora.linid.im.corelib.exception.ApiException;
 import io.github.linagora.linid.im.corelib.i18n.I18nMessage;
 import io.github.linagora.linid.im.corelib.i18n.I18nService;
 import io.github.linagora.linid.im.i18n.collector.I18nMergeCollector;
@@ -89,7 +90,14 @@ public List<String> getLanguages() {
 
   @Override
   public Map<String, String> getTranslations(String language) {
-    return languages.getOrDefault(language, Map.of());
+    if (languages.containsKey(language)) {
+      return languages.get(language);
+    }
+
+    throw new ApiException(404, I18nMessage.of(
+        "error.router.unknown.route",
+        Map.of("route", String.format("/i18n/%s.json", language))
+    ));
   }
 
   @Override

src/test/java/io/github/linagora/linid/im/i18n/service/I18nServiceImplTest.java

@@ -27,7 +27,10 @@
 package io.github.linagora.linid.im.i18n.service;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import io.github.linagora.linid.im.corelib.exception.ApiException;
 import io.github.linagora.linid.im.corelib.i18n.I18nMessage;
 import io.github.linagora.linid.im.i18n.loader.I18nSourceLoader;
 import java.util.List;
@@ -87,10 +90,14 @@ void testGetTranslationsValidLanguage() {
   @DisplayName("test getTranslations: should return empty translations on invalid language")
   void testGetTranslationsInvalidLanguage() {
     service.run();
-    assertEquals(
-        Map.of(),
-        service.getTranslations("test")
-    );
+
+    ApiException exception = assertThrows(ApiException.class, () -> {
+      service.getTranslations("test");
+    });
+
+    assertEquals(404, exception.getStatusCode());
+    assertEquals("error.router.unknown.route", exception.getError().key());
+    assertEquals("/i18n/test.json", exception.getError().context().getOrDefault("route", ""));
   }
 
   @Test