Skip to content

Commit 391f304

Browse files
committed
fix: Prefer reusing AppBaseException instead of redefining the exception contract CacheException and RemoteException
1 parent dd426d4 commit 391f304

File tree

139 files changed

+344
-325
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

139 files changed

+344
-325
lines changed

lib/features/base/base_controller.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ import 'package:tmail_ui_user/features/push_notification/presentation/services/f
5656
import 'package:tmail_ui_user/features/push_notification/presentation/services/fcm_service.dart';
5757
import 'package:tmail_ui_user/main/bindings/network/binding_tag.dart';
5858
import 'package:tmail_ui_user/main/error/capability_validator.dart';
59-
import 'package:tmail_ui_user/main/exceptions/remote_exception.dart';
59+
import 'package:tmail_ui_user/main/exceptions/remote/authentication_exception.dart';
60+
import 'package:tmail_ui_user/main/exceptions/remote/method_level_exception.dart';
61+
import 'package:tmail_ui_user/main/exceptions/remote/network_exception.dart';
6062
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';
6163
import 'package:tmail_ui_user/main/routes/app_routes.dart';
6264
import 'package:tmail_ui_user/main/routes/route_navigation.dart';
@@ -372,7 +374,7 @@ abstract class BaseController extends GetxController
372374
await LocalNotificationManager.instance.setUp(groupId: session.username.value);
373375
}
374376
} else {
375-
throw NotSupportFCMException();
377+
throw const NotSupportFCMException();
376378
}
377379
} catch(e) {
378380
logWarning('$runtimeType::injectFCMBindings(): exception: $e');
@@ -604,7 +606,7 @@ abstract class BaseController extends GetxController
604606

605607
final exception = failure.exception;
606608
final errorMessage = exception is MethodLevelErrors && exception.message != null
607-
? AppLocalizations.of(currentContext!).unexpectedError('${exception.message!}')
609+
? AppLocalizations.of(currentContext!).unexpectedError(exception.message!)
608610
: AppLocalizations.of(currentContext!).unknownError;
609611

610612
appToast.showToastMessageWithMultipleActions(

lib/features/base/reloadable/reloadable_controller.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import 'package:tmail_ui_user/features/login/domain/usecases/get_oidc_user_info_
2323
import 'package:tmail_ui_user/features/login/domain/usecases/update_account_cache_interactor.dart';
2424
import 'package:tmail_ui_user/features/manage_account/presentation/vacation/vacation_interactors_bindings.dart';
2525
import 'package:tmail_ui_user/main/error/capability_validator.dart';
26-
import 'package:tmail_ui_user/main/exceptions/remote_exception.dart';
26+
import 'package:tmail_ui_user/main/exceptions/remote/authentication_exception.dart';
2727
import 'package:tmail_ui_user/main/utils/app_config.dart';
2828

2929
abstract class ReloadableController extends BaseController {

lib/features/caching/clients/hive_cache_version_client.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:shared_preferences/shared_preferences.dart';
22
import 'package:tmail_ui_user/features/caching/clients/cache_version_client.dart';
3-
import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart';
3+
import 'package:tmail_ui_user/main/exceptions/thrower/exception_thrower.dart';
44

55
class HiveCacheVersionClient extends CacheVersionClient {
66

lib/features/cleanup/data/datasource_impl/cleanup_datasource_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'package:tmail_ui_user/features/cleanup/domain/model/recent_login_url_cle
88
import 'package:tmail_ui_user/features/cleanup/domain/model/recent_login_username_cleanup_rule.dart';
99
import 'package:tmail_ui_user/features/cleanup/domain/model/recent_search_cleanup_rule.dart';
1010
import 'package:tmail_ui_user/features/thread/data/local/email_cache_manager.dart';
11-
import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart';
11+
import 'package:tmail_ui_user/main/exceptions/thrower/exception_thrower.dart';
1212

1313
class CleanupDataSourceImpl extends CleanupDataSource {
1414

lib/features/cleanup/presentation/cleanup_bindings.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import 'package:tmail_ui_user/features/cleanup/domain/usecases/cleanup_recent_lo
1313
import 'package:tmail_ui_user/features/cleanup/domain/usecases/cleanup_recent_login_username_interactor.dart';
1414
import 'package:tmail_ui_user/features/cleanup/domain/usecases/cleanup_recent_search_cache_interactor.dart';
1515
import 'package:tmail_ui_user/features/thread/data/local/email_cache_manager.dart';
16-
import 'package:tmail_ui_user/main/exceptions/cache_exception_thrower.dart';
16+
import 'package:tmail_ui_user/main/exceptions/thrower/cache_exception_thrower.dart';
1717

1818
class CleanupBindings extends InteractorsBindings {
1919

lib/features/composer/data/datasource_impl/composer_datasource_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import 'package:core/core.dart';
33
import 'package:model/upload/file_info.dart';
44
import 'package:tmail_ui_user/features/composer/data/datasource/composer_datasource.dart';
5-
import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart';
5+
import 'package:tmail_ui_user/main/exceptions/thrower/exception_thrower.dart';
66

77
class ComposerDataSourceImpl extends ComposerDataSource {
88

lib/features/composer/data/datasource_impl/contact_datasource_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:contacts_service/contacts_service.dart' as contact_service;
33
import 'package:get/get.dart';
44
import 'package:model/model.dart';
55
import 'package:tmail_ui_user/features/composer/data/datasource/contact_datasource.dart';
6-
import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart';
6+
import 'package:tmail_ui_user/main/exceptions/thrower/exception_thrower.dart';
77

88
class ContactDataSourceImpl extends ContactDataSource {
99

lib/features/composer/domain/usecases/create_new_and_save_email_to_drafts_interactor.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'package:tmail_ui_user/features/composer/domain/state/update_email_drafts
1212
import 'package:tmail_ui_user/features/composer/presentation/model/create_email_request.dart';
1313
import 'package:tmail_ui_user/features/email/domain/exceptions/email_exceptions.dart';
1414
import 'package:tmail_ui_user/features/email/domain/repository/email_repository.dart';
15-
import 'package:tmail_ui_user/main/exceptions/remote_exception.dart';
15+
import 'package:tmail_ui_user/main/exceptions/remote/unknown_remote_exception.dart';
1616

1717
class CreateNewAndSaveEmailToDraftsInteractor {
1818
final EmailRepository _emailRepository;
@@ -69,7 +69,7 @@ class CreateNewAndSaveEmailToDraftsInteractor {
6969
}
7070
} catch (e) {
7171
logWarning('CreateNewAndSaveEmailToDraftsInteractor::execute: Exception: $e');
72-
if (e is UnknownError && e.message is List<SavingEmailToDraftsCanceledException>) {
72+
if (e is UnknownRemoteException && e.message is List<SavingEmailToDraftsCanceledException>) {
7373
if (createEmailRequest.draftsEmailId == null) {
7474
yield dartz.Left<Failure, Success>(SaveEmailAsDraftsFailure(SavingEmailToDraftsCanceledException()));
7575
} else {

lib/features/composer/domain/usecases/create_new_and_send_email_interactor.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import 'package:tmail_ui_user/features/composer/presentation/model/create_email_
1515
import 'package:tmail_ui_user/features/email/domain/exceptions/email_exceptions.dart';
1616
import 'package:tmail_ui_user/features/email/domain/repository/email_repository.dart';
1717
import 'package:tmail_ui_user/features/sending_queue/presentation/model/sending_email_arguments.dart';
18-
import 'package:tmail_ui_user/main/exceptions/remote_exception.dart';
18+
import 'package:tmail_ui_user/main/exceptions/remote/unknown_remote_exception.dart';
1919

2020
class CreateNewAndSendEmailInteractor {
2121
final EmailRepository _emailRepository;
@@ -66,7 +66,7 @@ class CreateNewAndSendEmailInteractor {
6666
}
6767
} catch (e) {
6868
logWarning('CreateNewAndSendEmailInteractor::execute: Exception: $e');
69-
if (e is UnknownError && e.message is List<SendingEmailCanceledException>) {
69+
if (e is UnknownRemoteException && e.message is List<SendingEmailCanceledException>) {
7070
yield dartz.Left<Failure, Success>(SendEmailFailure(
7171
exception: SendingEmailCanceledException(),
7272
session: sendingEmailArguments?.session,

lib/features/composer/presentation/composer_bindings.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ import 'package:tmail_ui_user/features/upload/data/network/file_uploader.dart';
7070
import 'package:tmail_ui_user/features/upload/domain/usecases/local_file_picker_interactor.dart';
7171
import 'package:tmail_ui_user/features/upload/domain/usecases/local_image_picker_interactor.dart';
7272
import 'package:tmail_ui_user/features/upload/presentation/controller/upload_controller.dart';
73-
import 'package:tmail_ui_user/main/exceptions/cache_exception_thrower.dart';
74-
import 'package:tmail_ui_user/main/exceptions/remote_exception_thrower.dart';
73+
import 'package:tmail_ui_user/main/exceptions/thrower/cache_exception_thrower.dart';
74+
import 'package:tmail_ui_user/main/exceptions/thrower/remote_exception_thrower.dart';
7575
import 'package:tmail_ui_user/main/utils/ios_sharing_manager.dart';
7676
import 'package:uuid/uuid.dart';
7777

0 commit comments

Comments
 (0)