Correct abstraction Setup

Author: bartTC

qrcode/image/base.py

@@ -12,7 +12,7 @@
 DrawerAliases = dict[str, tuple[type[QRModuleDrawer], dict[str, Any]]]
 
 
-class BaseImage:
+class BaseImage(abc.ABC):
     """
     Base QRCode image output class.
     """

qrcode/image/styledpil.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from typing import overload
+
 import qrcode.image.base
 from PIL import Image
 from qrcode.image.styles.colormasks import QRColorMask, SolidFillColorMask
@@ -69,6 +71,12 @@ def __init__(self, *args, **kwargs):
 
         super().__init__(*args, **kwargs)
 
+    @overload
+    def drawrect(self, row, col):
+        """
+        Not used.
+        """
+
     def new_image(self, **kwargs):
         mode = (
             "RGBA"

qrcode/image/svg.py

@@ -28,6 +28,12 @@ def __init__(self, *args, **kwargs):
         # Save the unit size, for example the default box_size of 10 is '1mm'.
         self.unit_size = self.units(self.box_size)
 
+    @overload
+    def drawrect(self, row, col):
+        """
+        Not used.
+        """
+
     @overload
     def units(self, pixels: Union[int, Decimal], text: Literal[False]) -> Decimal: ...
 

qrcode/tests/test_qrcode.py

@@ -131,6 +131,7 @@ def test_qrcode_factory():
     class MockFactory(BaseImage):
         drawrect = mock.Mock()
         new_image = mock.Mock()
+        save = mock.Mock()
 
     qr = qrcode.QRCode(image_factory=MockFactory)
     qr.add_data(UNICODE_TEXT)