Refactor temporary file handling in tests and simplify deprecation test structure

Author: bartTC

qrcode/tests/conftest.py

@@ -19,7 +19,6 @@ def dummy_image() -> tempfile.NamedTemporaryFile:
     dummy_image = Image.new("RGBA", (1, 1), (255, 0, 0, 255))
 
     # Save the image to a temporary file
-    with tempfile.NamedTemporaryFile(suffix=".png", delete=False) as temp_file:
+    with tempfile.NamedTemporaryFile(suffix=".png", delete=True) as temp_file:
         dummy_image.save(temp_file.name)
-
-    return temp_file
+        yield temp_file

qrcode/tests/test_deprecation.py

@@ -27,7 +27,9 @@ def test_moduledrawer_import() -> None:
         DeprecationWarning,
         match="Importing 'SquareModuleDrawer' directly from this module is deprecated.",
     ):
-        from qrcode.image.styles.moduledrawers import SquareModuleDrawer
+        from qrcode.image.styles.moduledrawers import (
+            SquareModuleDrawer,
+        )
 
 
 @pytest.mark.skipif(PIL_AVAILABLE, reason="PIL is installed")
@@ -94,21 +96,16 @@ def test_styledpilimage_embeded_parameters(dummy_image: NamedTemporaryFile) -> N
         "qrcode_modules": 1,
     }
 
-    try:
-        # Test with embeded_image_path parameter
-        with pytest.warns(
-            DeprecationWarning, match="The 'embeded_\\*' parameters are deprecated."
-        ):
-            StyledPilImage(embeded_image_path=dummy_image.name, **styled_kwargs)
-
-        # Test with embeded_image parameter
-        embedded_img = Image.open(dummy_image.name)
+    # Test with embeded_image_path parameter
+    with pytest.warns(
+        DeprecationWarning, match="The 'embeded_\\*' parameters are deprecated."
+    ):
+        StyledPilImage(embeded_image_path=dummy_image.name, **styled_kwargs)
 
-        with pytest.warns(
-            DeprecationWarning, match="The 'embeded_\\*' parameters are deprecated."
-        ):
-            StyledPilImage(embeded_image=embedded_img, **styled_kwargs)
+    # Test with embeded_image parameter
+    embedded_img = Image.open(dummy_image.name)
 
-    # Make sure the temporary image is always deleted after the testrun.
-    finally:
-        Path(dummy_image.name).unlink(missing_ok=True)
+    with pytest.warns(
+        DeprecationWarning, match="The 'embeded_\\*' parameters are deprecated."
+    ):
+        StyledPilImage(embeded_image=embedded_img, **styled_kwargs)