Skip to content

Commit 4ecfd8d

Browse files
committed
Change type of URL field to URI #306
1 parent f8dfd05 commit 4ecfd8d

File tree

7 files changed

+20
-10
lines changed

7 files changed

+20
-10
lines changed

line-bot-model/src/main/java/com/linecorp/bot/model/event/message/VideoMessageContent.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.bot.model.event.message;
1818

19+
import java.net.URI;
20+
1921
import com.fasterxml.jackson.annotation.JsonTypeName;
2022
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2123
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
@@ -36,6 +38,6 @@ public static class VideoMessageContentBuilder {
3638
}
3739

3840
String id;
39-
String url;
41+
URI url;
4042
ContentProvider contentProvider;
4143
}

line-bot-model/src/main/java/com/linecorp/bot/model/manageaudience/AudienceGroup.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.bot.model.manageaudience;
1818

19+
import java.net.URI;
20+
1921
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2022
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
2123

@@ -74,7 +76,7 @@ public class AudienceGroup {
7476
* The URL that was specified when the audience was created. This is only included when
7577
* audienceGroups[].type is CLICK.
7678
*/
77-
String clickUrl;
79+
URI clickUrl;
7880

7981
/**
8082
* The value specified when the audience for uploading user IDs was created, determining which type of

line-bot-model/src/main/java/com/linecorp/bot/model/manageaudience/request/CreateClickBasedAudienceGroupRequest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.bot.model.manageaudience.request;
1818

19+
import java.net.URI;
20+
1921
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2022
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
2123

@@ -48,7 +50,7 @@ public class CreateClickBasedAudienceGroupRequest {
4850
*
4951
* <p>Max: 2,000 characters
5052
*/
51-
String clickUrl;
53+
URI clickUrl;
5254

5355
@JsonPOJOBuilder(withPrefix = "")
5456
public static class CreateClickAudienceGroupRequestBuilder {

line-bot-model/src/main/java/com/linecorp/bot/model/manageaudience/response/CreateClickBasedAudienceGroupResponse.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.bot.model.manageaudience.response;
1818

19+
import java.net.URI;
20+
1921
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2022
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
2123

@@ -57,7 +59,7 @@ public class CreateClickBasedAudienceGroupResponse {
5759
/**
5860
* The URL that was specified when the audience was created.
5961
*/
60-
String clickUrl;
62+
URI clickUrl;
6163

6264
@JsonPOJOBuilder(withPrefix = "")
6365
public static class CreateClickBasedAudienceGroupResponseBuilder {

line-bot-model/src/main/java/com/linecorp/bot/model/message/flex/component/Icon.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.bot.model.message.flex.component;
1818

19+
import java.net.URI;
20+
1921
import com.fasterxml.jackson.annotation.JsonCreator;
2022
import com.fasterxml.jackson.annotation.JsonInclude;
2123
import com.fasterxml.jackson.annotation.JsonInclude.Include;
@@ -45,7 +47,7 @@ public enum IconAspectRatio {
4547
R3TO1,
4648
}
4749

48-
String url;
50+
URI url;
4951

5052
FlexFontSize size;
5153

@@ -65,7 +67,7 @@ public enum IconAspectRatio {
6567

6668
@JsonCreator
6769
public Icon(
68-
@JsonProperty("url") String url,
70+
@JsonProperty("url") URI url,
6971
@JsonProperty("size") FlexFontSize size,
7072
@JsonProperty("aspectRatio") IconAspectRatio aspectRatio,
7173
@JsonProperty("margin") FlexMarginSize margin,

line-bot-model/src/test/java/com/linecorp/bot/model/message/ExampleFlexMessageSupplier.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,9 @@ private Box createInfoBox() {
170170

171171
private Box createReviewBox() {
172172
final Icon goldStar =
173-
Icon.builder().size(FlexFontSize.SM).url("https://example.com/gold_star.png").build();
173+
Icon.builder().size(FlexFontSize.SM).url(URI.create("https://example.com/gold_star.png")).build();
174174
final Icon grayStar =
175-
Icon.builder().size(FlexFontSize.SM).url("https://example.com/gray_star.png").build();
175+
Icon.builder().size(FlexFontSize.SM).url(URI.create("https://example.com/gray_star.png")).build();
176176
final Text point =
177177
Text.builder()
178178
.text("4.0")

sample-spring-boot-kitchensink/src/main/java/com/example/bot/spring/ExampleFlexMessageSupplier.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@ private Box createInfoBox() {
158158

159159
private Box createReviewBox() {
160160
final Icon goldStar =
161-
Icon.builder().size(FlexFontSize.SM).url("https://example.com/gold_star.png").build();
161+
Icon.builder().size(FlexFontSize.SM).url(URI.create("https://example.com/gold_star.png")).build();
162162
final Icon grayStar =
163-
Icon.builder().size(FlexFontSize.SM).url("https://example.com/gray_star.png").build();
163+
Icon.builder().size(FlexFontSize.SM).url(URI.create("https://example.com/gray_star.png")).build();
164164
final Text point =
165165
Text.builder()
166166
.text("4.0")

0 commit comments

Comments
 (0)