Skip to content

Commit 7185b90

Browse files
authored
Builder: Move required parameters to the constructor. (#1147)
1 parent 452b1f3 commit 7185b90

File tree

225 files changed

+427
-5199
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

225 files changed

+427
-5199
lines changed

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/AgeTile.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,25 +65,21 @@ public enum Age {
6565

6666
public static class Builder {
6767
private Age age;
68-
6968
private Double percentage;
7069

7170
public Builder() {}
7271

7372
public Builder age(Age age) {
7473
this.age = age;
75-
7674
return this;
7775
}
7876

7977
public Builder percentage(Double percentage) {
8078
this.percentage = percentage;
81-
8279
return this;
8380
}
8481

8582
public AgeTile build() {
86-
8783
return new AgeTile(age, percentage);
8884
}
8985
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/AppTypeTile.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,25 +51,21 @@ public enum AppType {
5151

5252
public static class Builder {
5353
private AppType appType;
54-
5554
private Double percentage;
5655

5756
public Builder() {}
5857

5958
public Builder appType(AppType appType) {
6059
this.appType = appType;
61-
6260
return this;
6361
}
6462

6563
public Builder percentage(Double percentage) {
6664
this.percentage = percentage;
67-
6865
return this;
6966
}
7067

7168
public AppTypeTile build() {
72-
7369
return new AppTypeTile(appType, percentage);
7470
}
7571
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/AreaTile.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,25 +37,21 @@ public record AreaTile(
3737

3838
public static class Builder {
3939
private String area;
40-
4140
private Double percentage;
4241

4342
public Builder() {}
4443

4544
public Builder area(String area) {
4645
this.area = area;
47-
4846
return this;
4947
}
5048

5149
public Builder percentage(Double percentage) {
5250
this.percentage = percentage;
53-
5451
return this;
5552
}
5653

5754
public AreaTile build() {
58-
5955
return new AreaTile(area, percentage);
6056
}
6157
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/ErrorDetail.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,21 @@ public record ErrorDetail(
4040

4141
public static class Builder {
4242
private String message;
43-
4443
private String property;
4544

4645
public Builder() {}
4746

4847
public Builder message(String message) {
4948
this.message = message;
50-
5149
return this;
5250
}
5351

5452
public Builder property(String property) {
5553
this.property = property;
56-
5754
return this;
5855
}
5956

6057
public ErrorDetail build() {
61-
6258
return new ErrorDetail(message, property);
6359
}
6460
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/ErrorResponse.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -46,33 +46,19 @@ public record ErrorResponse(
4646

4747
public static class Builder {
4848
private String message;
49-
50-
private boolean message$set;
51-
5249
private List<ErrorDetail> details;
5350

54-
public Builder() {}
51+
public Builder(String message) {
5552

56-
public Builder message(String message) {
5753
this.message = message;
58-
59-
this.message$set = true;
60-
61-
return this;
6254
}
6355

6456
public Builder details(List<ErrorDetail> details) {
6557
this.details = details;
66-
6758
return this;
6859
}
6960

7061
public ErrorResponse build() {
71-
72-
if (!this.message$set) {
73-
throw new IllegalStateException("'message' must be set for ErrorResponse.");
74-
}
75-
7662
return new ErrorResponse(message, details);
7763
}
7864
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/GenderTile.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,25 +51,21 @@ public enum Gender {
5151

5252
public static class Builder {
5353
private Gender gender;
54-
5554
private Double percentage;
5655

5756
public Builder() {}
5857

5958
public Builder gender(Gender gender) {
6059
this.gender = gender;
61-
6260
return this;
6361
}
6462

6563
public Builder percentage(Double percentage) {
6664
this.percentage = percentage;
67-
6865
return this;
6966
}
7067

7168
public GenderTile build() {
72-
7369
return new GenderTile(gender, percentage);
7470
}
7571
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/GetFriendsDemographicsResponse.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,57 +51,45 @@ public record GetFriendsDemographicsResponse(
5151

5252
public static class Builder {
5353
private Boolean available;
54-
5554
private List<GenderTile> genders;
56-
5755
private List<AgeTile> ages;
58-
5956
private List<AreaTile> areas;
60-
6157
private List<AppTypeTile> appTypes;
62-
6358
private List<SubscriptionPeriodTile> subscriptionPeriods;
6459

6560
public Builder() {}
6661

6762
public Builder available(Boolean available) {
6863
this.available = available;
69-
7064
return this;
7165
}
7266

7367
public Builder genders(List<GenderTile> genders) {
7468
this.genders = genders;
75-
7669
return this;
7770
}
7871

7972
public Builder ages(List<AgeTile> ages) {
8073
this.ages = ages;
81-
8274
return this;
8375
}
8476

8577
public Builder areas(List<AreaTile> areas) {
8678
this.areas = areas;
87-
8879
return this;
8980
}
9081

9182
public Builder appTypes(List<AppTypeTile> appTypes) {
9283
this.appTypes = appTypes;
93-
9484
return this;
9585
}
9686

9787
public Builder subscriptionPeriods(List<SubscriptionPeriodTile> subscriptionPeriods) {
9888
this.subscriptionPeriods = subscriptionPeriods;
99-
10089
return this;
10190
}
10291

10392
public GetFriendsDemographicsResponse build() {
104-
10593
return new GetFriendsDemographicsResponse(
10694
available, genders, ages, areas, appTypes, subscriptionPeriods);
10795
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/GetMessageEventResponse.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,33 +47,27 @@ public record GetMessageEventResponse(
4747

4848
public static class Builder {
4949
private GetMessageEventResponseOverview overview;
50-
5150
private List<GetMessageEventResponseMessage> messages;
52-
5351
private List<GetMessageEventResponseClick> clicks;
5452

5553
public Builder() {}
5654

5755
public Builder overview(GetMessageEventResponseOverview overview) {
5856
this.overview = overview;
59-
6057
return this;
6158
}
6259

6360
public Builder messages(List<GetMessageEventResponseMessage> messages) {
6461
this.messages = messages;
65-
6662
return this;
6763
}
6864

6965
public Builder clicks(List<GetMessageEventResponseClick> clicks) {
7066
this.clicks = clicks;
71-
7267
return this;
7368
}
7469

7570
public GetMessageEventResponse build() {
76-
7771
return new GetMessageEventResponse(overview, messages, clicks);
7872
}
7973
}

clients/line-bot-insight-client/src/main/java/com/linecorp/bot/insight/model/GetMessageEventResponseClick.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,49 +46,39 @@ public record GetMessageEventResponseClick(
4646

4747
public static class Builder {
4848
private Integer seq;
49-
5049
private String url;
51-
5250
private Long click;
53-
5451
private Long uniqueClick;
55-
5652
private Long uniqueClickOfRequest;
5753

5854
public Builder() {}
5955

6056
public Builder seq(Integer seq) {
6157
this.seq = seq;
62-
6358
return this;
6459
}
6560

6661
public Builder url(String url) {
6762
this.url = url;
68-
6963
return this;
7064
}
7165

7266
public Builder click(Long click) {
7367
this.click = click;
74-
7568
return this;
7669
}
7770

7871
public Builder uniqueClick(Long uniqueClick) {
7972
this.uniqueClick = uniqueClick;
80-
8173
return this;
8274
}
8375

8476
public Builder uniqueClickOfRequest(Long uniqueClickOfRequest) {
8577
this.uniqueClickOfRequest = uniqueClickOfRequest;
86-
8778
return this;
8879
}
8980

9081
public GetMessageEventResponseClick build() {
91-
9282
return new GetMessageEventResponseClick(seq, url, click, uniqueClick, uniqueClickOfRequest);
9383
}
9484
}

0 commit comments

Comments
 (0)