Skip to content

Commit 3df9255

Browse files
authored
Grant minimum permissions to github acitons workflow jobs (#1202)
## Changes Granting the minimum necessary permissions is always a good practice. There might be cases where permissions are insufficient, but since errors are very clear, I believe we can add them when a failure occurs. After merging, I will change the default of the GITHUB_ACTIONS token from read + write to read only. Then, I will run as many workflows as possible (including publish) to verify their operation. reference: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#overview
1 parent c3d6b09 commit 3df9255

File tree

7 files changed

+22
-11
lines changed

7 files changed

+22
-11
lines changed

.github/workflows/check-eol-newrelease.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
jobs:
1010
check-eol-newrelease:
1111
runs-on: ubuntu-latest
12+
permissions:
13+
contents: read
14+
issues: write
15+
if: github.repository == 'line/line-bot-sdk-nodejs'
1216
steps:
1317
- name: Check out code
1418
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/close-issue.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
permissions:
1212
issues: write
1313
pull-requests: write
14+
if: github.repository == 'line/line-bot-sdk-nodejs'
1415
steps:
1516
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
1617
with:

.github/workflows/create-draft-release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ on:
2626
jobs:
2727
validate-input:
2828
runs-on: ubuntu-latest
29+
permissions: {}
2930
steps:
3031
- name: Validate Acknowledgement
3132
if: ${{ github.event.inputs.acknowledge_draft != 'Yes' }}
@@ -41,7 +42,8 @@ jobs:
4142
create-draft-release:
4243
runs-on: ubuntu-latest
4344
needs: validate-input
44-
45+
permissions:
46+
contents: write
4547
steps:
4648
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
4749
- name: Fetch Latest Release

.github/workflows/deploy-doc.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,17 @@ on:
44
workflow_call:
55
workflow_dispatch:
66

7-
permissions:
8-
contents: read
9-
pages: write
10-
id-token: write
11-
127
concurrency:
138
group: pages
149
cancel-in-progress: false
1510

1611
jobs:
1712
build:
1813
runs-on: ubuntu-latest
14+
permissions:
15+
contents: read
16+
pages: write
17+
issues: write
1918
steps:
2019
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
2120
- uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
@@ -61,6 +60,10 @@ jobs:
6160
url: ${{ steps.deployment.outputs.page_url }}
6261
needs: [build]
6362
runs-on: ubuntu-latest
63+
permissions:
64+
pages: write
65+
id-token: write
66+
issues: write
6467
name: Deploy
6568
steps:
6669
- name: Deploy to GitHub Pages

.github/workflows/generate-code.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ jobs:
1111
tests:
1212
name: Generate OpenAPI based code
1313
runs-on: ubuntu-latest
14-
14+
permissions:
15+
contents: write
16+
pull-requests: write
1517
steps:
1618
# Setup
1719
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,11 @@ on:
1010

1111
jobs:
1212
release-package:
13+
runs-on: ubuntu-latest
1314
permissions:
1415
contents: read
1516
id-token: write
1617
issues: write
17-
18-
runs-on: ubuntu-latest
1918
steps:
2019
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
2120
# Setup .npmrc file to publish to GitHub Packages

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ on:
77

88
jobs:
99
build:
10-
1110
runs-on: ubuntu-latest
12-
11+
permissions:
12+
contents: read
1313
strategy:
1414
matrix:
1515
# https://nodejs.org/en/about/releases/

0 commit comments

Comments
 (0)