Remove unknown types from model generator (#834)

This PR removes the unknown model types generated from OpenAPI model
generator.
This ensures strict type safety and a better developer experience while
using the generated clients.

Closes : #831

Author: wolffparkinson

examples/echo-bot-ts-cjs/index.ts

@@ -27,22 +27,24 @@ const client = new messagingApi.MessagingApiClient(clientConfig);
 // Create a new Express application.
 const app: Application = express();
 
-const isTextEvent = (event: any): event is webhook.MessageEvent & { message: webhook.TextMessageContent } => {
-  return event.type === 'message' && event.message && event.message.type === 'text';
-};
-
 // Function handler to receive the text.
 const textEventHandler = async (event: webhook.Event): Promise<MessageAPIResponseBase | undefined> => {
   // Process all variables here.
-  if (!isTextEvent(event)) {
+
+  // Check if for a text message
+  if (event.type !== 'message' || event.message.type !== 'text') {
     return;
   }
 
   // Process all message related variables here.
+
+  // Check if message is repliable
+  if (!event.replyToken) return;
+  
   // Create a new message.
   // Reply to the user.
   await client.replyMessage({
-    replyToken: event.replyToken as string,
+    replyToken:event.replyToken,
     messages: [{
       type: 'text',
       text: event.message.text,

examples/echo-bot-ts-esm/index.ts

@@ -27,22 +27,25 @@ const client = new messagingApi.MessagingApiClient(clientConfig);
 // Create a new Express application.
 const app: Application = express();
 
-const isTextEvent = (event: any): event is webhook.MessageEvent & { message: webhook.TextMessageContent } => {
-  return event.type === 'message' && event.message && event.message.type === 'text';
-};
 
 // Function handler to receive the text.
 const textEventHandler = async (event: webhook.Event): Promise<MessageAPIResponseBase | undefined> => {
   // Process all variables here.
-  if (!isTextEvent(event)) {
+
+  // Check if for a text message
+  if (event.type !== 'message' || event.message.type !== 'text') {
     return;
   }
 
   // Process all message related variables here.
+
+  // Check if message is repliable
+  if (!event.replyToken) return;
+  
   // Create a new message.
   // Reply to the user.
   await client.replyMessage({
-    replyToken: event.replyToken as string,
+    replyToken:event.replyToken,
     messages: [{
       type: 'text',
       text: event.message.text,

generator/src/main/resources/line-bot-sdk-nodejs-generator/model.pebble

@@ -15,12 +15,8 @@ export type {{classname}} =
         {%- for model in model.model.discriminator.mappedModels %}
         | {{model.modelName}} // {{model.mappingName}}
         {%- endfor %}
-        | Unknown{{classname}}
 ;
 
-export type Unknown{{classname}} = {{classname}}Base & {
-    [key: string]: unknown;
-};
     {% endif -%}
 
     {% if model.model.description != null %}

lib/messaging-api/model/action.ts

@@ -29,12 +29,7 @@ export type Action =
   | MessageAction // message
   | PostbackAction // postback
   | RichMenuSwitchAction // richmenuswitch
-  | URIAction // uri
-  | UnknownAction;
-
-export type UnknownAction = ActionBase & {
-  [key: string]: unknown;
-};
+  | URIAction; // uri
 
 /**
  * Action

lib/messaging-api/model/demographicFilter.ts

@@ -23,12 +23,7 @@ export type DemographicFilter =
   | AreaDemographicFilter // area
   | GenderDemographicFilter // gender
   | OperatorDemographicFilter // operator
-  | SubscriptionPeriodDemographicFilter // subscriptionPeriod
-  | UnknownDemographicFilter;
-
-export type UnknownDemographicFilter = DemographicFilterBase & {
-  [key: string]: unknown;
-};
+  | SubscriptionPeriodDemographicFilter; // subscriptionPeriod
 
 /**
  * Demographic filter

lib/messaging-api/model/flexBoxBackground.ts

@@ -12,13 +12,7 @@
 
 import { FlexBoxLinearGradient } from "./models.js";
 
-export type FlexBoxBackground =
-  | FlexBoxLinearGradient // linearGradient
-  | UnknownFlexBoxBackground;
-
-export type UnknownFlexBoxBackground = FlexBoxBackgroundBase & {
-  [key: string]: unknown;
-};
+export type FlexBoxBackground = FlexBoxLinearGradient; // linearGradient
 
 export type FlexBoxBackgroundBase = {
   /**

lib/messaging-api/model/flexComponent.ts

@@ -29,12 +29,7 @@ export type FlexComponent =
   | FlexSeparator // separator
   | FlexSpan // span
   | FlexText // text
-  | FlexVideo // video
-  | UnknownFlexComponent;
-
-export type UnknownFlexComponent = FlexComponentBase & {
-  [key: string]: unknown;
-};
+  | FlexVideo; // video
 
 export type FlexComponentBase = {
   /**

lib/messaging-api/model/flexContainer.ts

@@ -15,12 +15,7 @@ import { FlexCarousel } from "./models.js";
 
 export type FlexContainer =
   | FlexBubble // bubble
-  | FlexCarousel // carousel
-  | UnknownFlexContainer;
-
-export type UnknownFlexContainer = FlexContainerBase & {
-  [key: string]: unknown;
-};
+  | FlexCarousel; // carousel
 
 export type FlexContainerBase = {
   /**

lib/messaging-api/model/imagemapAction.ts

@@ -19,12 +19,7 @@ import { URIImagemapAction } from "./models.js";
 export type ImagemapAction =
   | ClipboardImagemapAction // clipboard
   | MessageImagemapAction // message
-  | URIImagemapAction // uri
-  | UnknownImagemapAction;
-
-export type UnknownImagemapAction = ImagemapActionBase & {
-  [key: string]: unknown;
-};
+  | URIImagemapAction; // uri
 
 export type ImagemapActionBase = {
   /**

lib/messaging-api/model/message.ts

@@ -32,12 +32,7 @@ export type Message =
   | StickerMessage // sticker
   | TemplateMessage // template
   | TextMessage // text
-  | VideoMessage // video
-  | UnknownMessage;
-
-export type UnknownMessage = MessageBase & {
-  [key: string]: unknown;
-};
+  | VideoMessage; // video
 
 export type MessageBase = {
   /**