Skip to content

Commit adf67ab

Browse files
authored
Bye line things (#1369)
line/line-openapi#112 is a cleanup PR for line things, but it appears to break several tests by deleting this change. Let’s remove those tests beforehand. and more, this change updates our versioning in README. - We'll release changes as a patch version when we close features due to some business reasons. Note we clean up auto-generated webhook code for line things in another PR, though this PR deletes manual code.
1 parent 55a7ee2 commit adf67ab

File tree

3 files changed

+4
-109
lines changed

3 files changed

+4
-109
lines changed

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ FAQ: https://developers.line.biz/en/faq/
3939
News: https://developers.line.biz/en/news/
4040

4141
## Versioning
42-
This project respects semantic versioning
4342

44-
See http://semver.org/
43+
This project respects semantic versioning.
44+
- See https://semver.org/
45+
46+
However, if a feature that was publicly released is discontinued for business reasons and becomes completely unusable, we will release changes as a patch release.
4547

4648
## Contributing
4749

lib/types.ts

Lines changed: 0 additions & 107 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ export type WebhookEvent =
6060
| VideoPlayCompleteEvent
6161
| BeaconEvent
6262
| AccountLinkEvent
63-
| DeviceLinkEvent
64-
| DeviceUnlinkEvent
65-
| LINEThingsScenarioExecutionEvent
6663
| DeliveryEvent;
6764

6865
export type EventBase = {
@@ -270,110 +267,6 @@ export type AccountLinkEvent = ReplyableEvent & {
270267
};
271268
};
272269

273-
/**
274-
* Indicates that a LINE Things-compatible device has been linked with LINE by a user operation.
275-
* For more information, see [Receiving device link events via webhook](https://developers.line.biz/en/docs/line-things/develop-bot/#link-event).
276-
*/
277-
export type DeviceLinkEvent = ReplyableEvent & {
278-
type: "things";
279-
things: {
280-
/**
281-
* Device ID of the LINE Things-compatible device that was linked with LINE
282-
*/
283-
deviceId: string;
284-
type: "link";
285-
};
286-
};
287-
288-
/**
289-
* Indicates that a LINE Things-compatible device has been unlinked from LINE by a user operation.
290-
* For more information, see [Receiving device unlink events via webhook](https://developers.line.biz/en/docs/line-things/develop-bot/#unlink-event).
291-
*/
292-
export type DeviceUnlinkEvent = ReplyableEvent & {
293-
type: "things";
294-
things: {
295-
/**
296-
* Device ID of the LINE Things-compatible device that was unlinked with LINE
297-
*/
298-
deviceId: string;
299-
type: "unlink";
300-
};
301-
};
302-
303-
export type LINEThingsScenarioExecutionEvent = ReplyableEvent & {
304-
type: "things";
305-
things: {
306-
type: "scenarioResult";
307-
/**
308-
* Device ID of the device that executed the scenario
309-
*/
310-
deviceId: string;
311-
result: {
312-
/**
313-
* Scenario ID executed
314-
*/
315-
scenarioId: string;
316-
/**
317-
* Revision number of the scenario set containing the executed scenario
318-
*/
319-
revision: number;
320-
/**
321-
* Timestamp for when execution of scenario action started (milliseconds, LINE app time)
322-
*/
323-
startTime: number;
324-
/**
325-
* Timestamp for when execution of scenario was completed (milliseconds, LINE app time)
326-
*/
327-
endtime: number;
328-
/**
329-
* Scenario execution completion status
330-
* See also [things.resultCode definitions](https://developers.line.biz/en/reference/messaging-api/#things-resultcode).
331-
*/
332-
resultCode: "success" | "gatt_error" | "runtime_error";
333-
/**
334-
* Execution result of individual operations specified in action
335-
* Note that an array of actions specified in a scenario has the following characteristics
336-
* - The actions defined in a scenario are performed sequentially, from top to bottom.
337-
* - Each action produces some result when executed.
338-
* Even actions that do not generate data, such as `SLEEP`, return an execution result of type `void`.
339-
* The number of items in an action array may be 0.
340-
*
341-
* Therefore, things.actionResults has the following properties:
342-
* - The number of items in the array matches the number of actions defined in the scenario.
343-
* - The order of execution results matches the order in which actions are performed.
344-
* That is, in a scenario set with multiple `GATT_READ` actions,
345-
* the results are returned in the order in which each individual `GATT_READ` action was performed.
346-
* - If 0 actions are defined in the scenario, the number of items in things.actionResults will be 0.
347-
*/
348-
actionResults: Array<LINEThingsActionResult>;
349-
/**
350-
* Data contained in notification
351-
* The value is Base64-encoded binary data.
352-
* Only included for scenarios where `trigger.type = BLE_NOTIFICATION`.
353-
*/
354-
bleNotificationPayload?: string;
355-
/**
356-
* Error reason
357-
*/
358-
errorReason?: string;
359-
};
360-
};
361-
};
362-
363-
export type LINEThingsActionResult = {
364-
/**
365-
* `void`, `binary`
366-
* Depends on `type` of the executed action.
367-
* This property is always included if `things.actionResults` is not empty.
368-
*/
369-
type: "void" | "binary";
370-
/**
371-
* Base64-encoded binary data
372-
* This property is always included when `things.actionResults[].type` is `binary`.
373-
*/
374-
data?: string;
375-
};
376-
377270
/**
378271
* Completed Delivery Event
379272
* @see {@link https://developers.line.biz/en/docs/partner-docs/line-notification-messages/message-sending-complete-webhook-event/#receive-delivery-event}

scripts/apply-dependency.sh

Whitespace-only changes.

0 commit comments

Comments
 (0)