Improve query parameter test (#721)

Regardless of the implementation details, any new pattern needs thorough
validation.
By writing strict tests now, we can reduce regressions when we change
the client’s internals in the future.

follow-up: #719

Author: Yang-33

README.md

@@ -1,6 +1,7 @@
 # LINE Messaging API SDK for PHP
 
 [![Build Status](https://github.com/line/line-bot-sdk-php/actions/workflows/php-checks.yml/badge.svg?branch=master)](https://github.com/line/line-bot-sdk-php/actions)
+[![Packagist Version](https://img.shields.io/packagist/v/linecorp/line-bot-sdk)](https://packagist.org/packages/linecorp/line-bot-sdk)
 
 
 ## Introduction

test/clients/messaging-api/Api/MessagingApiApiTest.php

@@ -18,6 +18,7 @@
 namespace LINE\Tests\Clients\MessagingApi\Api;
 
 use GuzzleHttp\ClientInterface;
+use GuzzleHttp\Psr7\Query;
 use GuzzleHttp\Psr7\Request;
 use GuzzleHttp\Psr7\Response;
 use LINE\Clients\MessagingApi\Api\MessagingApiApi;
@@ -30,6 +31,7 @@
 use LINE\Clients\MessagingApi\Model\MessagingApiPagerCouponListResponse;
 use Mockery;
 use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\UriInterface;
 
 class MessagingApiApiTest extends TestCase
 {
@@ -38,6 +40,25 @@ protected function setUp(): void
         parent::setUp();
     }
 
+    private function assertQueryEquals(array $expected, UriInterface $uri): void
+    {
+        $actual = Query::parse($uri->getQuery());
+
+        $normalize = function (array &$arr): void {
+            foreach ($arr as &$v) {
+                if (is_array($v)) {
+                    sort($v);
+                }
+            }
+            ksort($arr);
+        };
+
+        $normalize($expected);
+        $normalize($actual);
+
+        $this->assertSame($expected, $actual, 'Query parameters mismatch');
+    }
+
     public function testGetFollowers(): void
     {
         $client = Mockery::mock(ClientInterface::class);
@@ -276,6 +297,11 @@ public function testListCoupon(): void
         $start = 'startToken';
         $limit = 10;
         $contentType = 'application/json';
+        $expectedQuery = [
+            'status' => $status,
+            'start'  => $start,
+            'limit'  => (string)$limit,
+        ];
         $expectedRequestBody = <<<JSON
         {
             "status": ["RUNNING", "CLOSED"],
@@ -296,14 +322,11 @@ public function testListCoupon(): void
         $client = Mockery::mock(ClientInterface::class);
         $client->shouldReceive('send')
             ->with(
-                Mockery::on(function (Request $request) use ($status, $start, $limit, $contentType) {
+                Mockery::on(function (Request $request) use ($status, $start, $limit, $contentType, $expectedQuery) {
                     $this->assertEquals('GET', $request->getMethod());
                     $this->assertStringContainsString('https://api.line.me/v2/bot/coupon?', (string)$request->getUri());
                     $this->assertEquals($contentType, $request->getHeaderLine('Content-Type'));
-                    $this->assertStringContainsString('status=RUNNING', (string)$request->getUri()->getQuery());
-                    $this->assertStringContainsString('status=CLOSED', (string)$request->getUri()->getQuery());
-                    $this->assertStringContainsString('start=startToken', (string)$request->getUri()->getQuery());
-                    $this->assertStringContainsString('limit=10', (string)$request->getUri()->getQuery());
+                    $this->assertQueryEquals($expectedQuery, $request->getUri());
                     return true;
                 }),
                 []