Merge pull request #206 from yskkin/disallow_net_connect

kimoto · web-flow · commit 30a3bc85d075 · 2020-12-16T15:11:57.000+09:00
disallow actual net connection during unit test
diff --git a/spec/line/bot/client_channel_token_spec.rb b/spec/line/bot/client_channel_token_spec.rb
@@ -10,8 +10,6 @@
 }
 EOS
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   def dummy_config
     {
diff --git a/spec/line/bot/client_get_group_or_room_member_spec.rb b/spec/line/bot/client_get_group_or_room_member_spec.rb
@@ -51,8 +51,6 @@
 }
 EOS
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   before do
   end
diff --git a/spec/line/bot/client_get_spec.rb b/spec/line/bot/client_get_spec.rb
@@ -200,8 +200,6 @@
 }
 EOS
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   before do
   end
diff --git a/spec/line/bot/client_spec.rb b/spec/line/bot/client_spec.rb
@@ -18,8 +18,6 @@ def post(url, payload, header = {})
   end
 end
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   def dummy_config
     {
diff --git a/spec/line/bot/link_token_spec.rb b/spec/line/bot/link_token_spec.rb
@@ -8,8 +8,6 @@
 }
 EOS
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   let(:client) do
     dummy_config = {
diff --git a/spec/line/bot/rich_menu_spec.rb b/spec/line/bot/rich_menu_spec.rb
@@ -41,8 +41,6 @@
 RICH_MENU_IMAGE_FILE_PATH = 'spec/fixtures/line/bot/rich_menu_01.png'
 RICH_MENU_INVALID_FILE_EXTENSION_PATH = 'spec/fixtures/line/bot/rich_menu_01.txt'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   let(:client) do
     dummy_config = {
diff --git a/spec/line/bot/send_message_01_text_spec.rb b/spec/line/bot/send_message_01_text_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the text message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_02_image_spec.rb b/spec/line/bot/send_message_02_image_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the image message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_03_video_spec.rb b/spec/line/bot/send_message_03_video_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the video message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_04_audio_spec.rb b/spec/line/bot/send_message_04_audio_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the audio message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_05_location_spec.rb b/spec/line/bot/send_message_05_location_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the location message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_06_sticker_spec.rb b/spec/line/bot/send_message_06_sticker_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the sticker message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_07_imagemap_spec.rb b/spec/line/bot/send_message_07_imagemap_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the imagemap message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_08_image_carousel_spec.rb b/spec/line/bot/send_message_08_image_carousel_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the image carousel message' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_11_template_buttons_spec.rb b/spec/line/bot/send_message_11_template_buttons_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the template message type buttons' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_12_template_confirm_spec.rb b/spec/line/bot/send_message_12_template_confirm_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the template message type confirm' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_13_template_carousel_spec.rb b/spec/line/bot/send_message_13_template_carousel_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the template message type carousel' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'
diff --git a/spec/line/bot/send_message_14_template_datepicker_spec.rb b/spec/line/bot/send_message_14_template_datepicker_spec.rb
@@ -2,8 +2,6 @@
 require 'webmock/rspec'
 require 'json'
 
-WebMock.allow_net_connect!
-
 describe Line::Bot::Client do
   it 'pushes the template message type datepicker' do
     uri_template = Addressable::Template.new Line::Bot::API::DEFAULT_ENDPOINT + '/bot/message/push'

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,6 @@`
`10`	`10`	`}`
`11`	`11`	`EOS`
`12`	`12`
`13`		`-WebMock.allow_net_connect!`
`14`		`-`
`15`	`13`	`describe Line::Bot::Client do`
`16`	`14`	`def dummy_config`
`17`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,6 @@`
`51`	`51`	`}`
`52`	`52`	`EOS`
`53`	`53`
`54`		`-WebMock.allow_net_connect!`
`55`		`-`
`56`	`54`	`describe Line::Bot::Client do`
`57`	`55`	`before do`
`58`	`56`	`end`
Original file line number	Diff line number	Diff line change
`@@ -200,8 +200,6 @@`
`200`	`200`	`}`
`201`	`201`	`EOS`
`202`	`202`
`203`		`-WebMock.allow_net_connect!`
`204`		`-`
`205`	`203`	`describe Line::Bot::Client do`
`206`	`204`	`before do`
`207`	`205`	`end`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@ def post(url, payload, header = {})`
`18`	`18`	`end`
`19`	`19`	`end`
`20`	`20`
`21`		`-WebMock.allow_net_connect!`
`22`		`-`
`23`	`21`	`describe Line::Bot::Client do`
`24`	`22`	`def dummy_config`
`25`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`}`
`9`	`9`	`EOS`
`10`	`10`
`11`		`-WebMock.allow_net_connect!`
`12`		`-`
`13`	`11`	`describe Line::Bot::Client do`
`14`	`12`	`let(:client) do`
`15`	`13`	`dummy_config = {`