❗ GitStream leaves comments that can't be expanded or resolved, MRs are blocked

[echarrod]

Describe the bug

After updating from 1.0.148 -> 1.0.150 (self-hosted docker image), GitStream leaves comments that look broken.

The MR can't be merged as it has unresolved comments, but the comments themselves can't be expanded resolved.

Screenshots

MR unable to be merged:

Comments which can't be resolved:

(top one I tried to "expand", but it didn't actually expand, bottom one is what it looks like before expanding)

Additional context

• Appeared after 1.0.148 -> 1.0.150 update (self-hosted docker image)

[echarrod]

I had a workaround of asking an AI Agent to resolve them with:

I have some unresolved threads on <MR_LINK>, can you resolve them please. 
I don't want you to make any updates to the code at all, I just want you to resolve the comments which are currently left on MR. 
I am unable to see them in the UI, so want to resolve through API/CLI

And to help you isolate this, MR link is https://gitlab.com/lunomoney/product-engineering/core/-/merge_requests/67055

[vim-zz]

Thank you for reporting, we are checking

[yeelali14]

@echarrod Could you please share your CM files with us? We’d like to review what rules you have.
Also, if you downgrade to version 1.0.148, does it work correctly? It seems related to a permissions issue.
And one more thing, does this happen in other MRs as well, or only in this MR? Thanks! 🙏

[echarrod]

Main config in cm repo:

# -*- mode: yaml -*-

# AI Code Review automation using LinearB's AI service
# This file provides AI-powered code review capabilities for merge requests
# View the gitStream quickstart for more examples: https://docs.gitstream.cm/examples/

manifest:
  version: 1.0

automations:
  # Use LinearB's AI service to review the changes
  linearb_ai_review:
    if:
      - "{{ not pr.draft }}"
      - "{{ not is.bot }}"

    run:
      - action: code-review@v1
        args:
          approve_on_LGTM: {{ approve_pr_on_lgtm }}

# Define variables
# Add conditions for PR approvals. For example - allow approval only for specific users
approve_pr_on_lgtm: false

Repo config:

manifest:
  version: 1.0

config:
  ignore_files:
    - 'go.sum'
    - 'go.work.sum'
    - '*.pb.go'
    - '*.pb.gw.go'
    - 'bin/**'
    - 'static/**'
    - 'blobs/**'

automations:
  # AI code review for new changes
  linearb_ai_review:
    if:
      - {{ not pr.draft }}
      - {{ not is.bot }}
    run:
      - action: code-review@v1
        args:
          approve_on_LGTM: {{ approve_pr_on_lgtm }} # optional arg, you can remove it
          guidelines: {{ guidelines }}

# Define variables
# Add conditions for PR approvals. For example - allow approval only for specific users
approve_pr_on_lgtm: false

# Custom expressions for bot detection
is:
  bot: >-
    {{ pr.author | match(list=[
        '_bot', 
        '[bot]',
        '_TOKEN' 
    ]) | some }}

# Add `guidelines` to add your prompts to the review, you can have org wide instructions
# by placing the `REVIEW_RULES.md` in the `cm` repo or team level instructions by adding it to
# the team repo.
# Note: To when the file is in the `cm` repo, use this example: `../cm/REVIEW_RULES.md`
guidelines: {{ "./.cm/REVIEW_RULES.md" | readFile() | dump }}

Just noticed it on this one MR so far.

We did have some other problems with 1.0.148, just exploring whether we could downgrade...

[vim-zz]

@echarrod if its a one time issue, I suggest we close this and see if happens again

[echarrod]

@echarrod if its a one time issue, I suggest we close this and see if happens again

OK sure, happy to do that! Asked others in my company to share if they experience this too 👍

[echarrod]

We have seen this again for https://gitlab.com/lunomoney/product-engineering/core/-/merge_requests/68030:

(I don't seem to have permission to reopen)