Clean up the stuff about licensing

Author: DJMcNab

fearless_simd_core/gen/src/data/x86.rs

@@ -22,11 +22,10 @@ macro_rules! f {
 
 pub(crate) const X86_TEMPLATE: &str = include_str!("../../templates/x86.rs");
 
-// Data taken from: https://doc.rust-lang.org/reference/attributes/codegen.html#r-attributes.codegen.target_feature.x86
+// Data adapted from: https://doc.rust-lang.org/reference/attributes/codegen.html#r-attributes.codegen.target_feature.x86
 // (specifically, at https://github.com/rust-lang/reference/blob/1d930e1d5a27e114b4d22a50b0b6cd3771b92e31/src/attributes/codegen.md#x86-or-x86_64)
-// TODO: Do we need to add their license attribution to our license?
 // TODO: Check set against https://doc.rust-lang.org/stable/std/macro.is_x86_feature_detected.html
-// In particular, we're missing lahfsahf
+// In particular, we seem to be missing lahfsahf (not stable?)
 pub(crate) const X86_FEATURES: &[Feature] = &[
     f!(
         /// [ADX] --- Multi-Precision Add-Carry Instruction Extensions

fearless_simd_core/gen/templates/x86.rs

@@ -59,7 +59,6 @@ impl FEATURE_STRUCT_NAME {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("{FEATURE_ID}") {
             // Safety: The required CPU feature was detected.

fearless_simd_core/gen/templates/x86_level.rs

@@ -86,7 +86,6 @@ impl LEVEL_STRUCT_NAME {
         }
     }
 }
-// TODO: From impls to convert into lower x86 versions.
 
 /*{FROM_IMPLS}*/
 

fearless_simd_core/src/lib.rs

@@ -65,7 +65,6 @@
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![no_std]
 
-// TODO: Do we want both an `x86` and `x86_64` module?
 #[cfg(any(target_arch = "x86", target_arch = "x86_64", doc))]
 pub mod x86;
 

fearless_simd_core/src/support.rs

@@ -236,7 +236,7 @@ mod tests {
 
         // We succeed if the empty target feature is allowed; any case where this is relevant will always
         // be validated away by rustc anyway, as there is no target with the target feature `""`.
-        // As such, there's no harm in being flexible here.
+        // As such, there's no harm in being flexible here.git
         expect_success("", [&[""]]);
         expect_success(",,,,,,", [&[""]]);
     }

fearless_simd_core/src/x86/adx/adx.rs

@@ -61,7 +61,6 @@ impl Adx {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("adx") {
             // Safety: The required CPU feature was detected.

fearless_simd_core/src/x86/avx/avx.rs

@@ -61,7 +61,6 @@ impl Avx {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("avx") {
             // Safety: The required CPU feature was detected.

fearless_simd_core/src/x86/avx/avx2.rs

@@ -63,7 +63,6 @@ impl Avx2 {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("avx2") {
             // Safety: The required CPU feature was detected.

fearless_simd_core/src/x86/avx/avxifma.rs

@@ -63,7 +63,6 @@ impl Avxifma {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("avxifma") {
             // Safety: The required CPU feature was detected.

fearless_simd_core/src/x86/avx/avxneconvert.rs

@@ -71,7 +71,6 @@ impl Avxneconvert {
     // TODO: Consider a manual override feature/env var?
     pub fn try_new() -> Option<Self> {
         // Feature flag required to make docs compile.
-        // TODO: Extract into a (private) crate::x86::is_x86_feature_detected?
         #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
         if std::arch::is_x86_feature_detected!("avxneconvert") {
             // Safety: The required CPU feature was detected.