Fix typos, remove unreachable!. (#3886)

## Motivation

Browsing through #3696
I found a few typos and an unnecessary `unreachable!`.

## Proposal

Fix them.

## Test Plan

CI

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: afck

linera-base/src/crypto/signer.rs

@@ -29,7 +29,7 @@ pub trait Signer: Send + Sync {
         owner: &AccountOwner,
     ) -> Result<AccountPublicKey, Box<dyn std::error::Error>>;
 
-    /// Returnes whether the given `owner` is a known signer.
+    /// Returns whether the given `owner` is a known signer.
     async fn contains_key(&self, owner: &AccountOwner) -> Result<bool, Box<dyn std::error::Error>>;
 }
 
@@ -55,7 +55,7 @@ impl Signer for Box<dyn Signer> {
     }
 }
 
-/// In-memory implementatio of the [`Signer`] trait.
+/// In-memory implementation of the [`Signer`] trait.
 mod in_mem {
     use std::{
         collections::BTreeMap,
@@ -77,14 +77,14 @@ mod in_mem {
     pub struct InMemorySigner(Arc<RwLock<InMemSignerInner>>);
 
     impl InMemorySigner {
-        /// Creates a new `InMemSigner` seeded with `prng_seed`.
+        /// Creates a new [`InMemorySigner`] seeded with `prng_seed`.
         /// If `prng_seed` is `None`, an `OsRng` will be used.
         #[cfg(with_getrandom)]
         pub fn new(prng_seed: Option<u64>) -> Self {
             InMemorySigner(Arc::new(RwLock::new(InMemSignerInner::new(prng_seed))))
         }
 
-        /// Creates a new `InMemSigner`.
+        /// Creates a new [`InMemorySigner`].
         #[cfg(not(with_getrandom))]
         pub fn new() -> Self {
             InMemorySigner(Arc::new(RwLock::new(InMemSignerInner::new())))
@@ -202,7 +202,7 @@ mod in_mem {
             }
         }
 
-        /// Returnes whether the given `owner` is a known signer.
+        /// Returns whether the given `owner` is a known signer.
         async fn contains_key(
             &self,
             owner: &AccountOwner,

linera-client/src/client_context.rs

@@ -497,7 +497,10 @@ where
     ) -> Result<(), Error> {
         let chain_id = chain_id.unwrap_or_else(|| self.default_chain());
         let chain_client = self.make_chain_client(chain_id).await?;
-        info!(?ownership_config, %chain_id, preferred_owner=?chain_client.preferred_owner(), "Changing ownership of a chain");
+        info!(
+            ?ownership_config, %chain_id, preferred_owner=?chain_client.preferred_owner(),
+            "Changing ownership of a chain"
+        );
         let time_start = Instant::now();
         let ownership = ChainOwnership::try_from(ownership_config)?;
 

linera-core/src/client/mod.rs

@@ -163,7 +163,7 @@ pub struct Client<Env: Environment> {
     tracked_chains: Arc<RwLock<HashSet<ChainId>>>,
     /// References to clients waiting for chain notifications.
     notifier: Arc<ChannelNotifier<Notification>>,
-    /// A reference to the Signer used to sign messages.
+    /// A reference to the [`Signer`] used to sign block proposals.
     signer: Box<dyn Signer>,
     /// Chain state for the managed chains.
     chains: DashMap<ChainId, ChainClientState>,
@@ -232,7 +232,7 @@ impl<Env: Environment> Client<Env> {
         &self.local_node
     }
 
-    /// Returns a reference to the `Signer`] of the client.
+    /// Returns a reference to the [`Signer`] of the client.
     #[instrument(level = "trace", skip(self))]
     pub fn signer(&self) -> &impl Signer {
         &self.signer
@@ -1120,38 +1120,32 @@ impl<Env: Environment> ChainClient<Env> {
             .chain(&manager.leader)
             .any(|owner| *owner == preferred_owner);
 
+        if !is_owner {
+            let accepted_owners = manager
+                .ownership
+                .all_owners()
+                .chain(&manager.leader)
+                .collect::<Vec<_>>();
+            warn!(%self.chain_id, ?accepted_owners, ?preferred_owner,
+                "Chain has multiple owners configured but none is preferred owner",
+            );
+            return Err(ChainClientError::NotAnOwner(self.chain_id));
+        }
+
         let has_signer = self
             .signer()
             .contains_key(&preferred_owner)
             .await
             .map_err(ChainClientError::signer_failure)?;
 
-        if is_owner && has_signer {
-            Ok(preferred_owner)
-        } else {
-            if !is_owner {
-                let accepted_owners = manager
-                    .ownership
-                    .all_owners()
-                    .chain(&manager.leader)
-                    .collect::<Vec<_>>();
-                warn!(%self.chain_id, ?accepted_owners, ?preferred_owner,
-                    "Chain has multiple owners configured but none is preferred owner",
-                );
-                return Err(ChainClientError::NotAnOwner(self.chain_id));
-            }
-
-            if !has_signer {
-                warn!(%self.chain_id, ?preferred_owner,
-                    "Chain is one of the owners but its Signer instance doesn't contain the key",
-                );
-                return Err(ChainClientError::CannotFindKeyForChain(self.chain_id));
-            }
-            unreachable!(
-                "Either is_owner and has_signer are both true, 
-                or one of them if false - all three cases are covered."
+        if !has_signer {
+            warn!(%self.chain_id, ?preferred_owner,
+                "Chain is one of the owners but its Signer instance doesn't contain the key",
             );
+            return Err(ChainClientError::CannotFindKeyForChain(self.chain_id));
         }
+
+        Ok(preferred_owner)
     }
 
     /// Obtains the public key associated to the current identity.