Skip to content

Commit 01c6f6f

Browse files
authored
Make sure we're building release images (#3867)
## Motivation These places were missed, and are the most important ones πŸ€¦πŸ»β€β™‚οΈ ## Proposal Make sure we're building with release mode in the places we should be ## Test Plan CI ## Release Plan - These changes should be backported to the latest `testnet` branch, then - be released in a validator hotfix. This doesn't seem to have affected our `testnet_babbage` image though, so this might be optional
1 parent d383a09 commit 01c6f6f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

β€Ž.github/workflows/docker_image.ymlβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
5050
- name: Build Docker image
5151
run: |
52-
docker build --build-arg git_commit=${{ env.GIT_COMMIT_LONG }} \
52+
docker build --build-arg git_commit=${{ env.GIT_COMMIT_LONG }} --build-arg build_flag="--release" --build-arg build_folder="release" \
5353
-f docker/Dockerfile . \
5454
-t ${{ env.DOCKER_IMAGE }}:${{ env.BRANCH_NAME }} \
5555
-t ${{ env.DOCKER_IMAGE }}:${{ env.GIT_COMMIT_SHORT }} \

β€Žscripts/deploy-validator.shβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ GENESIS_CONFIG="docker/genesis.json"
5454

5555
if [ -z "$REMOTE_IMAGE" ]; then
5656
echo "Building local image from commit $GIT_COMMIT..."
57-
docker build --build-arg git_commit="$GIT_COMMIT" -f docker/Dockerfile . -t linera
57+
docker build --build-arg git_commit="$GIT_COMMIT" --build-arg build_flag="--release" --build-arg build_folder="release" -f docker/Dockerfile . -t linera
5858
export LINERA_IMAGE=linera
5959
else
6060
export LINERA_IMAGE="us-docker.pkg.dev/linera-io-dev/linera-public-registry/linera:${BRANCH_NAME}_release"

0 commit comments

Comments
Β (0)