Make release the default mode for Dockerfile (#3871)

## Motivation

This should've been the case from the start, but I was lazy and did the other way around, which turned out to complicate things more actually

## Proposal

Make release the default

## Test Plan

CI + will start a network with debug mode

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

Author: ndr-ds

.github/workflows/docker_image.yml

@@ -49,7 +49,7 @@ jobs:
   
       - name: Build Docker image
         run: |
-          docker build --build-arg git_commit=${{ env.GIT_COMMIT_LONG }} --build-arg build_flag="--release" --build-arg build_folder="release" \
+          docker build --build-arg git_commit=${{ env.GIT_COMMIT_LONG }} \
             -f docker/Dockerfile . \
             -t ${{ env.DOCKER_IMAGE }}:${{ env.BRANCH_NAME }} \
             -t ${{ env.DOCKER_IMAGE }}:${{ env.GIT_COMMIT_SHORT }} \

docker/Dockerfile

@@ -22,8 +22,8 @@ ARG build_date
 ARG target=x86_64-unknown-linux-gnu
 ARG binaries=
 ARG copy=${binaries:+_copy}
-ARG build_flag=
-ARG build_folder=
+ARG build_flag=--release
+ARG build_folder=release
 
 FROM rust:1.74-slim-bookworm AS builder
 ARG git_commit

docker/compose.sh

@@ -37,11 +37,11 @@ cd "$ROOT_DIR"
 GIT_COMMIT=$(git rev-parse --short HEAD)
 
 if [[ "$OSTYPE" == "linux-gnu"* ]]; then
-    docker build --build-arg git_commit="$GIT_COMMIT" --build-arg build_flag="--release" --build-arg build_folder="release" -f docker/Dockerfile . -t linera || exit 1
+    docker build --build-arg git_commit="$GIT_COMMIT" -f docker/Dockerfile . -t linera || exit 1
 elif [[ "$OSTYPE" == "darwin"* ]]; then
     CPU_ARCH=$(sysctl -n machdep.cpu.brand_string)
     if [[ "$CPU_ARCH" == *"Apple"* ]]; then
-        docker build --build-arg git_commit="$GIT_COMMIT" --build-arg target=aarch64-unknown-linux-gnu --build-arg build_flag="--release" --build-arg build_folder="release" -f docker/Dockerfile -t linera . || exit 1
+        docker build --build-arg git_commit="$GIT_COMMIT" --build-arg target=aarch64-unknown-linux-gnu -f docker/Dockerfile -t linera . || exit 1
     else
         echo "Unsupported Architecture: $CPU_ARCH"
         exit 1

linera-service/src/cli_wrappers/docker.rs

@@ -65,12 +65,11 @@ impl DockerImage {
             .args(["--build-arg", &build_arg]);
 
         match build_mode {
-            BuildMode::Release => {
-                command.args(["--build-arg", "build_flag=--release"]);
-                command.args(["--build-arg", "build_folder=release"]);
-            }
+            // Release is the default, so no need to add any arguments
+            BuildMode::Release => {}
             BuildMode::Debug => {
                 command.args(["--build-arg", "build_folder=debug"]);
+                command.args(["--build-arg", "build_flag="]);
             }
         }
 

scripts/deploy-validator.sh

@@ -54,7 +54,7 @@ GENESIS_CONFIG="docker/genesis.json"
 
 if [ -z "$REMOTE_IMAGE" ]; then
   echo "Building local image from commit $GIT_COMMIT..."
-  docker build --build-arg git_commit="$GIT_COMMIT" --build-arg build_flag="--release" --build-arg build_folder="release" -f  docker/Dockerfile . -t linera
+  docker build --build-arg git_commit="$GIT_COMMIT" -f  docker/Dockerfile . -t linera
   export LINERA_IMAGE=linera
 else
   export LINERA_IMAGE="us-docker.pkg.dev/linera-io-dev/linera-public-registry/linera:${BRANCH_NAME}_release"