linera_core: split chain client out of client (#4843)

## Motivation

I'm trying to work on the client, but the file `client/mod.rs` was too
big, and my `rust-analyzer` was struggling.

## Proposal

Split `ChainClient` into its own module. This roughly halves the file,
though since we import everything unqualified there is an overhead in
total LoC to creating new modules.

## Test Plan

CI.

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: Twey

linera-client/src/benchmark.rs

@@ -16,7 +16,7 @@ use linera_base::{
     time::Instant,
 };
 use linera_core::{
-    client::{ChainClient, ChainClientError},
+    client::chain_client::{self, ChainClient},
     Environment,
 };
 use linera_execution::{system::SystemOperation, Operation};
@@ -42,7 +42,7 @@ pub enum BenchmarkError {
     #[error("Failed to join task: {0}")]
     JoinError(#[from] task::JoinError),
     #[error("Chain client error: {0}")]
-    ChainClient(#[from] ChainClientError),
+    ChainClient(#[from] chain_client::Error),
     #[error("Current histogram count is less than previous histogram count")]
     HistogramCountMismatch,
     #[error("Expected histogram value, got {0:?}")]

linera-client/src/chain_listener.rs

@@ -19,7 +19,10 @@ use linera_base::{
     task::NonBlockingFuture,
 };
 use linera_core::{
-    client::{AbortOnDrop, ChainClient, ChainClientError, ListeningMode},
+    client::{
+        chain_client::{self, ChainClient},
+        AbortOnDrop, ListeningMode,
+    },
     node::NotificationStream,
     worker::{Notification, Reason},
     Environment,
@@ -332,7 +335,7 @@ impl<C: ClientContext + 'static> ChainListener<C> {
             .storage
             .read_confirmed_block(hash)
             .await?
-            .ok_or(ChainClientError::MissingConfirmedBlock(hash))?
+            .ok_or(chain_client::Error::MissingConfirmedBlock(hash))?
             .into_block();
         let blobs = block.created_blobs().into_iter();
         let new_chains = blobs
@@ -359,7 +362,7 @@ impl<C: ClientContext + 'static> ChainListener<C> {
                     .signer()
                     .contains_key(&chain_owner)
                     .await
-                    .map_err(ChainClientError::signer_failure)?
+                    .map_err(chain_client::Error::signer_failure)?
                 {
                     context_guard
                         .update_wallet_for_new_chain(
@@ -583,7 +586,7 @@ impl<C: ClientContext + 'static> ChainListener<C> {
             .process_inbox_without_prepare()
             .await
         {
-            Err(ChainClientError::CannotFindKeyForChain(chain_id)) => {
+            Err(chain_client::Error::CannotFindKeyForChain(chain_id)) => {
                 debug!(%chain_id, "Cannot find key for chain");
             }
             Err(error) => warn!(%error, "Failed to process inbox."),

linera-client/src/client_context.rs

@@ -36,7 +36,7 @@ use {
         data_types::Amount,
         identifiers::{ApplicationId, BlobType},
     },
-    linera_core::client::ChainClientError,
+    linera_core::client::chain_client,
     linera_execution::{
         system::{OpenChainConfig, SystemOperation},
         Operation,
@@ -331,7 +331,7 @@ where
         block_cache_size: usize,
         execution_state_cache_size: usize,
     ) -> Self {
-        use linera_core::{client::ChainClientOptions, node::CrossChainMessageDelivery};
+        use linera_core::{client::chain_client, node::CrossChainMessageDelivery};
 
         let send_recv_timeout = Duration::from_millis(4000);
         let retry_delay = Duration::from_millis(1000);
@@ -363,9 +363,9 @@ where
             name,
             chain_worker_ttl,
             sender_chain_worker_ttl,
-            ChainClientOptions {
+            chain_client::Options {
                 cross_chain_message_delivery: CrossChainMessageDelivery::Blocking,
-                ..ChainClientOptions::test_default()
+                ..chain_client::Options::test_default()
             },
             block_cache_size,
             execution_state_cache_size,
@@ -987,7 +987,7 @@ where
                 .map(|chain_client| async move {
                     chain_client.process_inbox().await?;
                     info!("Processed inbox for chain {:?}", chain_client.chain_id());
-                    Ok::<(), ChainClientError>(())
+                    Ok::<(), chain_client::Error>(())
                 })
                 .buffer_unordered(wrap_up_max_in_flight);
             stream.try_collect::<Vec<_>>().await?;

linera-client/src/client_options.rs

@@ -11,8 +11,8 @@ use linera_base::{
 };
 use linera_core::{
     client::{
-        BlanketMessagePolicy, ChainClientOptions, MessagePolicy,
-        DEFAULT_CERTIFICATE_DOWNLOAD_BATCH_SIZE, DEFAULT_SENDER_CERTIFICATE_DOWNLOAD_BATCH_SIZE,
+        chain_client, BlanketMessagePolicy, MessagePolicy, DEFAULT_CERTIFICATE_DOWNLOAD_BATCH_SIZE,
+        DEFAULT_SENDER_CERTIFICATE_DOWNLOAD_BATCH_SIZE,
     },
     node::CrossChainMessageDelivery,
     DEFAULT_GRACE_PERIOD,
@@ -189,15 +189,15 @@ pub struct ClientContextOptions {
 }
 
 impl ClientContextOptions {
-    /// Creates [`ChainClientOptions`] with the corresponding values.
-    pub(crate) fn to_chain_client_options(&self) -> ChainClientOptions {
+    /// Creates [`chain_client::Options`] with the corresponding values.
+    pub(crate) fn to_chain_client_options(&self) -> chain_client::Options {
         let message_policy = MessagePolicy::new(
             self.blanket_message_policy,
             self.restrict_chain_ids_to.clone(),
         );
         let cross_chain_message_delivery =
             CrossChainMessageDelivery::new(self.wait_for_outgoing_messages);
-        ChainClientOptions {
+        chain_client::Options {
             max_pending_message_bundles: self.max_pending_message_bundles,
             message_policy,
             cross_chain_message_delivery,

linera-client/src/error.rs

@@ -21,7 +21,7 @@ pub(crate) enum Inner {
     #[error("chain error: {0}")]
     Chain(#[from] linera_chain::ChainError),
     #[error("chain client error: {0}")]
-    ChainClient(#[from] linera_core::client::ChainClientError),
+    ChainClient(#[from] linera_core::client::chain_client::Error),
     #[error("options error: {0}")]
     Options(#[from] crate::client_options::Error),
     #[error("persistence error: {0}")]

linera-client/src/unit_tests/chain_listener.rs

@@ -11,7 +11,7 @@ use linera_base::{
     ownership::{ChainOwnership, TimeoutConfig},
 };
 use linera_core::{
-    client::{ChainClient, ChainClientOptions, Client},
+    client::{chain_client, ChainClient, Client},
     environment,
     test_utils::{MemoryStorageBuilder, StorageBuilder as _, TestBuilder},
 };
@@ -122,7 +122,7 @@ async fn test_chain_listener() -> anyhow::Result<()> {
             format!("Client node for {:.8}", chain_id0),
             Duration::from_secs(30),
             Duration::from_secs(1),
-            ChainClientOptions::test_default(),
+            chain_client::Options::test_default(),
             5_000,
             10_000,
         )),
@@ -210,7 +210,7 @@ async fn test_chain_listener_admin_chain() -> anyhow::Result<()> {
             "Client node with no chains".to_string(),
             Duration::from_secs(30),
             Duration::from_secs(1),
-            ChainClientOptions::test_default(),
+            chain_client::Options::test_default(),
             5_000,
             10_000,
         )),