Fix some pedantic Clippy warnings. (#4531)

## Motivation

Many of the non-default Clippy lints in the "pedantic" category are
actually useful, especially the "don't re-implement the standard
library" ones.

## Proposal

Fix many pedantic warnings. Deny some of the lints.

## Test Plan

CI

## Release Plan

- Nothing to do / These changes follow the usual release cycle.
- (But could be backported.)

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: afck

Cargo.lock

@@ -361,4 +361,21 @@ branch = "post-message"
 config = "spellcheck-cfg.toml"
 
 [workspace.lints.clippy]
+doc_link_with_quotes = "deny"
+filter_map_next = "deny"
+iter_filter_is_some = "deny"
 large_futures = "deny"
+large_stack_arrays = "deny"
+large_types_passed_by_value = "deny"
+macro_use_imports = "deny"
+manual_instant_elapsed = "deny"
+manual_is_power_of_two = "deny"
+manual_is_variant_and = "deny"
+map_unwrap_or = "deny"
+mismatching_type_param_order = "deny"
+naive_bytecount = "deny"
+non_std_lazy_statics = "deny"
+range_minus_one = "deny"
+range_plus_one = "deny"
+ref_option_ref = "deny"
+str_split_at_newline = "deny"

Cargo.toml

@@ -24,7 +24,7 @@ async fn test_create_and_call() {
         .expect("Failed to get absolute path to counter-no-graphql");
 
     // Build and find the counter-no-graphql bytecode files
-    ActiveChain::build_bytecode_files_in(&counter_no_graphql_path).await;
+    ActiveChain::build_bytecode_files_in(&counter_no_graphql_path);
     let (counter_contract, counter_service) =
         ActiveChain::find_bytecode_files_in(&counter_no_graphql_path).await;
 

examples/create-and-call/tests/test_create_and_call.rs

@@ -135,8 +135,7 @@ impl ModelContext {
             if index_pos == 256 {
                 return Ok(output
                     .rsplit_once('.')
-                    .map(|(before, _)| format!("{}.", before))
-                    .unwrap_or_else(|| output.to_string()));
+                    .map_or_else(|| output.to_string(), |(before, _)| format!("{}.", before)));
             }
             let logits = model.forward(&input, index_pos)?;
             let logits = logits.i((0, logits.dim(1)? - 1))?;

examples/gen-nft/src/model.rs

@@ -223,8 +223,7 @@ impl ModelContext {
             if index_pos == 256 {
                 return Ok(output
                     .rsplit_once('.')
-                    .map(|(before, _)| format!("{}.", before))
-                    .unwrap_or_else(|| output.to_string()));
+                    .map_or_else(|| output.to_string(), |(before, _)| format!("{}.", before)));
             }
             let logits = model.forward(&input, index_pos)?;
             let logits = logits.i((0, logits.dim(1)? - 1))?;

examples/llm/src/service.rs

@@ -37,7 +37,7 @@ impl Ed25519SecretKey {
     #[cfg(all(with_getrandom, with_testing))]
     /// Generates a new key pair using the operating system's RNG.
     ///
-    /// If you want control over the RNG, use `generate_from`[Ed25519SecretKey::generate_from].
+    /// If you want control over the RNG, use [`Ed25519SecretKey::generate_from`].
     pub fn generate() -> Self {
         let mut rng = rand::rngs::OsRng;
         Self::generate_from(&mut rng)
@@ -345,7 +345,7 @@ impl Ed25519Signature {
         let mut messages = Vec::new();
         let mut signatures = Vec::new();
         let mut public_keys = Vec::new();
-        for (addr, sig) in votes.into_iter() {
+        for (addr, sig) in votes {
             messages.push(msg.as_slice());
             signatures.push(sig.0);
             public_keys.push(dalek::VerifyingKey::from_bytes(&addr.0)?);

linera-base/src/crypto/ed25519.rs

@@ -272,7 +272,7 @@ impl AccountSignature {
         bcs::from_bytes(bytes).map_err(CryptoError::SignatureParseError)
     }
 
-    /// Returns the AccountOwner of the account that signed the value.
+    /// Returns the [`AccountOwner`] of the account that signed the value.
     pub fn owner(&self) -> AccountOwner {
         match self {
             AccountSignature::Ed25519 { public_key, .. } => AccountOwner::from(*public_key),

linera-base/src/crypto/mod.rs

@@ -1013,16 +1013,14 @@ impl ApplicationPermissions {
     pub fn can_call_services(&self, app_id: &ApplicationId) -> bool {
         self.call_service_as_oracle
             .as_ref()
-            .map(|app_ids| app_ids.contains(app_id))
-            .unwrap_or(true)
+            .is_none_or(|app_ids| app_ids.contains(app_id))
     }
 
     /// Returns whether the given application can make HTTP requests.
     pub fn can_make_http_requests(&self, app_id: &ApplicationId) -> bool {
         self.make_http_requests
             .as_ref()
-            .map(|app_ids| app_ids.contains(app_id))
-            .unwrap_or(true)
+            .is_none_or(|app_ids| app_ids.contains(app_id))
     }
 }
 
@@ -1120,7 +1118,7 @@ impl Bytecode {
     }
 
     /// Load bytecode from a Wasm module file.
-    pub async fn load_from_file(path: impl AsRef<std::path::Path>) -> std::io::Result<Self> {
+    pub fn load_from_file(path: impl AsRef<std::path::Path>) -> std::io::Result<Self> {
         let bytes = fs::read(path)?;
         Ok(Bytecode { bytes })
     }
@@ -1332,13 +1330,13 @@ impl BlobContent {
         &self.bytes
     }
 
-    /// Convert a BlobContent into `Vec<u8>` without cloning if possible.
+    /// Converts a `BlobContent` into `Vec<u8>` without cloning if possible.
     pub fn into_vec_or_clone(self) -> Vec<u8> {
         let bytes = Arc::unwrap_or_clone(self.bytes);
         bytes.into_vec()
     }
 
-    /// Get the Arc<Box<[u8]>> directly without cloning.
+    /// Gets the `Arc<Box<[u8]>>` directly without cloning.
     pub fn into_arc_bytes(self) -> Arc<Box<[u8]>> {
         self.bytes
     }
@@ -1459,7 +1457,7 @@ impl Blob {
     }
 
     /// Loads data blob from a file.
-    pub async fn load_data_blob_from_file(path: impl AsRef<Path>) -> io::Result<Self> {
+    pub fn load_data_blob_from_file(path: impl AsRef<Path>) -> io::Result<Self> {
         Ok(Self::new_data(fs::read(path)?))
     }
 

linera-base/src/data_types.rs

@@ -137,11 +137,7 @@ impl ChainOwnership {
                 Some(tc.base_timeout)
             }
             Round::MultiLeader(_) => None,
-            Round::SingleLeader(r) => {
-                let increment = tc.timeout_increment.saturating_mul(u64::from(r));
-                Some(tc.base_timeout.saturating_add(increment))
-            }
-            Round::Validator(r) => {
+            Round::SingleLeader(r) | Round::Validator(r) => {
                 let increment = tc.timeout_increment.saturating_mul(u64::from(r));
                 Some(tc.base_timeout.saturating_add(increment))
             }

linera-base/src/ownership.rs

@@ -40,8 +40,7 @@ pub fn init(log_name: &str) {
 
     let span_events = std::env::var("RUST_LOG_SPAN_EVENTS")
         .ok()
-        .map(|s| fmt_span_from_str(&s))
-        .unwrap_or(FmtSpan::NONE);
+        .map_or(FmtSpan::NONE, |s| fmt_span_from_str(&s));
 
     let format = std::env::var("RUST_LOG_FORMAT").ok();