Skip to content

Commit 31040be

Browse files
authored
Fix a few bugs in net up --kubernetes (#4516)
## Motivation Some of the configs were wrong, as well as the port forwarding, making notifications stop working and 3 of the tests fail. ## Proposal Do the required fixes (wrong address, port forwarding, etc). Fixes #4494 ## Test Plan Started a local network with `net up --kubernetes`, ran e2e tests against it, they all pass. ## Release Plan - Nothing to do / These changes follow the usual release cycle.
1 parent 272bc98 commit 31040be

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

configuration/compose/validator.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Grpc = "ClearText"
1515
host = "proxy"
1616
private_port = 20100
1717
public_port = 19100
18-
metrics_host = "proxy"
1918
metrics_port = 21100
2019

2120
[[shards]]

linera-service/src/cli_wrappers/local_kubernetes_net.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ impl LocalKubernetesNet {
382382
Grpc = "ClearText"
383383
384384
[[proxies]]
385-
host = "proxy-0.default.svc.cluster.local"
385+
host = "proxy-0.proxy-internal.default.svc.cluster.local"
386386
public_port = {port}
387387
private_port = {internal_port}
388388
metrics_port = {metrics_port}
@@ -495,7 +495,7 @@ impl LocalKubernetesNet {
495495
let local_port = 19100 + i;
496496
kubectl_instance.port_forward(
497497
proxy_service,
498-
&format!("{local_port}:{local_port}"),
498+
&format!("{local_port}:19100"),
499499
cluster_id,
500500
)?;
501501

linera-service/src/cli_wrappers/local_net.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,6 @@ impl LocalNet {
514514
host = "{internal_host}"
515515
public_port = {public_port}
516516
private_port = {internal_port}
517-
metrics_host = "{external_host}"
518517
metrics_port = {metrics_port}
519518
"#
520519
));

linera-service/src/server.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,6 @@ mod test {
618618
host = "proxy"
619619
public_port = 20100
620620
private_port = 20200
621-
metrics_host = "proxy"
622621
metrics_port = 21100
623622
624623
[[shards]]

0 commit comments

Comments
 (0)