Add new, unused for now, fields and types. (#4391)

## Motivation

Otherwise hotfixing won't be possible due to non-compatible changes in
the original PR.

## Proposal

Add the types, fields, but not use them.

## Test Plan

CI

## Release Plan


- Nothing to do / These changes follow the usual release cycle.

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: deuszx

linera-core/src/data_types.rs

@@ -90,6 +90,9 @@ pub struct ChainInfoQuery {
     /// Include a vote to switch to fallback mode, if appropriate.
     #[debug(skip_if = Not::not)]
     pub request_fallback: bool,
+    /// Query for certificate hashes at block heights.
+    #[debug(skip_if = Vec::is_empty)]
+    pub request_sent_certificate_hashes_by_heights: Vec<BlockHeight>,
 }
 
 impl ChainInfoQuery {
@@ -105,6 +108,7 @@ impl ChainInfoQuery {
             request_manager_values: false,
             request_leader_timeout: None,
             request_fallback: false,
+            request_sent_certificate_hashes_by_heights: Vec::new(),
         }
     }
 

linera-core/src/node.rs

@@ -288,6 +288,18 @@ pub enum NodeError {
     EmptyBlobsNotFound,
     #[error("Local error handling validator response: {error}")]
     ResponseHandlingError { error: String },
+
+    #[error("Missing certificates for chain {chain_id} in heights {heights:?}")]
+    MissingCertificatesByHeights {
+        chain_id: ChainId,
+        heights: Vec<BlockHeight>,
+    },
+
+    #[error("Too many certificates returned for chain {chain_id} from {remote_node}")]
+    TooManyCertificatesReturned {
+        chain_id: ChainId,
+        remote_node: Box<ValidatorPublicKey>,
+    },
 }
 
 impl From<tonic::Status> for NodeError {

linera-rpc/src/grpc/conversions.rs

@@ -610,6 +610,7 @@ impl TryFrom<api::ChainInfoQuery> for ChainInfoQuery {
             request_manager_values: chain_info_query.request_manager_values,
             request_leader_timeout,
             request_fallback: chain_info_query.request_fallback,
+            request_sent_certificate_hashes_by_heights: vec![],
         })
     }
 }
@@ -1152,6 +1153,7 @@ pub mod tests {
             request_manager_values: false,
             request_leader_timeout: None,
             request_fallback: true,
+            request_sent_certificate_hashes_by_heights: vec![],
         };
         round_trip_check::<_, api::ChainInfoQuery>(chain_info_query_some);
     }

linera-rpc/src/message.rs

@@ -4,7 +4,7 @@
 
 use linera_base::{
     crypto::CryptoHash,
-    data_types::{BlobContent, NetworkDescription},
+    data_types::{BlobContent, BlockHeight, NetworkDescription},
     identifiers::{BlobId, ChainId},
 };
 use linera_chain::{
@@ -39,6 +39,7 @@ pub enum RpcMessage {
     HandlePendingBlob(Box<(ChainId, BlobContent)>),
     DownloadConfirmedBlock(Box<CryptoHash>),
     DownloadCertificates(Vec<CryptoHash>),
+    DownloadCertificatesByHeights(ChainId, Vec<BlockHeight>),
     BlobLastUsedBy(Box<BlobId>),
     MissingBlobIds(Vec<BlobId>),
     VersionInfoQuery,
@@ -55,6 +56,7 @@ pub enum RpcMessage {
     DownloadPendingBlobResponse(Box<BlobContent>),
     DownloadConfirmedBlockResponse(Box<ConfirmedBlock>),
     DownloadCertificatesResponse(Vec<ConfirmedBlockCertificate>),
+    DownloadCertificatesByHeightsResponse(Vec<ConfirmedBlockCertificate>),
     BlobLastUsedByResponse(Box<CryptoHash>),
     MissingBlobIdsResponse(Vec<BlobId>),
 
@@ -93,6 +95,8 @@ impl RpcMessage {
             | DownloadPendingBlobResponse(_)
             | DownloadConfirmedBlock(_)
             | DownloadConfirmedBlockResponse(_)
+            | DownloadCertificatesByHeights(_, _)
+            | DownloadCertificatesByHeightsResponse(_)
             | DownloadCertificates(_)
             | BlobLastUsedBy(_)
             | BlobLastUsedByResponse(_)
@@ -140,7 +144,9 @@ impl RpcMessage {
             | DownloadConfirmedBlockResponse(_)
             | BlobLastUsedByResponse(_)
             | MissingBlobIdsResponse(_)
-            | DownloadCertificatesResponse(_) => false,
+            | DownloadCertificatesResponse(_)
+            | DownloadCertificatesByHeights(_, _)
+            | DownloadCertificatesByHeightsResponse(_) => false,
         }
     }
 }

linera-rpc/src/simple/server.rs

@@ -384,7 +384,11 @@ where
             | RpcMessage::DownloadCertificates(_)
             | RpcMessage::DownloadCertificatesResponse(_)
             | RpcMessage::UploadBlob(_)
-            | RpcMessage::UploadBlobResponse(_) => Err(NodeError::UnexpectedMessage),
+            | RpcMessage::UploadBlobResponse(_)
+            | RpcMessage::DownloadCertificatesByHeights(_, _)
+            | RpcMessage::DownloadCertificatesByHeightsResponse(_) => {
+                Err(NodeError::UnexpectedMessage)
+            }
         };
 
         self.server.packets_processed += 1;

linera-rpc/tests/snapshots/format__format.yaml.snap

@@ -362,6 +362,9 @@ ChainInfoQuery:
             - TYPENAME: BlockHeight
             - TYPENAME: Round
     - request_fallback: BOOL
+    - request_sent_certificate_hashes_by_heights:
+        SEQ:
+          TYPENAME: BlockHeight
 ChainInfoResponse:
   STRUCT:
     - info:
@@ -789,6 +792,21 @@ NodeError:
       ResponseHandlingError:
         STRUCT:
           - error: STR
+    29:
+      MissingCertificatesByHeights:
+        STRUCT:
+          - chain_id:
+              TYPENAME: ChainId
+          - heights:
+              SEQ:
+                TYPENAME: BlockHeight
+    30:
+      TooManyCertificatesReturned:
+        STRUCT:
+          - chain_id:
+              TYPENAME: ChainId
+          - remote_node:
+              TYPENAME: Secp256k1PublicKey
 OpenChainConfig:
   STRUCT:
     - ownership:
@@ -1038,69 +1056,80 @@ RpcMessage:
           SEQ:
             TYPENAME: CryptoHash
     12:
+      DownloadCertificatesByHeights:
+        TUPLE:
+          - TYPENAME: ChainId
+          - SEQ:
+              TYPENAME: BlockHeight
+    13:
       BlobLastUsedBy:
         NEWTYPE:
           TYPENAME: BlobId
-    13:
+    14:
       MissingBlobIds:
         NEWTYPE:
           SEQ:
             TYPENAME: BlobId
-    14:
-      VersionInfoQuery: UNIT
     15:
-      NetworkDescriptionQuery: UNIT
+      VersionInfoQuery: UNIT
     16:
+      NetworkDescriptionQuery: UNIT
+    17:
       Vote:
         NEWTYPE:
           TYPENAME: LiteVote
-    17:
+    18:
       ChainInfoResponse:
         NEWTYPE:
           TYPENAME: ChainInfoResponse
-    18:
+    19:
       Error:
         NEWTYPE:
           TYPENAME: NodeError
-    19:
+    20:
       VersionInfoResponse:
         NEWTYPE:
           TYPENAME: VersionInfo
-    20:
+    21:
       NetworkDescriptionResponse:
         NEWTYPE:
           TYPENAME: NetworkDescription
-    21:
+    22:
       UploadBlobResponse:
         NEWTYPE:
           TYPENAME: BlobId
-    22:
+    23:
       DownloadBlobResponse:
         NEWTYPE:
           TYPENAME: BlobContent
-    23:
+    24:
       DownloadPendingBlobResponse:
         NEWTYPE:
           TYPENAME: BlobContent
-    24:
+    25:
       DownloadConfirmedBlockResponse:
         NEWTYPE:
           TYPENAME: Block
-    25:
+    26:
       DownloadCertificatesResponse:
         NEWTYPE:
           SEQ:
             TYPENAME: ConfirmedBlockCertificate
-    26:
+    27:
+      DownloadCertificatesByHeightsResponse:
+        NEWTYPE:
+          SEQ:
+            TYPENAME: ConfirmedBlockCertificate
+    28:
       BlobLastUsedByResponse:
         NEWTYPE:
           TYPENAME: CryptoHash
-    27:
+    29:
       MissingBlobIdsResponse:
         NEWTYPE:
           SEQ:
             TYPENAME: BlobId
-    28:
+    30:
       CrossChainRequest:
         NEWTYPE:
           TYPENAME: CrossChainRequest

linera-service/src/proxy/main.rs

@@ -385,7 +385,11 @@ where
             | MissingBlobIdsResponse(_)
             | DownloadConfirmedBlockResponse(_)
             | DownloadCertificatesResponse(_)
-            | UploadBlobResponse(_) => Err(anyhow::Error::from(NodeError::UnexpectedMessage)),
+            | UploadBlobResponse(_)
+            | DownloadCertificatesByHeights(_, _)
+            | DownloadCertificatesByHeightsResponse(_) => {
+                Err(anyhow::Error::from(NodeError::UnexpectedMessage))
+            }
         }
     }
 }