Corrections for the clone operations. (#4368)

## Motivation

Some clone operations no longer need to have an error type. This
simplifies the code.

## Proposal

Straightforward.

## Test Plan

The CI.

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

## Links

None

Author: MathieuDutSik

linera-service/src/exporter/runloops/block_processor/mod.rs

@@ -192,7 +192,7 @@ mod test {
             NodeOptions::default(),
             0,
             signal.clone(),
-            exporter_storage.clone().unwrap(),
+            exporter_storage.clone(),
             vec![],
         );
         let mut block_processor = BlockProcessor::new(
@@ -328,7 +328,7 @@ mod test {
             NodeOptions::default(),
             0,
             signal.clone(),
-            exporter_storage.clone().unwrap(),
+            exporter_storage.clone(),
             vec![],
         );
         let mut block_processor = BlockProcessor::new(
@@ -444,7 +444,7 @@ mod test {
             NodeOptions::default(),
             0,
             signal.clone(),
-            exporter_storage.clone().unwrap(),
+            exporter_storage.clone(),
             vec![],
         );
         let mut block_processor = BlockProcessor::new(
@@ -531,7 +531,7 @@ mod test {
             NodeOptions::default(),
             0,
             signal.clone(),
-            exporter_storage.clone().unwrap(),
+            exporter_storage.clone(),
             vec![],
         );
         let mut block_processor = BlockProcessor::new(
@@ -640,7 +640,7 @@ mod test {
             NodeOptions::default(),
             0,
             signal.clone(),
-            exporter_storage.clone().unwrap(),
+            exporter_storage.clone(),
             vec![],
         );
         let mut block_processor = BlockProcessor::new(

linera-service/src/exporter/runloops/indexer/indexer_exporter.rs

@@ -68,7 +68,7 @@ impl Exporter {
                 self.work_queue_size,
                 destination_state.load(Ordering::Acquire) as usize,
                 outgoing_stream,
-                storage.clone().unwrap(),
+                storage.clone(),
             );
 
             let mut acknowledgement_task =

linera-service/src/exporter/runloops/mod.rs

@@ -112,7 +112,7 @@ where
         options,
         limits.work_queue_size.into(),
         shutdown_signal.clone(),
-        exporter_storage.clone().unwrap(),
+        exporter_storage.clone(),
         destination_config.destinations.clone(),
     );
 

linera-service/src/exporter/runloops/task_manager.rs

@@ -112,7 +112,7 @@ where
 
     fn spawn(&mut self, id: DestinationId) {
         let exporter_builder = &self.exporters_builder;
-        let join_handle = exporter_builder.spawn(id.clone(), self.storage.clone().unwrap());
+        let join_handle = exporter_builder.spawn(id.clone(), self.storage.clone());
         self.join_handles.insert(id, join_handle);
     }
 }

linera-service/src/exporter/runloops/validator_exporter.rs

@@ -62,10 +62,10 @@ impl Exporter {
         let (mut task_queue, task_receiver) = TaskQueue::new(
             self.work_queue_size,
             destination_state.load(Ordering::Acquire) as usize,
-            storage.clone().unwrap(),
+            storage.clone(),
         );
 
-        let export_task = ExportTask::new(node, storage.clone().unwrap(), destination_state);
+        let export_task = ExportTask::new(node, storage.clone(), destination_state);
 
         tokio::select! {
 

linera-service/src/exporter/storage.rs

@@ -17,10 +17,7 @@ use linera_base::{
     identifiers::{BlobId, ChainId},
 };
 use linera_chain::types::ConfirmedBlockCertificate;
-use linera_sdk::{
-    ensure,
-    views::{View, ViewError},
-};
+use linera_sdk::{ensure, views::View};
 use linera_service::config::{DestinationId, LimitsConfig};
 use linera_storage::Storage;
 use linera_views::{
@@ -146,14 +143,14 @@ where
         self.shared_canonical_state.push(block)
     }
 
-    fn clone(&mut self) -> Result<Self, ExporterError> {
-        Ok(Self {
+    fn clone(&mut self) -> Self {
+        Self {
             storage: self.storage.clone(),
-            shared_canonical_state: self.shared_canonical_state.clone()?,
+            shared_canonical_state: self.shared_canonical_state.clone(),
             blobs_cache: self.blobs_cache.clone(),
             blocks_cache: self.blocks_cache.clone(),
             destination_states: self.destination_states.clone(),
-        })
+        }
     }
 }
 
@@ -206,8 +203,8 @@ where
         self.shared_storage.destination_states.load_state(id)
     }
 
-    pub(crate) fn clone(&mut self) -> Result<Self, ExporterError> {
-        Ok(ExporterStorage::new(self.shared_storage.clone()?))
+    pub(crate) fn clone(&mut self) -> Self {
+        ExporterStorage::new(self.shared_storage.clone())
     }
 
     pub(crate) fn get_latest_index(&self) -> usize {
@@ -244,7 +241,7 @@ where
 
         let mut shared_storage =
             SharedStorage::new(storage, canonical_state, destination_states, limits);
-        let exporter_storage = ExporterStorage::new(shared_storage.clone()?);
+        let exporter_storage = ExporterStorage::new(shared_storage.clone());
 
         Ok((
             Self {
@@ -426,13 +423,13 @@ where
         }
     }
 
-    fn clone(&mut self) -> Result<Self, ViewError> {
-        Ok(Self {
+    fn clone(&mut self) -> Self {
+        Self {
             count: self.count,
             state_cache: self.state_cache.clone(),
             state_updates_buffer: self.state_updates_buffer.clone(),
             state_context: self.state_context.clone_unchecked(),
-        })
+        }
     }
 
     /// Returns the latest index of the canonical state.