Show locked; filter by weight; fetch all missing senders. (#4764)

## Motivation

It's sometimes useful to see the current locked block of each validator,
e.g. when debugging why a chain isn't making progress.

It's also helpful to focus on only the validators with a lot of voting
weight, since they matter most in that case.

For proposals we learn about from validators, we only fetch one missing
sender block.

## Proposal

Show some information about the locking block, if present. Add a
`--min-votes` option. Fetch _all_ missing sender blocks.

## Test Plan

I'm using this for debugging on `testnet_conway`. With the fix for
fetching missing senders I managed to get the locked block into my local
node's chain manager.

## Release Plan

- These changes should be ported to `testnet_conway` and released in a
new SDK.

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: afck

CLI.md

@@ -479,11 +479,12 @@ Show the version and genesis config hash of a new validator, and print a warning
 
 Show the current set of validators for a chain. Also print some information about the given chain while we are at it
 
-**Usage:** `linera query-validators [CHAIN_ID]`
+**Usage:** `linera query-validators [CHAIN_ID] [MIN_VOTES]`
 
 ###### **Arguments:**
 
 * `<CHAIN_ID>` — The chain to query. If omitted, query the default chain of the wallet
+* `<MIN_VOTES>` — Skip validators with less voting weight that this
 
 
 

linera-client/src/client_context.rs

@@ -11,7 +11,7 @@ use linera_base::{
     ownership::ChainOwnership,
     time::{Duration, Instant},
 };
-use linera_chain::types::ConfirmedBlockCertificate;
+use linera_chain::{manager::LockingBlock, types::ConfirmedBlockCertificate};
 use linera_core::{
     client::{ChainClient, Client, ListeningMode},
     data_types::{ChainInfo, ChainInfoQuery, ClientOutcome},
@@ -179,6 +179,24 @@ impl ValidatorQueryResults {
                 }) {
                     println!("Round: {}", info.manager.current_round);
                 }
+                if let Some(locking) = &info.manager.requested_locking {
+                    match &**locking {
+                        LockingBlock::Fast(proposal) => {
+                            println!(
+                                "Locking fast block from {}",
+                                proposal.content.block.timestamp
+                            );
+                        }
+                        LockingBlock::Regular(validated) => {
+                            println!(
+                                "Locking block {} in {} from {}",
+                                validated.hash(),
+                                validated.round,
+                                validated.block().header.timestamp
+                            );
+                        }
+                    }
+                }
             }
             Err(err) => println!("Error getting chain info: {err}"),
         }
@@ -702,7 +720,7 @@ impl<Env: Environment, W: Persist<Target = Wallet>> ClientContext<Env, W> {
         node: &impl ValidatorNode,
         chain_id: ChainId,
     ) -> Result<ChainInfo, Error> {
-        let query = ChainInfoQuery::new(chain_id);
+        let query = ChainInfoQuery::new(chain_id).with_manager_values();
         match node.handle_chain_info_query(query).await {
             Ok(response) => {
                 debug!(
@@ -767,7 +785,7 @@ impl<Env: Environment, W: Persist<Target = Wallet>> ClientContext<Env, W> {
             .genesis_config_hash);
         let chain_info = self
             .make_chain_client(chain_id)
-            .chain_info()
+            .chain_info_with_manager_values()
             .await
             .map(|info| *info)
             .map_err(|e| e.into());

linera-core/src/client/mod.rs

@@ -1124,6 +1124,12 @@ impl<Env: Environment> Client<Env> {
             }
         }
 
+        if certificates.is_empty() {
+            self.local_node
+                .retry_pending_cross_chain_requests(sender_chain_id)
+                .await?;
+        }
+
         // Process certificates in ascending block height order (BTreeMap keeps them sorted).
         for certificate in certificates.into_values() {
             self.receive_sender_certificate(
@@ -1335,7 +1341,7 @@ impl<Env: Environment> Client<Env> {
                         }
                     }
                 }
-                if let LocalNodeError::WorkerError(WorkerError::ChainError(chain_err)) = &err {
+                while let LocalNodeError::WorkerError(WorkerError::ChainError(chain_err)) = &err {
                     if let ChainError::MissingCrossChainUpdate {
                         chain_id,
                         origin,
@@ -1357,8 +1363,10 @@ impl<Env: Environment> Client<Env> {
                         {
                             err = new_err;
                         } else {
-                            continue;
+                            continue 'proposal_loop;
                         }
+                    } else {
+                        break;
                     }
                 }
 
@@ -1965,7 +1973,7 @@ impl<Env: Environment> ChainClient<Env> {
 
     /// Obtains the basic `ChainInfo` data for the local chain, with chain manager values.
     #[instrument(level = "trace")]
-    async fn chain_info_with_manager_values(&self) -> Result<Box<ChainInfo>, LocalNodeError> {
+    pub async fn chain_info_with_manager_values(&self) -> Result<Box<ChainInfo>, LocalNodeError> {
         let query = ChainInfoQuery::new(self.chain_id)
             .with_manager_values()
             .with_committees();

linera-service/src/cli/command.rs

@@ -350,6 +350,8 @@ pub enum ClientCommand {
     QueryValidators {
         /// The chain to query. If omitted, query the default chain of the wallet.
         chain_id: Option<ChainId>,
+        /// Skip validators with less voting weight that this.
+        min_votes: Option<u64>,
     },
 
     /// Synchronizes a validator with the local state of chains.

linera-service/src/cli/main.rs

@@ -452,7 +452,10 @@ impl Runnable for Job {
                 }
             }
 
-            QueryValidators { chain_id } => {
+            QueryValidators {
+                chain_id,
+                min_votes,
+            } => {
                 let mut context =
                     options.create_client_context(storage, wallet, signer.into_value());
                 let chain_id = chain_id.unwrap_or_else(|| context.default_chain());
@@ -470,6 +473,9 @@ impl Runnable for Job {
                 let node_provider = context.make_node_provider();
                 let mut validator_results = Vec::new();
                 for (name, state) in committee.validators() {
+                    if min_votes.is_some_and(|votes| state.votes < votes) {
+                        continue; // Skip validator with little voting weight.
+                    }
                     let address = &state.network_address;
                     let node = node_provider.make_node(address)?;
                     let results = context