[testnet] Downgrade log levels; make --min-votes named. (#4837, #4838) (#4840)

Backport of #4838 and #4837.

## Motivation

We have several WARN- and ERROR-level logs that can occur during normal
operations, without a faulty validity threshold among the validators.

`query-validators` allows filtering by weight. The minimum voting weight
is a positional argument, which is confusing and less explicit.

## Proposal

Downgrade the logs to INFO. Make `--min-votes` a named option.

## Test Plan

(Only log level changes.)

## Release Plan

- These changes should be backported to `testnet_conway`, then
    - be released in a new SDK. (Low priority.)

## Links

- PRs to main: #4837, #4838
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: afck

CLI.md

@@ -462,12 +462,15 @@ Show the version and genesis config hash of a new validator, and print a warning
 
 Show the current set of validators for a chain. Also print some information about the given chain while we are at it
 
-**Usage:** `linera query-validators [CHAIN_ID] [MIN_VOTES]`
+**Usage:** `linera query-validators [OPTIONS] [CHAIN_ID]`
 
 ###### **Arguments:**
 
 * `<CHAIN_ID>` — The chain to query. If omitted, query the default chain of the wallet
-* `<MIN_VOTES>` — Skip validators with less voting weight that this
+
+###### **Options:**
+
+* `--min-votes <MIN_VOTES>` — Skip validators with less voting weight that this
 
 
 

linera-core/src/client/mod.rs

@@ -292,7 +292,7 @@ impl<Env: Environment> Client<Env> {
                 .download_certificates_from(&remote_node, chain_id, target_next_block_height)
                 .await
             {
-                Err(err) => warn!(
+                Err(err) => info!(
                     "Failed to download certificates from validator {:?}: {err}",
                     remote_node.public_key
                 ),
@@ -1126,7 +1126,7 @@ impl<Env: Environment> Client<Env> {
                             {
                                 Ok(content) => content,
                                 Err(err) => {
-                                    warn!(
+                                    info!(
                                         "Skipping proposal from {owner} and validator {} at \
                                         height {}; failed to download {blob_id}: {err}",
                                         remote_node.public_key, local_info.next_block_height
@@ -3132,7 +3132,7 @@ impl<Env: Environment> ChainClient<Env> {
         if let Some(round_timeout) = info.manager.round_timeout {
             if round_timeout <= self.storage_client().clock().current_time() {
                 if let Err(e) = self.request_leader_timeout().await {
-                    warn!("Failed to obtain a timeout certificate: {}", e);
+                    debug!("Failed to obtain a timeout certificate: {}", e);
                 } else {
                     info = self.chain_info_with_manager_values().await?;
                 }
@@ -3816,7 +3816,7 @@ impl<Env: Environment> ChainClient<Env> {
                     )
                     .await?;
                 if self.local_next_height_to_receive(origin).await? <= height {
-                    warn!(
+                    info!(
                         chain_id = %self.chain_id,
                         "NewIncomingBundle: Fail to synchronize new message after notification"
                     );
@@ -3868,7 +3868,7 @@ impl<Env: Environment> ChainClient<Env> {
                     return Ok(());
                 };
                 if (info.next_block_height, info.manager.current_round) < (height, round) {
-                    error!(
+                    info!(
                         chain_id = %self.chain_id,
                         "NewRound: Fail to synchronize new block after notification"
                     );
@@ -4001,7 +4001,7 @@ impl<Env: Environment> ChainClient<Env> {
             })
             .filter_map(move |result| async move {
                 if let Err(error) = &result {
-                    warn!(?error, "Could not connect to validator {public_key}");
+                    info!(?error, "Could not connect to validator {public_key}");
                 } else {
                     debug!("Connected to validator {public_key}");
                 }
@@ -4023,7 +4023,7 @@ impl<Env: Environment> ChainClient<Env> {
                         )
                         .await
                     {
-                        tracing::warn!(
+                        tracing::info!(
                             chain_id = %this.chain_id,
                             validator_public_key = ?remote_node.public_key,
                             ?notification,

linera-core/src/remote_node.rs

@@ -22,7 +22,7 @@ use linera_chain::{
     },
 };
 use rand::seq::SliceRandom as _;
-use tracing::{debug, instrument, warn};
+use tracing::{debug, info, instrument};
 
 use crate::{
     data_types::{ChainInfo, ChainInfoQuery, ChainInfoResponse},
@@ -186,7 +186,7 @@ impl<N: ValidatorNode> RemoteNode<N> {
     ) -> Result<ConfirmedBlockCertificate, NodeError> {
         let certificate = self.node.blob_last_used_by_certificate(blob_id).await?;
         if !certificate.block().requires_or_creates_blob(&blob_id) {
-            warn!(
+            info!(
                 "Got invalid last used by certificate for blob {} from validator {}",
                 blob_id, self.public_key
             );
@@ -338,13 +338,13 @@ impl<N: ValidatorNode> RemoteNode<N> {
         let public_key = &self.public_key;
         for blob_id in blob_ids {
             if !required.contains(blob_id) {
-                warn!("validator {public_key} requested blob {blob_id:?} but it is not required");
+                info!("validator {public_key} requested blob {blob_id:?} but it is not required");
                 return Err(NodeError::UnexpectedEntriesInBlobsNotFound);
             }
         }
         let unique_missing_blob_ids = blob_ids.iter().copied().collect::<HashSet<_>>();
         if blob_ids.len() > unique_missing_blob_ids.len() {
-            warn!("blobs requested by validator {public_key} contain duplicates");
+            info!("blobs requested by validator {public_key} contain duplicates");
             return Err(NodeError::DuplicatesInBlobsNotFound);
         }
         Ok(())

linera-service/src/cli/command.rs

@@ -344,6 +344,7 @@ pub enum ClientCommand {
         /// The chain to query. If omitted, query the default chain of the wallet.
         chain_id: Option<ChainId>,
         /// Skip validators with less voting weight that this.
+        #[arg(long)]
         min_votes: Option<u64>,
     },