Fix consensus issues related to timeouts, rounds, ownership. (Backport #4688) (#4701)

## Motivation

#4688 fixes several
consensus issues, some of which we already observed in Testnet Conway.

## Proposal

Backport the fixes.

## Test Plan

CI
A regression test was added.

## Release Plan

- These changes should be released in a new SDK, and
    - be released in a validator hotfix.

## Links

- PR for main: #4688
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

---------

Co-authored-by: deuszx <[email protected]>

Author: afck

Cargo.lock

@@ -328,6 +328,7 @@ native-fungible = { path = "./examples/native-fungible" }
 non-fungible = { path = "./examples/non-fungible" }
 publish-read-data-blob = { path = "./examples/publish-read-data-blob" }
 social = { path = "./examples/social" }
+time-expiry = { path = "./examples/time-expiry" }
 
 [workspace.dependencies.aws-config]
 default-features = false

Cargo.toml

@@ -22,6 +22,7 @@ members = [
     "publish-read-data-blob",
     "rfq",
     "social",
+    "time-expiry",
 ]
 
 [workspace.dependencies]

examples/Cargo.lock

@@ -0,0 +1,17 @@
+[package]
+name = "time-expiry"
+version = "0.1.0"
+authors = ["Linera <[email protected]>"]
+edition = "2021"
+
+[dependencies]
+linera-sdk.workspace = true
+serde.workspace = true
+
+[[bin]]
+name = "time_expiry_contract"
+path = "src/contract.rs"
+
+[[bin]]
+name = "time_expiry_service"
+path = "src/service.rs"

examples/Cargo.toml

@@ -0,0 +1,65 @@
+// Copyright (c) Zefchain Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+#![cfg_attr(target_arch = "wasm32", no_main)]
+
+mod state;
+
+use linera_sdk::{
+    linera_base_types::WithContractAbi,
+    views::{RootView, View},
+    Contract, ContractRuntime,
+};
+use time_expiry::{TimeExpiryAbi, TimeExpiryOperation};
+
+use self::state::TimeExpiryState;
+
+pub struct TimeExpiryContract {
+    state: TimeExpiryState,
+    runtime: ContractRuntime<Self>,
+}
+
+linera_sdk::contract!(TimeExpiryContract);
+
+impl WithContractAbi for TimeExpiryContract {
+    type Abi = TimeExpiryAbi;
+}
+
+impl Contract for TimeExpiryContract {
+    type Message = ();
+    type InstantiationArgument = ();
+    type Parameters = ();
+    type EventValue = ();
+
+    async fn load(runtime: ContractRuntime<Self>) -> Self {
+        let state = TimeExpiryState::load(runtime.root_view_storage_context())
+            .await
+            .expect("Failed to load state");
+        TimeExpiryContract { state, runtime }
+    }
+
+    async fn instantiate(&mut self, _argument: ()) {
+        self.runtime.application_parameters();
+    }
+
+    async fn execute_operation(&mut self, operation: TimeExpiryOperation) {
+        let TimeExpiryOperation::ExpireAfter(delta) = operation;
+
+        // Get the current block timestamp.
+        let block_timestamp = self.runtime.system_time();
+
+        // Calculate the expiry timestamp.
+        let expiry_timestamp = block_timestamp.saturating_add(delta);
+
+        // Assert that the validation happens before the expiry timestamp.
+        self.runtime.assert_before(expiry_timestamp);
+    }
+
+    async fn execute_message(&mut self, _message: ()) {
+        panic!("TimeExpiry application doesn't support any cross-chain messages");
+    }
+
+    async fn store(mut self) {
+        self.state.save().await.expect("Failed to save state");
+    }
+}

examples/time-expiry/Cargo.toml

@@ -0,0 +1,25 @@
+// Copyright (c) Zefchain Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+/*! ABI of the Time Expiry Test Application */
+
+use linera_sdk::linera_base_types::{ContractAbi, ServiceAbi, TimeDelta};
+use serde::{Deserialize, Serialize};
+
+pub struct TimeExpiryAbi;
+
+#[derive(Debug, Deserialize, Serialize)]
+pub enum TimeExpiryOperation {
+    /// Expire the operation after the given time delta from block timestamp.
+    ExpireAfter(TimeDelta),
+}
+
+impl ContractAbi for TimeExpiryAbi {
+    type Operation = TimeExpiryOperation;
+    type Response = ();
+}
+
+impl ServiceAbi for TimeExpiryAbi {
+    type Query = ();
+    type QueryResponse = ();
+}

examples/time-expiry/src/contract.rs

@@ -0,0 +1,35 @@
+// Copyright (c) Zefchain Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+#![cfg_attr(target_arch = "wasm32", no_main)]
+
+mod state;
+
+use linera_sdk::{linera_base_types::WithServiceAbi, views::View, Service, ServiceRuntime};
+use time_expiry::TimeExpiryAbi;
+
+use self::state::TimeExpiryState;
+
+pub struct TimeExpiryService {
+    #[allow(dead_code)]
+    state: TimeExpiryState,
+}
+
+linera_sdk::service!(TimeExpiryService);
+
+impl WithServiceAbi for TimeExpiryService {
+    type Abi = TimeExpiryAbi;
+}
+
+impl Service for TimeExpiryService {
+    type Parameters = ();
+
+    async fn new(runtime: ServiceRuntime<Self>) -> Self {
+        let state = TimeExpiryState::load(runtime.root_view_storage_context())
+            .await
+            .expect("Failed to load state");
+        TimeExpiryService { state }
+    }
+
+    async fn handle_query(&self, _query: ()) {}
+}

examples/time-expiry/src/lib.rs

@@ -0,0 +1,12 @@
+// Copyright (c) Zefchain Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+use linera_sdk::views::{linera_views, RegisterView, RootView, ViewStorageContext};
+
+/// The application state (empty for this test fixture, but needs at least one field).
+#[derive(RootView)]
+#[view(context = ViewStorageContext)]
+pub struct TimeExpiryState {
+    /// A dummy field since RootView requires at least one field.
+    pub dummy: RegisterView<u64>,
+}

examples/time-expiry/src/service.rs

@@ -178,6 +178,11 @@ impl ChainOwnership {
         };
         Some(next_round)
     }
+
+    /// Returns whether the given owner is the only owner, and a super owner.
+    pub fn is_single_super_owner(&self, owner: &AccountOwner) -> bool {
+        self.owners.is_empty() && self.super_owners.len() == 1 && self.super_owners.contains(owner)
+    }
 }
 
 /// Errors that can happen when attempting to close a chain.