Update to Rust version 1.85 (#3622)

## Motivation

The code was previously stuck with Rust version 1.81 because newer
versions would cause applications to fail to load (#3196). However, with
that issue fixed ([PR
#1](linera-io/parity-wasm#1)), it is now
possible to update the code to the latest stable Rust version.

## Proposal

Update the minimum supported Rust version to 1.85, and apply the
suggestions from the newer versions of the compiler and the linter.

Also update the nightly version used in CI to a newer version so that
it's not so far behind the stable version to the point it causes
compilation issues.

## Test Plan

CI should catch any regressions.

## Release Plan

- These changes follow the usual release cycle, because it's backwards
compatible and allows downstream dependencies to use newer Rust
versions.

## Links

- Future work: update to use the new Rust 2024 edition.
- Closes #3196 
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: jvff

Cargo.lock

@@ -204,10 +204,10 @@ wasm-bindgen = "0.2.92"
 wasm-bindgen-futures = "0.4.42"
 wasm-bindgen-test = "0.3.42"
 wasm-encoder = "0.24.1"
-wasm-instrument = "0.4.0"
+wasm-instrument = { package = "linera-wasm-instrument", version = "0.4.0-linera.1" }
 wasm_thread = "0.3.0"
-wasmer = { package = "linera-wasmer", version = "4.4.0-linera.6", default-features = false }
-wasmer-compiler-singlepass = { package = "linera-wasmer-compiler-singlepass", version = "4.4.0-linera.6", default-features = false, features = [
+wasmer = { package = "linera-wasmer", version = "4.4.0-linera.7", default-features = false }
+wasmer-compiler-singlepass = { package = "linera-wasmer-compiler-singlepass", version = "4.4.0-linera.7", default-features = false, features = [
     "std",
     "unwind",
     "avx",

Cargo.toml

@@ -48,7 +48,7 @@ async fn collect_pledges() {
     let (token_id, backers) = fungible::create_with_accounts(
         &validator,
         fungible_module_id,
-        iter::repeat(initial_amount).take(3),
+        iter::repeat_n(initial_amount, 3),
     )
     .await;
 
@@ -150,7 +150,7 @@ async fn cancel_successful_campaign() {
     let (token_id, backers) = fungible::create_with_accounts(
         &validator,
         fungible_module_id,
-        iter::repeat(initial_amount).take(3),
+        iter::repeat_n(initial_amount, 3),
     )
     .await;
 

examples/Cargo.lock

@@ -114,7 +114,7 @@ pub fn parse_version_message(message: &str) -> String {
         .unwrap_or_default()
         .trim()
         .split(' ')
-        .last()
+        .next_back()
         .expect("splitting strings gives non-empty lists")
         .to_string()
 }

examples/crowd-funding/tests/campaign_lifecycle.rs

@@ -276,7 +276,7 @@ impl WitStore for Ed25519PublicKey {
     }
 }
 
-impl<'de> BcsHashable<'de> for Ed25519PublicKey {}
+impl BcsHashable<'_> for Ed25519PublicKey {}
 
 impl Ed25519Signature {
     /// Computes a signature.
@@ -436,7 +436,7 @@ mod tests {
         #[derive(Debug, Serialize, Deserialize)]
         struct Foo(String);
 
-        impl<'de> BcsSignable<'de> for Foo {}
+        impl BcsSignable<'_> for Foo {}
 
         let key1 = Ed25519SecretKey::generate();
         let addr1 = key1.public();

linera-base/src/command.rs

@@ -75,7 +75,7 @@ impl io::Write for Keccak256Ext {
 #[cfg_attr(with_testing, derive(Default))]
 pub struct CryptoHashVec(pub Vec<CryptoHash>);
 
-impl<'de> BcsHashable<'de> for CryptoHashVec {}
+impl BcsHashable<'_> for CryptoHashVec {}
 
 impl Serialize for CryptoHash {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
@@ -145,7 +145,7 @@ impl From<CryptoHash> for [u64; 4] {
 impl fmt::Display for CryptoHash {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let prec = f.precision().unwrap_or(self.0.len() * 2);
-        hex::encode(&self.0[..((prec + 1) / 2)]).fmt(f)
+        hex::encode(&self.0[..prec.div_ceil(2)]).fmt(f)
     }
 }
 

linera-base/src/crypto/ed25519.rs

@@ -344,7 +344,7 @@ impl TestString {
 }
 
 #[cfg(with_testing)]
-impl<'de> BcsSignable<'de> for TestString {}
+impl BcsSignable<'_> for TestString {}
 
 /// Reads the `bytes` as four little-endian unsigned 64-bit integers and returns them.
 pub(crate) fn le_bytes_to_u64_array(bytes: &[u8]) -> [u64; 4] {

linera-base/src/crypto/hash.rs

@@ -192,7 +192,7 @@ impl fmt::Debug for Secp256k1PublicKey {
     }
 }
 
-impl<'de> BcsHashable<'de> for Secp256k1PublicKey {}
+impl BcsHashable<'_> for Secp256k1PublicKey {}
 
 impl WitType for Secp256k1PublicKey {
     const SIZE: u32 = <(u64, u64, u64, u64, u8) as WitType>::SIZE;
@@ -501,7 +501,7 @@ mod tests {
         #[derive(Debug, Serialize, Deserialize)]
         struct Foo(String);
 
-        impl<'de> BcsSignable<'de> for Foo {}
+        impl BcsSignable<'_> for Foo {}
 
         let keypair1 = Secp256k1KeyPair::generate();
         let keypair2 = Secp256k1KeyPair::generate();