Move large_futures config to Cargo.toml; deny in more crates. (#4521)

afck · web-flow · commit 7bc5c4c23197 · 2025-09-09T11:56:34.000Z
## Motivation Large futures increase the risk of stack overflows, which is why we `#[deny(clippy::large_futures)]` in several places. However, this covers only a small fraction of the code. ## Proposal Move the lint config to `Cargo.toml` and use workspace configuration in other crates. Fix large future warnings in some places. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
diff --git a/Cargo.toml b/Cargo.toml
@@ -357,3 +357,6 @@ branch = "post-message"
 
 [workspace.metadata.spellcheck]
 config = "spellcheck-cfg.toml"
+
+[workspace.lints.clippy]
+large_futures = "deny"
diff --git a/linera-base/Cargo.toml b/linera-base/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 metrics = ["prometheus"]
 reqwest = ["dep:reqwest"]
diff --git a/linera-base/src/lib.rs b/linera-base/src/lib.rs
@@ -6,7 +6,6 @@
 //! applications (compiled from Rust to Wasm).
 
 #![deny(missing_docs)]
-#![deny(clippy::large_futures)]
 #![allow(async_fn_in_trait)]
 
 use std::fmt;
diff --git a/linera-chain/Cargo.toml b/linera-chain/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 metrics = ["prometheus", "linera-views/metrics", "linera-execution/metrics"]
 test = [
diff --git a/linera-chain/src/lib.rs b/linera-chain/src/lib.rs
@@ -3,8 +3,6 @@
 
 //! This module manages the state of a Linera chain, including cross-chain communication.
 
-#![deny(clippy::large_futures)]
-
 pub mod block;
 mod certificate;
 
diff --git a/linera-client/src/lib.rs b/linera-client/src/lib.rs
@@ -4,7 +4,6 @@
 //! This module provides a convenient library for writing a Linera client application.
 
 #![recursion_limit = "256"]
-#![deny(clippy::large_futures)]
 #![allow(async_fn_in_trait)]
 
 pub mod chain_listener;
diff --git a/linera-core/Cargo.toml b/linera-core/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 wasmer = ["linera-execution/wasmer", "linera-storage/wasmer"]
 wasmtime = ["linera-execution/wasmtime", "linera-storage/wasmtime"]
diff --git a/linera-core/src/lib.rs b/linera-core/src/lib.rs
@@ -5,7 +5,6 @@
 //! This module defines the core Linera protocol.
 
 #![recursion_limit = "256"]
-#![deny(clippy::large_futures)]
 
 mod chain_worker;
 pub mod client;
diff --git a/linera-ethereum/Cargo.toml b/linera-ethereum/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 features = ["ethereum"]
 
diff --git a/linera-execution/Cargo.toml b/linera-execution/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 test = ["tokio/macros", "linera-base/test", "linera-views/test", "proptest"]
 revm = [
diff --git a/linera-execution/src/lib.rs b/linera-execution/src/lib.rs
@@ -4,8 +4,6 @@
 //! This module manages the execution of the system application and the user applications in a
 //! Linera chain.
 
-#![deny(clippy::large_futures)]
-
 pub mod committee;
 pub mod evm;
 mod execution;
diff --git a/linera-explorer/Cargo.toml b/linera-explorer/Cargo.toml
@@ -9,6 +9,9 @@ homepage = "https://linera.dev"
 documentation = "https://docs.rs/linera-explorer/latest/linera_explorer/"
 license = "Apache-2.0"
 
+[lints]
+workspace = true
+
 [lib]
 crate-type = ["cdylib"]
 
diff --git a/linera-faucet/client/Cargo.toml b/linera-faucet/client/Cargo.toml
@@ -11,6 +11,9 @@ homepage.workspace = true
 license.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 linera-base.workspace = true
 linera-client.workspace = true
diff --git a/linera-faucet/server/Cargo.toml b/linera-faucet/server/Cargo.toml
@@ -11,6 +11,9 @@ homepage.workspace = true
 license.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-machete]
 ignored = ["prometheus"]
 
diff --git a/linera-indexer/example/Cargo.toml b/linera-indexer/example/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["rocksdb"]
 rocksdb = ["linera-indexer/rocksdb", "linera-indexer-plugins/rocksdb"]
diff --git a/linera-indexer/graphql-client/Cargo.toml b/linera-indexer/graphql-client/Cargo.toml
@@ -10,6 +10,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 graphql_client = { version = "0.13", features = ["reqwest-rustls"] }
 linera-base.workspace = true
diff --git a/linera-indexer/lib/Cargo.toml b/linera-indexer/lib/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["rocksdb"]
 rocksdb = ["linera-views/rocksdb", "linera-core/rocksdb"]
diff --git a/linera-indexer/plugins/Cargo.toml b/linera-indexer/plugins/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["rocksdb"]
 rocksdb = ["linera-views/rocksdb", "linera-indexer/rocksdb"]
diff --git a/linera-metrics/Cargo.toml b/linera-metrics/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow.workspace = true
 axum.workspace = true
diff --git a/linera-persistent/Cargo.toml b/linera-persistent/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 fs = ["fs-err", "fs4"]
 indexed-db = ["web", "indexed_db_futures", "serde-wasm-bindgen", "gloo-utils"]
diff --git a/linera-rpc/Cargo.toml b/linera-rpc/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 test = [
     "linera-base/test",
diff --git a/linera-rpc/src/lib.rs b/linera-rpc/src/lib.rs
@@ -4,7 +4,6 @@
 //! This module provides network abstractions and the data schemas for remote procedure
 //! calls (RPCs) in the Linera protocol.
 
-#![deny(clippy::large_futures)]
 // `tracing::instrument` is not compatible with this nightly Clippy lint
 #![allow(unknown_lints)]
 
diff --git a/linera-sdk-derive/Cargo.toml b/linera-sdk-derive/Cargo.toml
@@ -9,6 +9,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 proc-macro = true
 
diff --git a/linera-sdk/Cargo.toml b/linera-sdk/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 development = ["linera-sdk"]
 
diff --git a/linera-sdk/src/lib.rs b/linera-sdk/src/lib.rs
@@ -24,8 +24,6 @@
 //! The [`examples`](https://github.com/linera-io/linera-protocol/tree/main/examples)
 //! directory contains some example applications.
 
-#![deny(missing_docs)]
-
 #[macro_use]
 pub mod util;
 
diff --git a/linera-sdk/src/test/validator.rs b/linera-sdk/src/test/validator.rs
@@ -162,7 +162,7 @@ impl TestValidator {
         ModuleId<Abi, Parameters, InstantiationArgument>,
     ) {
         let validator = TestValidator::new().await;
-        let publisher = validator.new_chain().await;
+        let publisher = Box::pin(validator.new_chain()).await;
 
         let module_id = publisher.publish_current_module().await;
 
diff --git a/linera-service-graphql-client/Cargo.toml b/linera-service-graphql-client/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["rocksdb"]
 rocksdb = ["linera-service/rocksdb"]
diff --git a/linera-service/Cargo.toml b/linera-service/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 ethereum = []
 default = ["wasmer", "rocksdb", "storage-service"]
diff --git a/linera-service/benches/transfers.rs b/linera-service/benches/transfers.rs
@@ -28,11 +28,11 @@ fn cross_chain_native_token_transfers(criterion: &mut Criterion) {
                 let mut total_time = Duration::ZERO;
 
                 for _ in 0..iterations {
-                    let chains = setup_native_token_balances(
+                    let chains = Box::pin(setup_native_token_balances(
                         chain_count,
                         accounts_per_chain,
                         transfers_per_account,
-                    )
+                    ))
                     .await;
 
                     let transfers = prepare_transfers(chains, transfers_per_account);
diff --git a/linera-service/src/cli/main.rs b/linera-service/src/cli/main.rs
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #![recursion_limit = "256"]
-#![deny(clippy::large_futures)]
 
 use std::{
     collections::{BTreeMap, BTreeSet},
diff --git a/linera-service/src/cli/mod.rs b/linera-service/src/cli/mod.rs
@@ -3,7 +3,5 @@
 
 //! Helper module for the Linera CLI binary.
 
-#![deny(clippy::large_futures)]
-
 pub mod command;
 pub mod net_up_utils;
diff --git a/linera-service/src/exporter/runloops/validator_exporter.rs b/linera-service/src/exporter/runloops/validator_exporter.rs
@@ -186,10 +186,11 @@ where
         tracing::info!(?block_id, "dispatching block");
         #[cfg(with_metrics)]
         let start = linera_base::time::Instant::now();
-        match self
-            .node
-            .handle_confirmed_certificate(certificate, delivery)
-            .await
+        match Box::pin(
+            self.node
+                .handle_confirmed_certificate(certificate, delivery),
+        )
+        .await
         {
             Ok(_) => {
                 #[cfg(with_metrics)]
diff --git a/linera-service/src/lib.rs b/linera-service/src/lib.rs
@@ -4,8 +4,6 @@
 
 //! This module provides the executables needed to operate a Linera service, including a placeholder wallet acting as a GraphQL service for user interfaces.
 
-#![deny(clippy::large_futures)]
-
 pub mod cli;
 pub mod cli_wrappers;
 pub mod config;
diff --git a/linera-service/src/proxy/main.rs b/linera-service/src/proxy/main.rs
@@ -1,8 +1,6 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
-#![deny(clippy::large_futures)]
-
 use std::{net::SocketAddr, path::PathBuf, time::Duration};
 
 use anyhow::{anyhow, bail, ensure, Result};
diff --git a/linera-service/src/server.rs b/linera-service/src/server.rs
@@ -2,8 +2,6 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
-#![deny(clippy::large_futures)]
-
 use std::{
     borrow::Cow,
     num::NonZeroU16,
diff --git a/linera-storage-service/Cargo.toml b/linera-storage-service/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 metrics = ["linera-views/metrics"]
 rocksdb = ["linera-views/rocksdb"]
diff --git a/linera-storage-service/src/lib.rs b/linera-storage-service/src/lib.rs
@@ -4,8 +4,6 @@
 //! This module provides a shared key-value store server based on the RocksDB store and the in-memory store of `linera-views`.
 //! The corresponding client implements the `KeyValueStore` and `KeyValueDatabase` traits.
 
-#![deny(clippy::large_futures)]
-
 pub mod key_value_store {
     tonic::include_proto!("key_value_store.v1");
 }
diff --git a/linera-storage/Cargo.toml b/linera-storage/Cargo.toml
@@ -11,6 +11,9 @@ license.workspace = true
 repository.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 revm = ["linera-execution/revm"]
 test = ["linera-execution/test", "linera-views/test"]
diff --git a/linera-storage/src/lib.rs b/linera-storage/src/lib.rs
@@ -3,8 +3,6 @@
 
 //! This module defines the storage abstractions for individual chains and certificates.
 
-#![deny(clippy::large_futures)]
-
 mod db_storage;
 
 use std::{collections::BTreeMap, ops::RangeInclusive, sync::Arc};
diff --git a/linera-summary/Cargo.toml b/linera-summary/Cargo.toml
@@ -11,6 +11,9 @@ homepage.workspace = true
 license.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow.workspace = true
 clap.workspace = true
diff --git a/linera-summary/src/lib.rs b/linera-summary/src/lib.rs
@@ -3,7 +3,6 @@
 
 //! This crate provides the internal tool to summarize performance changes in PRs.
 
-#![deny(clippy::large_futures)]
 #![allow(missing_docs)]
 
 pub mod ci_runtime_comparison;
diff --git a/linera-views-derive/Cargo.toml b/linera-views-derive/Cargo.toml
diff --git a/linera-views/Cargo.toml b/linera-views/Cargo.toml
diff --git a/linera-views/src/lib.rs b/linera-views/src/lib.rs
diff --git a/linera-views/tests/views_tests.rs b/linera-views/tests/views_tests.rs
diff --git a/linera-witty-macros/Cargo.toml b/linera-witty-macros/Cargo.toml
diff --git a/linera-witty/Cargo.toml b/linera-witty/Cargo.toml
