Skip to content

Commit 808c498

Browse files
authored
Break out of the proposal staging loop if rejected message fails. (#4890)
## Motivation The staging loop loops forever if a rejected message fails. (It sets it to `Rejected`, which it already is, and tries again!) After the `FLAG_FREE_REJECT` activation, this shouldn't be reachable anymore, but it makes sense to detect this case anyway. ## Proposal Break out of the loop if a rejected message fails. ## Test Plan I tried it locally. ## Release Plan - Release in a new SDK. (Not urgent.) ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
1 parent e93bfc1 commit 808c498

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

linera-core/src/client/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1314,6 +1314,9 @@ impl<Env: Environment> Client<Env> {
13141314
"Protected incoming message failed to execute locally"
13151315
)
13161316
);
1317+
if message.action == MessageAction::Reject {
1318+
return result;
1319+
}
13171320
// Reject the faulty message from the block and continue.
13181321
// TODO(#1420): This is potentially a bit heavy-handed for
13191322
// retryable errors.

0 commit comments

Comments
 (0)