Skip to content

Commit 872f25c

Browse files
deuszxTwey
andauthored
TypeScript signer is a library/SDK (#4105)
## Motivation When building `linera-web` examples it sometimes happens that the `package-lock.json` of `/signer` is incompatible/out of date. Both signer and web client are used as SDK/libraries so should't have their lock files committed. `linera-web/build.bash` builds the client for the web but it didn't prepare the TypeScript signers which required downstream client to manually trigger that. ## Proposal Signer and linera web client are a library/SDK and as such should not have `package-lock.json` committed. This PR removes that file. Add a line to `build.bash` that prepare signers (build javascript and typescript files). ## Test Plan Manually in `linera-web`. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist) --------- Signed-off-by: deuszx <[email protected]> Co-authored-by: James Kay <[email protected]>
1 parent 7bd2b05 commit 872f25c

File tree

7 files changed

+11
-10419
lines changed

7 files changed

+11
-10419
lines changed

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,8 @@
2626
kubernetes/linera-validator/working/*
2727
node_modules
2828
**/dist/
29+
30+
# Web client and signer are supposed to be used
31+
# as a library, so we don't want to
32+
# include their lock files.
33+
linera-web/**/*-lock.json

linera-web/build.bash

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ wasm-bindgen \
3232
--typescript \
3333
--target web \
3434
--split-linked-modules
35+
36+
cd signer && pnpm prepare

linera-web/pnpm-lock.yaml

Lines changed: 0 additions & 3088 deletions
This file was deleted.

linera-web/pnpm-workspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
packages:
2-
- "signer"
32
- "client"
3+
- "signer"

0 commit comments

Comments
 (0)