linera-persistent: move out of linera-client (#4002)

## Motivation

We'd like to push `persistent` further down the stack (in preparation
for [removing
it](#3974)) so let's
extract it into its own crate for now.

## Proposal

Extract it into a separate crate.

## Test Plan

CI.

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

## Links

- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)

Author: Twey

Cargo.lock

@@ -13,6 +13,7 @@ members = [
     "linera-indexer/graphql-client",
     "linera-indexer/lib",
     "linera-indexer/plugins",
+    "linera-persistent",
     "linera-rpc",
     "linera-sdk",
     "linera-sdk-derive",
@@ -205,11 +206,6 @@ revm-state = { version = "4.0.0", default-features = false, features = [
 rocksdb = "0.21.0"
 ruzstd = "0.7.1"
 scylla = "1.1.0"
-secp256k1 = { version = "0.30.0", default-features = false, features = [
-    "alloc",
-    "rand",
-    "serde",
-] }
 semver = "1.0.22"
 serde = { version = "1.0.197", features = ["derive"] }
 serde-command-opts = "0.1.1"

Cargo.toml

@@ -57,6 +57,7 @@ COPY linera-service-graphql-client linera-service-graphql-client
 COPY linera-storage linera-storage
 COPY linera-storage-service linera-storage-service
 COPY linera-summary linera-summary
+COPY linera-persistent linera-persistent
 COPY linera-version linera-version
 COPY linera-views linera-views
 COPY linera-views-derive linera-views-derive

docker/Dockerfile

@@ -28,7 +28,7 @@ wasmer = [
     "linera-storage/wasmer",
 ]
 wasmtime = ["linera-execution/wasmtime", "linera-storage/wasmtime"]
-fs = ["fs-err", "fs4", "linera-execution/fs"]
+fs = ["fs-err", "fs4", "linera-execution/fs", "linera-persistent/fs"]
 metrics = [
     "linera-base/metrics",
     "linera-chain/metrics",
@@ -41,29 +41,29 @@ web = [
     "dep:web-sys",
     "dep:wasm-bindgen-futures",
     "linera-base/web",
-    "linera-storage/web",
+    "linera-execution/web",
     "linera-chain/web",
     "linera-client/web",
     "linera-core/web",
-    "linera-views/web",
-    "linera-execution/web",
+    "linera-persistent/indexed-db",
     "linera-rpc/web",
+    "linera-storage/web",
+    "linera-views/web",
 ]
 indexed-db = ["web", "indexed_db_futures", "serde-wasm-bindgen", "gloo-utils"]
 web-default = ["web", "wasmer", "indexed-db"]
 
 [dependencies]
 anyhow = { workspace = true, optional = true }
 bcs.workspace = true
-cfg-if.workspace = true
 clap.workspace = true
 crossbeam-channel = { workspace = true, optional = true }
-derive_more = { workspace = true, features = ["deref", "deref_mut"] }
 futures.workspace = true
 linera-base.workspace = true
 linera-chain.workspace = true
 linera-core.workspace = true
 linera-execution.workspace = true
+linera-persistent = { version = "0.15.0", path = "../linera-persistent" }
 linera-rpc.workspace = true
 linera-sdk = { workspace = true, optional = true }
 linera-storage.workspace = true
@@ -73,7 +73,6 @@ num-format = { workspace = true, optional = true }
 prometheus-parse = { workspace = true, optional = true }
 reqwest = { workspace = true, optional = true }
 serde.workspace = true
-serde_json.workspace = true
 thiserror.workspace = true
 thiserror-context.workspace = true
 tokio.workspace = true

linera-client/Cargo.toml

@@ -4,8 +4,6 @@
 fn main() {
     cfg_aliases::cfg_aliases! {
         web: { all(target_arch = "wasm32", feature = "web") },
-        with_persist: { any(feature = "fs", with_indexed_db) },
-        with_indexed_db: { all(web, feature = "indexed-db") },
         with_testing: { any(test, feature = "test") },
         with_metrics: { all(not(target_arch = "wasm32"), feature = "metrics") },
     };

linera-client/build.rs

@@ -21,6 +21,7 @@ use linera_core::{
     node::{CrossChainMessageDelivery, ValidatorNode},
     Environment, JoinSetExt as _,
 };
+use linera_persistent::{Persist, PersistExt as _};
 use linera_rpc::node_provider::{NodeOptions, NodeProvider};
 use linera_version::VersionInfo;
 use thiserror_context::Context;
@@ -57,9 +58,7 @@ use {
 use crate::{
     chain_listener::{self, ClientContext as _, ClientContextExt as _},
     client_options::{ChainOwnershipConfig, ClientContextOptions},
-    error,
-    persistent::{Persist, PersistExt as _},
-    util,
+    error, util,
     wallet::{UserChain, Wallet},
     Error,
 };

linera-client/src/client_context.rs

@@ -12,16 +12,12 @@ use linera_base::{
 use linera_core::{client::BlanketMessagePolicy, DEFAULT_GRACE_PERIOD};
 use linera_execution::ResourceControlPolicy;
 
-#[cfg(any(with_indexed_db, not(with_persist)))]
-use crate::wallet::Wallet;
-use crate::{persistent, util};
+use crate::util;
 
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
     #[error("I/O error: {0}")]
     IoError(#[from] std::io::Error),
-    #[error("no wallet found")]
-    NonexistentWallet,
     #[error("there are {public_keys} public keys but {weights} weights")]
     MisalignedWeights { public_keys: usize, weights: usize },
     #[error("persistence error: {0}")]
@@ -31,10 +27,10 @@ pub enum Error {
 }
 
 #[cfg(feature = "fs")]
-util::impl_from_dynamic!(Error:Persistence, persistent::file::Error);
+util::impl_from_dynamic!(Error:Persistence, linera_persistent::file::Error);
 
-#[cfg(with_indexed_db)]
-util::impl_from_dynamic!(Error:Persistence, persistent::indexed_db::Error);
+#[cfg(web)]
+util::impl_from_dynamic!(Error:Persistence, linera_persistent::indexed_db::Error);
 
 util::impl_from_infallible!(Error);
 
@@ -116,24 +112,6 @@ pub struct ClientContextOptions {
     pub blob_download_timeout: Duration,
 }
 
-#[cfg(with_indexed_db)]
-impl ClientContextOptions {
-    pub async fn wallet(&self) -> Result<persistent::IndexedDb<Wallet>, Error> {
-        persistent::IndexedDb::read("linera-wallet")
-            .await?
-            .ok_or(Error::NonexistentWallet)
-    }
-}
-
-#[cfg(not(with_persist))]
-impl ClientContextOptions {
-    pub async fn wallet(&self) -> Result<persistent::Memory<Wallet>, Error> {
-        #![allow(unreachable_code)]
-        let _wallet = unimplemented!("No persistence backend selected for wallet; please use one of the `fs` or `indexed-db` features");
-        Ok(persistent::Memory::new(_wallet))
-    }
-}
-
 #[derive(Debug, Clone, clap::Args)]
 pub struct ChainOwnershipConfig {
     /// The new super owners.

linera-client/src/client_options.rs

@@ -17,6 +17,7 @@ use linera_execution::{
     committee::{Committee, ValidatorState},
     ResourceControlPolicy,
 };
+use linera_persistent as persistent;
 use linera_rpc::config::{
     ExporterServiceConfig, ValidatorInternalNetworkConfig, ValidatorPublicNetworkConfig,
 };
@@ -37,10 +38,10 @@ pub enum Error {
     NoAdminChain,
 }
 
-use crate::{persistent, util};
+use crate::util;
 
 util::impl_from_dynamic!(Error:Persistence, persistent::memory::Error);
-#[cfg(with_indexed_db)]
+#[cfg(web)]
 util::impl_from_dynamic!(Error:Persistence, persistent::indexed_db::Error);
 #[cfg(feature = "fs")]
 util::impl_from_dynamic!(Error:Persistence, persistent::file::Error);

linera-client/src/config.rs

@@ -5,12 +5,13 @@ use linera_base::{
     crypto::ValidatorPublicKey, data_types::NetworkDescription, identifiers::ChainId,
 };
 use linera_core::node::NodeError;
+use linera_persistent as persistent;
 use linera_version::VersionInfo;
 use thiserror_context::Context;
 
 #[cfg(feature = "benchmark")]
 use crate::benchmark::BenchmarkError;
-use crate::{persistent, util};
+use crate::util;
 
 #[derive(Debug, thiserror::Error)]
 #[non_exhaustive]
@@ -77,5 +78,5 @@ thiserror_context::impl_context!(Error(Inner));
 util::impl_from_dynamic!(Inner:Persistence, persistent::memory::Error);
 #[cfg(feature = "fs")]
 util::impl_from_dynamic!(Inner:Persistence, persistent::file::Error);
-#[cfg(with_indexed_db)]
+#[cfg(web)]
 util::impl_from_dynamic!(Inner:Persistence, persistent::indexed_db::Error);

linera-client/src/error.rs

@@ -12,7 +12,6 @@ pub mod client_context;
 pub mod client_options;
 pub mod config;
 mod error;
-pub mod persistent;
 pub mod util;
 pub mod wallet;