Remove linera-server initialize + simplify CLI options (#4111)

## Motivation

* `linera-server initialize` is redundant with `linera storage
initialize`
* CLI arguments are duplicated in many places.
* `StorageConfigNamespace` could have a simpler name

## Proposal

* Remove `linera-server initialize`
* Create `CommonStorageOptions` and used `#[Clap::flatten]` to share
code between the different binaries.
* Rename `StorageConfig` into `InnerStorageConfig`
* Rename `StorageConfigNamespace` into `StorageConfig`

`InnerStorageConfig` is still visible and used directly in a few places
for now, but we'd like `StorageConfig` to be the real public type.

NOTE: The common storage options are now prefixed with `--storage`, e.g.
`--storage-cache-size`.

## Test Plan

CI + `git grep linera-server`

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

Author: ma2bd

CLI.md

@@ -108,7 +108,6 @@ A Byzantine-fault tolerant sidechain with low-latency finality and high throughp
 
 ###### **Options:**
 
-* `--storage <STORAGE_CONFIG>` — Storage configuration for the blockchain history
 * `--wallet <WALLET_STATE_PATH>` — Sets the file storing the private state of user chains (an empty one will be created if missing)
 * `--keystore <KEYSTORE_PATH>` — Sets the file storing the keystore state
 * `-w`, `--with-wallet <WITH_WALLET>` — Given an ASCII alphanumeric parameter `X`, read the wallet state and the wallet storage config from the environment variables `LINERA_WALLET_{X}` and `LINERA_STORAGE_{X}` instead of `LINERA_WALLET` and `LINERA_STORAGE`
@@ -151,25 +150,26 @@ A Byzantine-fault tolerant sidechain with low-latency finality and high throughp
 * `--blob-download-timeout-ms <BLOB_DOWNLOAD_TIMEOUT>` — The delay when downloading a blob, after which we try a second validator, in milliseconds
 
   Default value: `1000`
-* `--max-concurrent-queries <MAX_CONCURRENT_QUERIES>` — The maximal number of simultaneous queries to the database
-* `--max-stream-queries <MAX_STREAM_QUERIES>` — The maximal number of simultaneous stream queries to the database
+* `--storage <STORAGE_CONFIG>` — Storage configuration for the blockchain history
+* `--storage-max-concurrent-queries <STORAGE_MAX_CONCURRENT_QUERIES>` — The maximal number of simultaneous queries to the database
+* `--storage-max-stream-queries <STORAGE_MAX_STREAM_QUERIES>` — The maximal number of simultaneous stream queries to the database
 
   Default value: `10`
-* `--max-cache-size <MAX_CACHE_SIZE>` — The maximal memory used in the storage cache
+* `--storage-max-cache-size <STORAGE_MAX_CACHE_SIZE>` — The maximal memory used in the storage cache
 
   Default value: `10000000`
-* `--max-entry-size <MAX_ENTRY_SIZE>` — The maximal size of an entry in the storage cache
+* `--storage-max-entry-size <STORAGE_MAX_ENTRY_SIZE>` — The maximal size of an entry in the storage cache
 
   Default value: `1000000`
-* `--max-cache-entries <MAX_CACHE_ENTRIES>` — The maximal number of entries in the storage cache
+* `--storage-max-cache-entries <STORAGE_MAX_CACHE_ENTRIES>` — The maximal number of entries in the storage cache
 
   Default value: `1000`
-* `--wasm-runtime <WASM_RUNTIME>` — The WebAssembly runtime to use
-* `--tokio-threads <TOKIO_THREADS>` — The number of Tokio worker threads to use
-* `--tokio-blocking-threads <TOKIO_BLOCKING_THREADS>` — The number of Tokio blocking threads to use
 * `--storage-replication-factor <STORAGE_REPLICATION_FACTOR>` — The replication factor for the keyspace
 
   Default value: `1`
+* `--wasm-runtime <WASM_RUNTIME>` — The WebAssembly runtime to use
+* `--tokio-threads <TOKIO_THREADS>` — The number of Tokio worker threads to use
+* `--tokio-blocking-threads <TOKIO_BLOCKING_THREADS>` — The number of Tokio blocking threads to use
 
 
 

docker/compose-server-init.sh

@@ -11,9 +11,8 @@ while true; do
     exit 0
   elif [ $status -eq 1 ]; then
     echo "Database does not exist, attempting to initialize..."
-    if ./linera-server initialize \
-      --storage $storage \
-      --genesis /config/genesis.json; then
+    if ./linera storage initialize --storage $storage --genesis /config/genesis.json
+    then
       echo "Initialization successful."
       exit 0
     else

docker/server-init.sh

@@ -12,7 +12,7 @@ while true; do
     exit 0
   elif [ $status -eq 1 ]; then
     echo "Database does not exist, attempting to initialize..."
-    if ./linera-server initialize \
+    if ./linera storage initialize \
       --storage $storage \
       --genesis /config/genesis.json \
       --storage-replication-factor $storage_replication_factor; then