backport faucet PRs #4408 and #4631 #4633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4408) ## Motivation Right now we have a lot of stuff in CI that gets started as a bg process. However, the issue is that if these things start taking slightly longer to start up for some reason, it'll make the test fail, because the test will try to submig requests to something that isn't ready yet. ## Proposal Explicitly wait for things to be actually up before proceeding. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle.
## Motivation Requesting a new chain from the faucet now takes 3 seconds because the JSON file with the "account owner → chain description" map is getting very large. ## Proposal Store the map in an SQLite database, with only chain IDs rather than whole descriptions. `--storage-path` is mandatory now. On startup, traverse the chain back to the last block whose created chains are already in the database. Then traverse back up and update the database. (Mostly written with Claude.) ## Test Plan Tests were updated. ## Release Plan - These changes should be backported to the latest `testnet` branch, then - used to restart the faucet with `--storage-path` changed accordingly. Before that, we should manually backup the faucet storage file and make sure that it is complete, i.e. ends with the expected closing `}`. ## Links - Closes linera-io#4624. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist) --------- Co-authored-by: Mathieu Baudet <[email protected]>
ma2bd
changed the title
ma2bd
added
the
backport
ma2bd
added a commit
that referenced
this pull request
Sep 23, 2025
## Motivation Solve the issue of the forgetful faucet ## Proposal backport #4408 and #4631 ## Test Plan CI --------- Co-authored-by: Andre da Silva <[email protected]> Co-authored-by: Andreas Fackler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solve the issue of the forgetful faucet
Proposal
backport #4408 and #4631
Test Plan
CI