code cleanup

Author: sgratzl

R/lineup.R

@@ -1,13 +1,17 @@
 #' LineUp module
 #'
-#' <Add Description>
+#' a htmlwidget wrapper around LineUp (http://lineup.caleydo.org)
 #'
 #' @import htmlwidgets
 #'
 #' @export
 lineup <- function(data, width = NULL, height = NULL, elementId = NULL) {
+  # escape remove .
+  colnames(data) <- gsub("[.]", "_", colnames(data))
+  
   toDescription <- function(col, colname) {
     clazz <- class(col)
+    # print(paste(colname, clazz))
     if (clazz == 'numeric') {
       list(type='number',column=colname, domain=c(min(col),max(col)))
     } else if (clazz == 'factor') { 

inst/htmlwidgets/lineup.js

@@ -5,13 +5,12 @@ HTMLWidgets.widget({
   type: 'output',
 
   factory: function(el, width, height) {
-
-    var data = LineUpJS.createLocalStorage([], []);
-    // TODO: define shared variables for this instance
     el.style.width = width;
     el.style.height = height;
     el.style.position = 'relative';
     el.style.overflow = 'auto';
+
+    var data = LineUpJS.createLocalStorage([], []);
     var lineup = LineUpJS.create(data, el, { body: { renderer: 'canvas'}});
 
     return {