small improvements

Author: jungmair

frontend/packages/insights/src/PerfAsmViewer.js

@@ -8,7 +8,7 @@ const Instruction = ({data, selectionState, onInstrClick}) => {
         e.stopPropagation();
         onInstrClick(data)
     }} style={{backgroundColor:`rgba(255,0,0,${data.localPercentage/100*10})`}}>
-        <div style={{minWidth:80, display:"inline-block"}}>{data.localPercentage>0.05?`${data.localPercentage.toFixed(1)}%`:""}</div><div style={{backgroundColor: selBackgroundColor==="white"? `rgba(255,0,0,${data.localPercentage/100*10})`: selBackgroundColor,display:"inline", fontFamily:"monospace", textDecoration: data.loc?"underline":"default", }}>{data.asm}</div>
+        <div style={{minWidth:80, display:"inline-block"}}>{data.localPercentage>0.05?`${data.localPercentage.toFixed(1)}%`:""}</div><div style={{backgroundColor: selBackgroundColor==="white"? `none`: selBackgroundColor,display:"inline", fontFamily:"monospace", textDecoration: data.loc?"underline":"default", }}>{data.asm}</div>
     </div>)
 
 }

frontend/packages/insights/src/ProfilingView.js

@@ -238,6 +238,12 @@ export const ProfilingView = ({data, onClose}) => {
         setLeftDiffIndex(llvmMLIRData.index - 1)
         setRightDiffIndex(llvmMLIRData.index)
     }
+    const handleImpOpSelection = (op) => {
+        setSelectedOp(op)
+        setSelectedLayer(imperativeMLIRData.index)
+        setLeftDiffIndex(imperativeMLIRData.index - 1)
+        setRightDiffIndex(imperativeMLIRData.index)
+    }
     const handleTraceSelect = (trace) => {
         if (trace.category === "Execution" && trace.name === "Step" && hasLayers) {
             handleSubOpSelection(trace.extra.location)
@@ -397,8 +403,7 @@ export const ProfilingView = ({data, onClose}) => {
                                         <MLIRViewer height={2 * (window.innerHeight - 90) / 3}
                                                     width={(window.innerWidth - 100) / 2}
                                                     layer={imperativeMLIRData} selectedOps={selectedImperativeOps}
-                                                    onOpClick={(d) => {
-                                                    }}></MLIRViewer>
+                                                    onOpClick={(d) => handleImpOpSelection(d.id)}></MLIRViewer>
                                     </div>
                                     <div style={{
                                         visibility: activeRightTab === "mlir_llvm" ? "visible" : "hidden",