feat(macro): default missing other in select macros to empty

Author: MikaelSiidorow

src/macro_utils.rs

@@ -254,7 +254,7 @@ impl MacroCtx {
         icu_format: &str,
     ) -> Vec<CaseOrOffset> {
         // todo: there might be more props then real choices. Id for example
-        let mut choices: Vec<CaseOrOffset> = Vec::with_capacity(props.len());
+        let mut choices: Vec<CaseOrOffset> = Vec::with_capacity(props.len() + 1);
 
         for prop_or_spread in props {
             if let PropOrSpread::Prop(prop) = prop_or_spread {
@@ -282,6 +282,17 @@ impl MacroCtx {
             }
         }
 
+        let no_other_case = !choices
+            .iter()
+            .any(|c| matches!(c, CaseOrOffset::Case(case) if case.key == "other"));
+
+        if no_other_case {
+            choices.push(CaseOrOffset::Case(ChoiceCase {
+                tokens: vec![],
+                key: "other".into(),
+            }));
+        }
+
         choices
     }
 }

src/tests/js_icu.rs

@@ -269,3 +269,24 @@ to!(
       });
     "#
 );
+
+to!(
+    js_should_handle_missing_other_in_select,
+    r#"
+      import { select } from '@lingui/macro'
+      select(value, {
+        offset: "..",
+        any: "..",
+      });
+   "#,
+    r#"
+    import { i18n as $_i18n } from "@lingui/core";
+    $_i18n._({
+        id: "QHtFym",
+        message: "{value, select, offset {..} any {..} other {}}",
+        values: {
+            value: value
+        }
+    });
+  "#
+);

src/tests/jsx_icu.rs

@@ -251,6 +251,24 @@ to!(
     "#
 );
 
+to!(
+    jsx_select_without_other,
+    r#"
+      import { Select } from '@lingui/macro';
+      <Select
+        value={count}
+        _male="He"
+        _female={`She`}
+      />;
+   "#,
+    r#"
+      import { Trans as Trans_ } from "@lingui/react";
+      <Trans_ message={"{count, select, male {He} female {She} other {} id={"Imwef9"} values={{
+        count: count
+      }} />;
+  "#
+);
+
 to!(
     jsx_select_with_expressions_in_cases,
     r#"