feat: use browser-commander launchBrowser for all browser operations

Now that browser-commander v0.4.0 supports custom Chrome args via the
`args` option, we can use its `launchBrowser` function directly instead
of maintaining our own browser launch code.

Changes:
- Update browser-commander dependency from ^0.3.0 to ^0.4.0
- Use launchBrowser from browser-commander for both Puppeteer and Playwright
- Pass server-specific args (--no-sandbox, etc.) via the args option
- Configure headless: true for server environments
- Use unique userDataDir per session to avoid conflicts

This fully integrates browser-commander as requested in issue #24.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: konard

package-lock.json

@@ -32,7 +32,7 @@
     "changeset:status": "changeset status --since=origin/main"
   },
   "dependencies": {
-    "browser-commander": "^0.3.0",
+    "browser-commander": "^0.4.0",
     "cheerio": "^1.0.0",
     "express": "^4.18.2",
     "lino-arguments": "^0.2.1",

package.json

@@ -1,29 +1,20 @@
-// Browser abstraction layer using browser-commander utilities
-// Note: browser-commander's launchBrowser currently doesn't support custom args
-// for headless server environments (--no-sandbox, etc). We use browser-commander's
-// utilities (CHROME_ARGS) and maintain browser launch code here until this
-// feature is added to browser-commander.
-// See: https://github.com/link-foundation/browser-commander/issues/11
+// Browser abstraction layer using browser-commander for all browser operations
+// See: https://github.com/link-foundation/browser-commander
 
-import { CHROME_ARGS } from 'browser-commander';
-import puppeteer from 'puppeteer';
-import playwright from 'playwright';
+import { launchBrowser } from 'browser-commander';
+import os from 'os';
+import path from 'path';
 
 /**
  * Additional Chrome args needed for headless server environments
- * These are not included in browser-commander's CHROME_ARGS yet
+ * These are appended to browser-commander's default CHROME_ARGS
  */
 const SERVER_CHROME_ARGS = [
   '--no-sandbox',
   '--disable-setuid-sandbox',
   '--disable-dev-shm-usage',
 ];
 
-/**
- * Combined Chrome args: browser-commander defaults + server-specific args
- */
-const ALL_CHROME_ARGS = [...CHROME_ARGS, ...SERVER_CHROME_ARGS];
-
 /**
  * Unified browser interface that works with both Puppeteer and Playwright
  * @typedef {Object} BrowserAdapter
@@ -48,70 +39,52 @@ const ALL_CHROME_ARGS = [...CHROME_ARGS, ...SERVER_CHROME_ARGS];
 
 /**
  * Create a browser instance using the specified engine
+ * Uses browser-commander's launchBrowser for both Puppeteer and Playwright
  * @param {string} engine - 'puppeteer' or 'playwright' (defaults to puppeteer)
  * @param {Object} options - Browser launch options
  * @returns {Promise<BrowserAdapter>}
  */
 export async function createBrowser(engine = 'puppeteer', options = {}) {
   const normalizedEngine = engine.toLowerCase();
-
-  if (normalizedEngine === 'playwright') {
-    return await createPlaywrightBrowser(options);
-  } else {
-    return await createPuppeteerBrowser(options);
-  }
-}
-
-/**
- * Create a Puppeteer browser instance
- * @param {Object} options - Puppeteer launch options
- * @returns {Promise<BrowserAdapter>}
- */
-async function createPuppeteerBrowser(options = {}) {
-  const defaultOptions = {
-    args: ALL_CHROME_ARGS,
-  };
-
-  const browser = await puppeteer.launch({ ...defaultOptions, ...options });
-
-  return {
-    async newPage() {
-      const page = await browser.newPage();
-      return createPuppeteerPageAdapter(page);
-    },
-    async close() {
-      await browser.close();
-    },
-    type: 'puppeteer',
-    _browser: browser,
-  };
-}
-
-/**
- * Create a Playwright browser instance
- * @param {Object} options - Playwright launch options
- * @returns {Promise<BrowserAdapter>}
- */
-async function createPlaywrightBrowser(options = {}) {
-  const defaultOptions = {
-    args: ALL_CHROME_ARGS,
-  };
-
-  // Playwright uses chromium by default
-  const browser = await playwright.chromium.launch({
-    ...defaultOptions,
+  const engineType =
+    normalizedEngine === 'playwright' || normalizedEngine === 'pw'
+      ? 'playwright'
+      : 'puppeteer';
+
+  // Generate unique userDataDir for this session to avoid conflicts
+  const userDataDir = path.join(
+    os.tmpdir(),
+    `web-capture-${engineType}-${Date.now()}`
+  );
+
+  // Use browser-commander's launchBrowser with server-specific args
+  // Default to headless for server environments
+  const { browser, page } = await launchBrowser({
+    engine: engineType,
+    args: SERVER_CHROME_ARGS,
+    headless: true,
+    userDataDir,
+    slowMo: 0, // Disable slowMo for server operations
     ...options,
   });
 
+  // Close the initial page since we'll create new ones via newPage()
+  await page.close();
+
+  const pageAdapter =
+    engineType === 'playwright'
+      ? createPlaywrightPageAdapter
+      : createPuppeteerPageAdapter;
+
   return {
     async newPage() {
-      const page = await browser.newPage();
-      return createPlaywrightPageAdapter(page);
+      const newPage = await browser.newPage();
+      return pageAdapter(newPage);
     },
     async close() {
       await browser.close();
     },
-    type: 'playwright',
+    type: engineType,
     _browser: browser,
   };
 }
@@ -191,7 +164,6 @@ function createPlaywrightPageAdapter(page) {
 
 /**
  * Get the browser engine from query parameters or environment variable
- * Uses browser-commander's detectEngine when available, with fallback logic
  * @param {Object} req - Express request object
  * @returns {string} - 'puppeteer' or 'playwright'
  */

src/browser.js

@@ -2022,10 +2022,10 @@ braces@^3.0.3:
   dependencies:
     fill-range "^7.1.1"
 
-browser-commander@^0.3.0:
-  version "0.3.0"
-  resolved "https://registry.npmjs.org/browser-commander/-/browser-commander-0.3.0.tgz"
-  integrity sha512-/1DfX8HsspBkKbQE+cjbt/Dzr/No50CZQ7IjgDk6pmq1M/SATY5cfLyImhkTEvSL7z898ios8qAdLpbEG2HFBQ==
+browser-commander@^0.4.0:
+  version "0.4.0"
+  resolved "https://registry.npmjs.org/browser-commander/-/browser-commander-0.4.0.tgz"
+  integrity sha512-pEC3LqCySJqqxlwobPIyvrjlWFvkO6HEadhvgD1ZM0VVLuO0uYomICRibpZ3VT9RT85XG/suohO6pNrzMs3d5w==
   dependencies:
     log-lazy "^1.0.4"