Skip to content

Do we really need manual sequence creation? #206

@konard

Description

@konard

https://github.com/deepcase/deeplinks/blob/94d5926fdfaa0003c4a9c28980840d66512fdc4f/migrations/1616701513782-links.ts#L19-L23

Maybe we can just use the sorter version that makes the same thing using id BIGSERIAL PRIMARY KEY?
Or maybe it does not do the same thing?

CREATE TABLE ${SCHEMA}."${TABLE_NAME}" (id BIGSERIAL PRIMARY KEY, from_id bigint DEFAULT 0, to_id bigint DEFAULT 0, type_id bigint NOT NULL);

I just tested this SQL statement:

CREATE TABLE test_table (
    id BIGSERIAL PRIMARY KEY
);

And got this result:
Screenshot_20210916_215335

As far as I can find in https://www.postgresql.org/docs/current/sql-createsequence.html

CREATE SEQUENCE ${TABLE_NAME}_id_seq 
AS bigint 
START WITH 1 
INCREMENT BY 1 
NO MINVALUE
NO MAXVALUE
CACHE 1;

all these settings are default, so this is an equivalent of:

CREATE SEQUENCE ${TABLE_NAME}_id_seq;

And all the above is exact equivalent of just id BIGSERIAL PRIMARY KEY.


Forked from deep-foundation/deeplinks#14 by https://github.com/konard/gh-org-migrator

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions