Fix Clippy warnings and add lint allows

- Add crate-level allows for pedantic clippy lints
- Fix doc comments with backticks around type names
- Add #[must_use] attributes where appropriate
- Convert methods with unused self to associated functions
- Fix redundant closures with method references
- Fix format string arguments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: konard

rust/examples/basic_usage.rs

@@ -1,5 +1,7 @@
 //! Basic usage example for the Links Client library
 
+#![allow(clippy::uninlined_format_args)]
+
 use links_client::services::link_db_service::Link;
 use links_client::{ILinks, LinkConstants};
 

rust/src/api/ilinks.rs

@@ -1,12 +1,12 @@
-//! ILinks - Universal flat API compatible with Platform.Data ILinks interface
+//! `ILinks` - Universal flat API compatible with Platform.Data `ILinks` interface
 
 use std::path::PathBuf;
 use thiserror::Error;
 use tracing::debug;
 
 use crate::services::link_db_service::{Link, LinkDBError, LinkDBService};
 
-/// Errors that can occur when using ILinks
+/// Errors that can occur when using `ILinks`
 #[derive(Error, Debug)]
 pub enum ILinksError {
     #[error("LinkDB error: {0}")]
@@ -22,7 +22,7 @@ pub enum ILinksError {
     NoLinksFound,
 }
 
-/// Constants for ILinks operations
+/// Constants for `ILinks` operations
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum LinkConstants {
     /// Continue iteration
@@ -35,6 +35,7 @@ pub enum LinkConstants {
 
 impl LinkConstants {
     /// Get the numeric value for Any constant
+    #[must_use]
     pub const fn any_value() -> u64 {
         0
     }
@@ -49,7 +50,7 @@ pub struct LinkChange {
     pub after: Option<Link>,
 }
 
-/// ILinks - Universal flat Turing complete API for Links
+/// `ILinks` - Universal flat Turing complete API for Links
 /// Compatible with <https://github.com/linksplatform/Data/blob/main/csharp/Platform.Data/ILinks.cs>
 ///
 /// Flat meaning it only works with a single link at a time.
@@ -58,7 +59,7 @@ pub struct ILinks {
 }
 
 impl ILinks {
-    /// Create a new ILinks instance
+    /// Create a new `ILinks` instance
     ///
     /// # Arguments
     ///
@@ -70,6 +71,7 @@ impl ILinks {
     }
 
     /// Get constants for this Links instance
+    #[must_use]
     pub const fn get_constants(&self) -> LinkConstants {
         LinkConstants::Any
     }
@@ -85,11 +87,11 @@ impl ILinks {
     pub async fn count(&self, restriction: Option<&[u64]>) -> Result<usize, ILinksError> {
         let all_links = self.db.read_all_links().await?;
 
-        if restriction.is_none() || restriction.map_or(true, |r| r.is_empty()) {
+        if restriction.is_none() || restriction.map_or(true, <[u64]>::is_empty) {
             return Ok(all_links.len());
         }
 
-        let filtered = self.filter_links(&all_links, restriction);
+        let filtered = Self::filter_links(&all_links, restriction);
         Ok(filtered.len())
     }
 
@@ -108,7 +110,7 @@ impl ILinks {
         F: FnMut(&Link) -> LinkConstants,
     {
         let all_links = self.db.read_all_links().await?;
-        let filtered = self.filter_links(&all_links, restriction);
+        let filtered = Self::filter_links(&all_links, restriction);
 
         if let Some(ref mut h) = handler {
             for link in filtered {
@@ -173,7 +175,7 @@ impl ILinks {
     where
         F: FnMut(LinkChange),
     {
-        if restriction.is_none() || restriction.map_or(true, |r| r.is_empty()) {
+        if restriction.is_none() || restriction.map_or(true, <[u64]>::is_empty) {
             return Err(ILinksError::InvalidRestriction(
                 "Restriction required for update".to_string(),
             ));
@@ -186,7 +188,7 @@ impl ILinks {
         }
 
         let all_links = self.db.read_all_links().await?;
-        let filtered = self.filter_links(&all_links, restriction);
+        let filtered = Self::filter_links(&all_links, restriction);
 
         if filtered.is_empty() {
             return Err(ILinksError::NoLinksFound);
@@ -230,14 +232,14 @@ impl ILinks {
     where
         F: FnMut(LinkChange),
     {
-        if restriction.is_none() || restriction.map_or(true, |r| r.is_empty()) {
+        if restriction.is_none() || restriction.map_or(true, <[u64]>::is_empty) {
             return Err(ILinksError::InvalidRestriction(
                 "Restriction required for delete".to_string(),
             ));
         }
 
         let all_links = self.db.read_all_links().await?;
-        let filtered = self.filter_links(&all_links, restriction);
+        let filtered = Self::filter_links(&all_links, restriction);
 
         if filtered.is_empty() {
             return Err(ILinksError::NoLinksFound);
@@ -260,7 +262,7 @@ impl ILinks {
     }
 
     /// Helper method to filter links based on restriction
-    fn filter_links(&self, links: &[Link], restriction: Option<&[u64]>) -> Vec<Link> {
+    fn filter_links(links: &[Link], restriction: Option<&[u64]>) -> Vec<Link> {
         let restriction = match restriction {
             Some(r) if !r.is_empty() => r,
             _ => return links.to_vec(),
@@ -305,7 +307,6 @@ mod tests {
 
     #[test]
     fn test_filter_links() {
-        let links = ILinks::new(None).unwrap();
         let all_links = vec![
             Link {
                 id: 1,
@@ -325,21 +326,21 @@ mod tests {
         ];
 
         // Filter by ID
-        let filtered = links.filter_links(&all_links, Some(&[1]));
+        let filtered = ILinks::filter_links(&all_links, Some(&[1]));
         assert_eq!(filtered.len(), 1);
         assert_eq!(filtered[0].id, 1);
 
         // Filter by source and target
-        let filtered = links.filter_links(&all_links, Some(&[2, 3]));
+        let filtered = ILinks::filter_links(&all_links, Some(&[2, 3]));
         assert_eq!(filtered.len(), 1);
         assert_eq!(filtered[0].id, 1);
 
         // Filter with Any source
-        let filtered = links.filter_links(&all_links, Some(&[0, 3]));
+        let filtered = ILinks::filter_links(&all_links, Some(&[0, 3]));
         assert_eq!(filtered.len(), 1);
 
         // No restriction returns all
-        let filtered = links.filter_links(&all_links, None);
+        let filtered = ILinks::filter_links(&all_links, None);
         assert_eq!(filtered.len(), 3);
     }
 }

rust/src/api/recursive_links.rs

@@ -1,4 +1,4 @@
-//! RecursiveLinks - Recursive API for working with hierarchical link structures
+//! `RecursiveLinks` - Recursive API for working with hierarchical link structures
 
 use std::future::Future;
 use std::path::PathBuf;
@@ -8,7 +8,7 @@ use tracing::debug;
 
 use crate::services::link_db_service::{Link, LinkDBError, LinkDBService};
 
-/// Errors that can occur when using RecursiveLinks
+/// Errors that can occur when using `RecursiveLinks`
 #[derive(Error, Debug)]
 pub enum RecursiveLinksError {
     #[error("LinkDB error: {0}")]
@@ -30,7 +30,7 @@ pub struct LinkNode {
     pub children: Vec<LinkNode>,
 }
 
-/// RecursiveLinks - API for working with hierarchical link structures
+/// `RecursiveLinks` - API for working with hierarchical link structures
 ///
 /// This API provides methods for traversing and manipulating link trees,
 /// where links can form parent-child relationships.
@@ -41,11 +41,12 @@ pub struct RecursiveLinks {
 }
 
 impl RecursiveLinks {
-    /// Create a new RecursiveLinks instance
+    /// Create a new `RecursiveLinks` instance
     ///
     /// # Arguments
     ///
     /// * `db_path` - Optional path to the database file
+    #[must_use]
     pub fn new(db_path: Option<PathBuf>) -> Self {
         Self {
             db: LinkDBService::new(db_path),
@@ -98,7 +99,7 @@ impl RecursiveLinks {
         }
     }
 
-    /// Recursively build a tree node (using Box::pin for async recursion)
+    /// Recursively build a tree node (using `Box::pin` for async recursion)
     fn build_tree_impl<'a>(
         &'a self,
         link: Link,
@@ -140,7 +141,7 @@ impl RecursiveLinks {
         Ok(true)
     }
 
-    /// Recursively delete a link and its children (using Box::pin for async recursion)
+    /// Recursively delete a link and its children (using `Box::pin` for async recursion)
     fn delete_link_impl<'a>(
         &'a self,
         id: u64,
@@ -160,26 +161,25 @@ impl RecursiveLinks {
     /// Count all links in a tree starting from the given root
     pub async fn count_tree(&self, root_id: u64) -> Result<usize, RecursiveLinksError> {
         let tree = self.build_tree(root_id).await?;
-        match tree {
-            Some(node) => Ok(self.count_nodes(&node)),
-            None => Ok(0),
-        }
+        Ok(tree.map_or(0, |node| Self::count_nodes(&node)))
     }
 
     /// Recursively count nodes in a tree
-    pub fn count_nodes(&self, node: &LinkNode) -> usize {
+    #[must_use]
+    pub fn count_nodes(node: &LinkNode) -> usize {
         let mut count = 1; // Count this node
         for child in &node.children {
-            count += self.count_nodes(child);
+            count += Self::count_nodes(child);
         }
         count
     }
 
     /// Flatten a tree into a list of links (depth-first order)
-    pub fn flatten_tree(&self, node: &LinkNode) -> Vec<Link> {
+    #[must_use]
+    pub fn flatten_tree(node: &LinkNode) -> Vec<Link> {
         let mut result = vec![node.link.clone()];
         for child in &node.children {
-            result.extend(self.flatten_tree(child));
+            result.extend(Self::flatten_tree(child));
         }
         result
     }
@@ -204,8 +204,6 @@ mod tests {
 
     #[test]
     fn test_count_nodes() {
-        let links = RecursiveLinks::new(None);
-
         let tree = LinkNode {
             link: Link {
                 id: 1,
@@ -239,13 +237,11 @@ mod tests {
             ],
         };
 
-        assert_eq!(links.count_nodes(&tree), 4);
+        assert_eq!(RecursiveLinks::count_nodes(&tree), 4);
     }
 
     #[test]
     fn test_flatten_tree() {
-        let links = RecursiveLinks::new(None);
-
         let tree = LinkNode {
             link: Link {
                 id: 1,
@@ -262,7 +258,7 @@ mod tests {
             }],
         };
 
-        let flattened = links.flatten_tree(&tree);
+        let flattened = RecursiveLinks::flatten_tree(&tree);
         assert_eq!(flattened.len(), 2);
         assert_eq!(flattened[0].id, 1);
         assert_eq!(flattened[1].id, 2);

rust/src/lib.rs

@@ -25,6 +25,16 @@
 //! }
 //! ```
 
+// Allow some pedantic clippy lints that are too strict for this crate
+#![allow(clippy::fn_params_excessive_bools)]
+#![allow(clippy::must_use_candidate)]
+#![allow(clippy::use_self)]
+#![allow(clippy::doc_markdown)]
+#![allow(clippy::missing_errors_doc)]
+#![allow(clippy::missing_panics_doc)]
+#![allow(clippy::module_name_repetitions)]
+#![allow(clippy::uninlined_format_args)]
+
 pub mod api;
 pub mod services;
 pub mod utils;

rust/src/services/auth_storage_service.rs

@@ -1,4 +1,4 @@
-//! AuthStorageService - Service for user authentication data storage
+//! `AuthStorageService` - Service for user authentication data storage
 
 use std::collections::HashMap;
 use std::path::PathBuf;
@@ -7,7 +7,7 @@ use tracing::{debug, error};
 
 use super::link_db_service::{LinkDBError, LinkDBService};
 
-/// Errors that can occur when using AuthStorageService
+/// Errors that can occur when using `AuthStorageService`
 #[derive(Error, Debug)]
 pub enum AuthStorageError {
     #[error("LinkDB error: {0}")]
@@ -31,18 +31,18 @@ pub struct User {
     pub data: HashMap<String, String>,
 }
 
-/// AuthStorageService - Service for user authentication data storage
+/// `AuthStorageService` - Service for user authentication data storage
 ///
 /// This service provides methods for storing and retrieving user authentication data
-/// using the LinkDB backend.
+/// using the `LinkDB` backend.
 pub struct AuthStorageService {
     db: LinkDBService,
     /// Type identifier for user links
     user_type_id: u64,
 }
 
 impl AuthStorageService {
-    /// Create a new AuthStorageService with the specified database path
+    /// Create a new `AuthStorageService` with the specified database path
     ///
     /// # Arguments
     ///